You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

merge.go 18KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542
  1. // Copyright 2019 The Gitea Authors.
  2. // All rights reserved.
  3. // SPDX-License-Identifier: MIT
  4. package pull
  5. import (
  6. "context"
  7. "fmt"
  8. "os"
  9. "path/filepath"
  10. "regexp"
  11. "strconv"
  12. "strings"
  13. "code.gitea.io/gitea/models"
  14. "code.gitea.io/gitea/models/db"
  15. git_model "code.gitea.io/gitea/models/git"
  16. issues_model "code.gitea.io/gitea/models/issues"
  17. access_model "code.gitea.io/gitea/models/perm/access"
  18. pull_model "code.gitea.io/gitea/models/pull"
  19. repo_model "code.gitea.io/gitea/models/repo"
  20. "code.gitea.io/gitea/models/unit"
  21. user_model "code.gitea.io/gitea/models/user"
  22. "code.gitea.io/gitea/modules/cache"
  23. "code.gitea.io/gitea/modules/git"
  24. "code.gitea.io/gitea/modules/log"
  25. "code.gitea.io/gitea/modules/references"
  26. repo_module "code.gitea.io/gitea/modules/repository"
  27. "code.gitea.io/gitea/modules/setting"
  28. "code.gitea.io/gitea/modules/timeutil"
  29. issue_service "code.gitea.io/gitea/services/issue"
  30. notify_service "code.gitea.io/gitea/services/notify"
  31. )
  32. // getMergeMessage composes the message used when merging a pull request.
  33. func getMergeMessage(ctx context.Context, baseGitRepo *git.Repository, pr *issues_model.PullRequest, mergeStyle repo_model.MergeStyle, extraVars map[string]string) (message, body string, err error) {
  34. if err := pr.LoadBaseRepo(ctx); err != nil {
  35. return "", "", err
  36. }
  37. if err := pr.LoadHeadRepo(ctx); err != nil {
  38. return "", "", err
  39. }
  40. if err := pr.LoadIssue(ctx); err != nil {
  41. return "", "", err
  42. }
  43. if err := pr.Issue.LoadPoster(ctx); err != nil {
  44. return "", "", err
  45. }
  46. isExternalTracker := pr.BaseRepo.UnitEnabled(ctx, unit.TypeExternalTracker)
  47. issueReference := "#"
  48. if isExternalTracker {
  49. issueReference = "!"
  50. }
  51. if mergeStyle != "" {
  52. templateFilepath := fmt.Sprintf(".gitea/default_merge_message/%s_TEMPLATE.md", strings.ToUpper(string(mergeStyle)))
  53. commit, err := baseGitRepo.GetBranchCommit(pr.BaseRepo.DefaultBranch)
  54. if err != nil {
  55. return "", "", err
  56. }
  57. templateContent, err := commit.GetFileContent(templateFilepath, setting.Repository.PullRequest.DefaultMergeMessageSize)
  58. if err != nil {
  59. if !git.IsErrNotExist(err) {
  60. return "", "", err
  61. }
  62. } else {
  63. vars := map[string]string{
  64. "BaseRepoOwnerName": pr.BaseRepo.OwnerName,
  65. "BaseRepoName": pr.BaseRepo.Name,
  66. "BaseBranch": pr.BaseBranch,
  67. "HeadRepoOwnerName": "",
  68. "HeadRepoName": "",
  69. "HeadBranch": pr.HeadBranch,
  70. "PullRequestTitle": pr.Issue.Title,
  71. "PullRequestDescription": pr.Issue.Content,
  72. "PullRequestPosterName": pr.Issue.Poster.Name,
  73. "PullRequestIndex": strconv.FormatInt(pr.Index, 10),
  74. "PullRequestReference": fmt.Sprintf("%s%d", issueReference, pr.Index),
  75. }
  76. if pr.HeadRepo != nil {
  77. vars["HeadRepoOwnerName"] = pr.HeadRepo.OwnerName
  78. vars["HeadRepoName"] = pr.HeadRepo.Name
  79. }
  80. for extraKey, extraValue := range extraVars {
  81. vars[extraKey] = extraValue
  82. }
  83. refs, err := pr.ResolveCrossReferences(ctx)
  84. if err == nil {
  85. closeIssueIndexes := make([]string, 0, len(refs))
  86. closeWord := "close"
  87. if len(setting.Repository.PullRequest.CloseKeywords) > 0 {
  88. closeWord = setting.Repository.PullRequest.CloseKeywords[0]
  89. }
  90. for _, ref := range refs {
  91. if ref.RefAction == references.XRefActionCloses {
  92. if err := ref.LoadIssue(ctx); err != nil {
  93. return "", "", err
  94. }
  95. closeIssueIndexes = append(closeIssueIndexes, fmt.Sprintf("%s %s%d", closeWord, issueReference, ref.Issue.Index))
  96. }
  97. }
  98. if len(closeIssueIndexes) > 0 {
  99. vars["ClosingIssues"] = strings.Join(closeIssueIndexes, ", ")
  100. } else {
  101. vars["ClosingIssues"] = ""
  102. }
  103. }
  104. message, body = expandDefaultMergeMessage(templateContent, vars)
  105. return message, body, nil
  106. }
  107. }
  108. if mergeStyle == repo_model.MergeStyleRebase {
  109. // for fast-forward rebase, do not amend the last commit if there is no template
  110. return "", "", nil
  111. }
  112. // Squash merge has a different from other styles.
  113. if mergeStyle == repo_model.MergeStyleSquash {
  114. return fmt.Sprintf("%s (%s%d)", pr.Issue.Title, issueReference, pr.Issue.Index), "", nil
  115. }
  116. if pr.BaseRepoID == pr.HeadRepoID {
  117. return fmt.Sprintf("Merge pull request '%s' (%s%d) from %s into %s", pr.Issue.Title, issueReference, pr.Issue.Index, pr.HeadBranch, pr.BaseBranch), "", nil
  118. }
  119. if pr.HeadRepo == nil {
  120. return fmt.Sprintf("Merge pull request '%s' (%s%d) from <deleted>:%s into %s", pr.Issue.Title, issueReference, pr.Issue.Index, pr.HeadBranch, pr.BaseBranch), "", nil
  121. }
  122. return fmt.Sprintf("Merge pull request '%s' (%s%d) from %s:%s into %s", pr.Issue.Title, issueReference, pr.Issue.Index, pr.HeadRepo.FullName(), pr.HeadBranch, pr.BaseBranch), "", nil
  123. }
  124. func expandDefaultMergeMessage(template string, vars map[string]string) (message, body string) {
  125. message = strings.TrimSpace(template)
  126. if splits := strings.SplitN(message, "\n", 2); len(splits) == 2 {
  127. message = splits[0]
  128. body = strings.TrimSpace(splits[1])
  129. }
  130. mapping := func(s string) string { return vars[s] }
  131. return os.Expand(message, mapping), os.Expand(body, mapping)
  132. }
  133. // GetDefaultMergeMessage returns default message used when merging pull request
  134. func GetDefaultMergeMessage(ctx context.Context, baseGitRepo *git.Repository, pr *issues_model.PullRequest, mergeStyle repo_model.MergeStyle) (message, body string, err error) {
  135. return getMergeMessage(ctx, baseGitRepo, pr, mergeStyle, nil)
  136. }
  137. // Merge merges pull request to base repository.
  138. // Caller should check PR is ready to be merged (review and status checks)
  139. func Merge(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User, baseGitRepo *git.Repository, mergeStyle repo_model.MergeStyle, expectedHeadCommitID, message string, wasAutoMerged bool) error {
  140. if err := pr.LoadBaseRepo(ctx); err != nil {
  141. log.Error("Unable to load base repo: %v", err)
  142. return fmt.Errorf("unable to load base repo: %w", err)
  143. } else if err := pr.LoadHeadRepo(ctx); err != nil {
  144. log.Error("Unable to load head repo: %v", err)
  145. return fmt.Errorf("unable to load head repo: %w", err)
  146. }
  147. pullWorkingPool.CheckIn(fmt.Sprint(pr.ID))
  148. defer pullWorkingPool.CheckOut(fmt.Sprint(pr.ID))
  149. // Removing an auto merge pull and ignore if not exist
  150. // FIXME: is this the correct point to do this? Shouldn't this be after IsMergeStyleAllowed?
  151. if err := pull_model.DeleteScheduledAutoMerge(ctx, pr.ID); err != nil && !db.IsErrNotExist(err) {
  152. return err
  153. }
  154. prUnit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests)
  155. if err != nil {
  156. log.Error("pr.BaseRepo.GetUnit(unit.TypePullRequests): %v", err)
  157. return err
  158. }
  159. prConfig := prUnit.PullRequestsConfig()
  160. // Check if merge style is correct and allowed
  161. if !prConfig.IsMergeStyleAllowed(mergeStyle) {
  162. return models.ErrInvalidMergeStyle{ID: pr.BaseRepo.ID, Style: mergeStyle}
  163. }
  164. defer func() {
  165. go AddTestPullRequestTask(doer, pr.BaseRepo.ID, pr.BaseBranch, false, "", "")
  166. }()
  167. pr.MergedCommitID, err = doMergeAndPush(ctx, pr, doer, mergeStyle, expectedHeadCommitID, message)
  168. if err != nil {
  169. return err
  170. }
  171. pr.MergedUnix = timeutil.TimeStampNow()
  172. pr.Merger = doer
  173. pr.MergerID = doer.ID
  174. if _, err := pr.SetMerged(ctx); err != nil {
  175. log.Error("SetMerged %-v: %v", pr, err)
  176. }
  177. if err := pr.LoadIssue(ctx); err != nil {
  178. log.Error("LoadIssue %-v: %v", pr, err)
  179. }
  180. if err := pr.Issue.LoadRepo(ctx); err != nil {
  181. log.Error("pr.Issue.LoadRepo %-v: %v", pr, err)
  182. }
  183. if err := pr.Issue.Repo.LoadOwner(ctx); err != nil {
  184. log.Error("LoadOwner for %-v: %v", pr, err)
  185. }
  186. if wasAutoMerged {
  187. notify_service.AutoMergePullRequest(ctx, doer, pr)
  188. } else {
  189. notify_service.MergePullRequest(ctx, doer, pr)
  190. }
  191. // Reset cached commit count
  192. cache.Remove(pr.Issue.Repo.GetCommitsCountCacheKey(pr.BaseBranch, true))
  193. // Resolve cross references
  194. refs, err := pr.ResolveCrossReferences(ctx)
  195. if err != nil {
  196. log.Error("ResolveCrossReferences: %v", err)
  197. return nil
  198. }
  199. for _, ref := range refs {
  200. if err = ref.LoadIssue(ctx); err != nil {
  201. return err
  202. }
  203. if err = ref.Issue.LoadRepo(ctx); err != nil {
  204. return err
  205. }
  206. close := ref.RefAction == references.XRefActionCloses
  207. if close != ref.Issue.IsClosed {
  208. if err = issue_service.ChangeStatus(ctx, ref.Issue, doer, pr.MergedCommitID, close); err != nil {
  209. // Allow ErrDependenciesLeft
  210. if !issues_model.IsErrDependenciesLeft(err) {
  211. return err
  212. }
  213. }
  214. }
  215. }
  216. return nil
  217. }
  218. // doMergeAndPush performs the merge operation without changing any pull information in database and pushes it up to the base repository
  219. func doMergeAndPush(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User, mergeStyle repo_model.MergeStyle, expectedHeadCommitID, message string) (string, error) {
  220. // Clone base repo.
  221. mergeCtx, cancel, err := createTemporaryRepoForMerge(ctx, pr, doer, expectedHeadCommitID)
  222. if err != nil {
  223. return "", err
  224. }
  225. defer cancel()
  226. // Merge commits.
  227. switch mergeStyle {
  228. case repo_model.MergeStyleMerge:
  229. if err := doMergeStyleMerge(mergeCtx, message); err != nil {
  230. return "", err
  231. }
  232. case repo_model.MergeStyleRebase, repo_model.MergeStyleRebaseMerge:
  233. if err := doMergeStyleRebase(mergeCtx, mergeStyle, message); err != nil {
  234. return "", err
  235. }
  236. case repo_model.MergeStyleSquash:
  237. if err := doMergeStyleSquash(mergeCtx, message); err != nil {
  238. return "", err
  239. }
  240. case repo_model.MergeStyleFastForwardOnly:
  241. if err := doMergeStyleFastForwardOnly(mergeCtx); err != nil {
  242. return "", err
  243. }
  244. default:
  245. return "", models.ErrInvalidMergeStyle{ID: pr.BaseRepo.ID, Style: mergeStyle}
  246. }
  247. // OK we should cache our current head and origin/headbranch
  248. mergeHeadSHA, err := git.GetFullCommitID(ctx, mergeCtx.tmpBasePath, "HEAD")
  249. if err != nil {
  250. return "", fmt.Errorf("Failed to get full commit id for HEAD: %w", err)
  251. }
  252. mergeBaseSHA, err := git.GetFullCommitID(ctx, mergeCtx.tmpBasePath, "original_"+baseBranch)
  253. if err != nil {
  254. return "", fmt.Errorf("Failed to get full commit id for origin/%s: %w", pr.BaseBranch, err)
  255. }
  256. mergeCommitID, err := git.GetFullCommitID(ctx, mergeCtx.tmpBasePath, baseBranch)
  257. if err != nil {
  258. return "", fmt.Errorf("Failed to get full commit id for the new merge: %w", err)
  259. }
  260. // Now it's questionable about where this should go - either after or before the push
  261. // I think in the interests of data safety - failures to push to the lfs should prevent
  262. // the merge as you can always remerge.
  263. if setting.LFS.StartServer {
  264. if err := LFSPush(ctx, mergeCtx.tmpBasePath, mergeHeadSHA, mergeBaseSHA, pr); err != nil {
  265. return "", err
  266. }
  267. }
  268. var headUser *user_model.User
  269. err = pr.HeadRepo.LoadOwner(ctx)
  270. if err != nil {
  271. if !user_model.IsErrUserNotExist(err) {
  272. log.Error("Can't find user: %d for head repository in %-v: %v", pr.HeadRepo.OwnerID, pr, err)
  273. return "", err
  274. }
  275. log.Warn("Can't find user: %d for head repository in %-v - defaulting to doer: %s - %v", pr.HeadRepo.OwnerID, pr, doer.Name, err)
  276. headUser = doer
  277. } else {
  278. headUser = pr.HeadRepo.Owner
  279. }
  280. mergeCtx.env = repo_module.FullPushingEnvironment(
  281. headUser,
  282. doer,
  283. pr.BaseRepo,
  284. pr.BaseRepo.Name,
  285. pr.ID,
  286. )
  287. pushCmd := git.NewCommand(ctx, "push", "origin").AddDynamicArguments(baseBranch + ":" + git.BranchPrefix + pr.BaseBranch)
  288. // Push back to upstream.
  289. // TODO: this cause an api call to "/api/internal/hook/post-receive/...",
  290. // that prevents us from doint the whole merge in one db transaction
  291. if err := pushCmd.Run(mergeCtx.RunOpts()); err != nil {
  292. if strings.Contains(mergeCtx.errbuf.String(), "non-fast-forward") {
  293. return "", &git.ErrPushOutOfDate{
  294. StdOut: mergeCtx.outbuf.String(),
  295. StdErr: mergeCtx.errbuf.String(),
  296. Err: err,
  297. }
  298. } else if strings.Contains(mergeCtx.errbuf.String(), "! [remote rejected]") {
  299. err := &git.ErrPushRejected{
  300. StdOut: mergeCtx.outbuf.String(),
  301. StdErr: mergeCtx.errbuf.String(),
  302. Err: err,
  303. }
  304. err.GenerateMessage()
  305. return "", err
  306. }
  307. return "", fmt.Errorf("git push: %s", mergeCtx.errbuf.String())
  308. }
  309. mergeCtx.outbuf.Reset()
  310. mergeCtx.errbuf.Reset()
  311. return mergeCommitID, nil
  312. }
  313. func commitAndSignNoAuthor(ctx *mergeContext, message string) error {
  314. cmdCommit := git.NewCommand(ctx, "commit").AddOptionFormat("--message=%s", message)
  315. if ctx.signKeyID == "" {
  316. cmdCommit.AddArguments("--no-gpg-sign")
  317. } else {
  318. cmdCommit.AddOptionFormat("-S%s", ctx.signKeyID)
  319. }
  320. if err := cmdCommit.Run(ctx.RunOpts()); err != nil {
  321. log.Error("git commit %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  322. return fmt.Errorf("git commit %v: %w\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  323. }
  324. return nil
  325. }
  326. func runMergeCommand(ctx *mergeContext, mergeStyle repo_model.MergeStyle, cmd *git.Command) error {
  327. if err := cmd.Run(ctx.RunOpts()); err != nil {
  328. // Merge will leave a MERGE_HEAD file in the .git folder if there is a conflict
  329. if _, statErr := os.Stat(filepath.Join(ctx.tmpBasePath, ".git", "MERGE_HEAD")); statErr == nil {
  330. // We have a merge conflict error
  331. log.Debug("MergeConflict %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  332. return models.ErrMergeConflicts{
  333. Style: mergeStyle,
  334. StdOut: ctx.outbuf.String(),
  335. StdErr: ctx.errbuf.String(),
  336. Err: err,
  337. }
  338. } else if strings.Contains(ctx.errbuf.String(), "refusing to merge unrelated histories") {
  339. log.Debug("MergeUnrelatedHistories %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  340. return models.ErrMergeUnrelatedHistories{
  341. Style: mergeStyle,
  342. StdOut: ctx.outbuf.String(),
  343. StdErr: ctx.errbuf.String(),
  344. Err: err,
  345. }
  346. } else if mergeStyle == repo_model.MergeStyleFastForwardOnly && strings.Contains(ctx.errbuf.String(), "Not possible to fast-forward, aborting") {
  347. log.Debug("MergeDivergingFastForwardOnly %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  348. return models.ErrMergeDivergingFastForwardOnly{
  349. StdOut: ctx.outbuf.String(),
  350. StdErr: ctx.errbuf.String(),
  351. Err: err,
  352. }
  353. }
  354. log.Error("git merge %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  355. return fmt.Errorf("git merge %v: %w\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  356. }
  357. ctx.outbuf.Reset()
  358. ctx.errbuf.Reset()
  359. return nil
  360. }
  361. var escapedSymbols = regexp.MustCompile(`([*[?! \\])`)
  362. // IsUserAllowedToMerge check if user is allowed to merge PR with given permissions and branch protections
  363. func IsUserAllowedToMerge(ctx context.Context, pr *issues_model.PullRequest, p access_model.Permission, user *user_model.User) (bool, error) {
  364. if user == nil {
  365. return false, nil
  366. }
  367. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  368. if err != nil {
  369. return false, err
  370. }
  371. if (p.CanWrite(unit.TypeCode) && pb == nil) || (pb != nil && git_model.IsUserMergeWhitelisted(ctx, pb, user.ID, p)) {
  372. return true, nil
  373. }
  374. return false, nil
  375. }
  376. // CheckPullBranchProtections checks whether the PR is ready to be merged (reviews and status checks)
  377. func CheckPullBranchProtections(ctx context.Context, pr *issues_model.PullRequest, skipProtectedFilesCheck bool) (err error) {
  378. if err = pr.LoadBaseRepo(ctx); err != nil {
  379. return fmt.Errorf("LoadBaseRepo: %w", err)
  380. }
  381. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  382. if err != nil {
  383. return fmt.Errorf("LoadProtectedBranch: %v", err)
  384. }
  385. if pb == nil {
  386. return nil
  387. }
  388. isPass, err := IsPullCommitStatusPass(ctx, pr)
  389. if err != nil {
  390. return err
  391. }
  392. if !isPass {
  393. return models.ErrDisallowedToMerge{
  394. Reason: "Not all required status checks successful",
  395. }
  396. }
  397. if !issues_model.HasEnoughApprovals(ctx, pb, pr) {
  398. return models.ErrDisallowedToMerge{
  399. Reason: "Does not have enough approvals",
  400. }
  401. }
  402. if issues_model.MergeBlockedByRejectedReview(ctx, pb, pr) {
  403. return models.ErrDisallowedToMerge{
  404. Reason: "There are requested changes",
  405. }
  406. }
  407. if issues_model.MergeBlockedByOfficialReviewRequests(ctx, pb, pr) {
  408. return models.ErrDisallowedToMerge{
  409. Reason: "There are official review requests",
  410. }
  411. }
  412. if issues_model.MergeBlockedByOutdatedBranch(pb, pr) {
  413. return models.ErrDisallowedToMerge{
  414. Reason: "The head branch is behind the base branch",
  415. }
  416. }
  417. if skipProtectedFilesCheck {
  418. return nil
  419. }
  420. if pb.MergeBlockedByProtectedFiles(pr.ChangedProtectedFiles) {
  421. return models.ErrDisallowedToMerge{
  422. Reason: "Changed protected files",
  423. }
  424. }
  425. return nil
  426. }
  427. // MergedManually mark pr as merged manually
  428. func MergedManually(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User, baseGitRepo *git.Repository, commitID string) error {
  429. pullWorkingPool.CheckIn(fmt.Sprint(pr.ID))
  430. defer pullWorkingPool.CheckOut(fmt.Sprint(pr.ID))
  431. if err := db.WithTx(ctx, func(ctx context.Context) error {
  432. if err := pr.LoadBaseRepo(ctx); err != nil {
  433. return err
  434. }
  435. prUnit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests)
  436. if err != nil {
  437. return err
  438. }
  439. prConfig := prUnit.PullRequestsConfig()
  440. // Check if merge style is correct and allowed
  441. if !prConfig.IsMergeStyleAllowed(repo_model.MergeStyleManuallyMerged) {
  442. return models.ErrInvalidMergeStyle{ID: pr.BaseRepo.ID, Style: repo_model.MergeStyleManuallyMerged}
  443. }
  444. objectFormat := git.ObjectFormatFromName(pr.BaseRepo.ObjectFormatName)
  445. if len(commitID) != objectFormat.FullLength() {
  446. return fmt.Errorf("Wrong commit ID")
  447. }
  448. commit, err := baseGitRepo.GetCommit(commitID)
  449. if err != nil {
  450. if git.IsErrNotExist(err) {
  451. return fmt.Errorf("Wrong commit ID")
  452. }
  453. return err
  454. }
  455. commitID = commit.ID.String()
  456. ok, err := baseGitRepo.IsCommitInBranch(commitID, pr.BaseBranch)
  457. if err != nil {
  458. return err
  459. }
  460. if !ok {
  461. return fmt.Errorf("Wrong commit ID")
  462. }
  463. pr.MergedCommitID = commitID
  464. pr.MergedUnix = timeutil.TimeStamp(commit.Author.When.Unix())
  465. pr.Status = issues_model.PullRequestStatusManuallyMerged
  466. pr.Merger = doer
  467. pr.MergerID = doer.ID
  468. var merged bool
  469. if merged, err = pr.SetMerged(ctx); err != nil {
  470. return err
  471. } else if !merged {
  472. return fmt.Errorf("SetMerged failed")
  473. }
  474. return nil
  475. }); err != nil {
  476. return err
  477. }
  478. notify_service.MergePullRequest(baseGitRepo.Ctx, doer, pr)
  479. log.Info("manuallyMerged[%d]: Marked as manually merged into %s/%s by commit id: %s", pr.ID, pr.BaseRepo.Name, pr.BaseBranch, commitID)
  480. return nil
  481. }