You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

review.go 4.3KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149
  1. // Copyright 2019 The Gitea Authors.
  2. // All rights reserved.
  3. // Use of this source code is governed by a MIT-style
  4. // license that can be found in the LICENSE file.
  5. package pull
  6. import (
  7. "bytes"
  8. "fmt"
  9. "strings"
  10. "code.gitea.io/gitea/models"
  11. "code.gitea.io/gitea/modules/git"
  12. "code.gitea.io/gitea/modules/notification"
  13. "code.gitea.io/gitea/modules/setting"
  14. "code.gitea.io/gitea/services/gitdiff"
  15. )
  16. // CreateCodeComment creates a comment on the code line
  17. func CreateCodeComment(doer *models.User, issue *models.Issue, line int64, content string, treePath string, isReview bool, replyReviewID int64) (*models.Comment, error) {
  18. // It's not a review, maybe a reply to a review comment or a single comment.
  19. if !isReview {
  20. if err := issue.LoadRepo(); err != nil {
  21. return nil, err
  22. }
  23. comment, err := createCodeComment(
  24. doer,
  25. issue.Repo,
  26. issue,
  27. content,
  28. treePath,
  29. line,
  30. replyReviewID,
  31. )
  32. if err != nil {
  33. return nil, err
  34. }
  35. notification.NotifyCreateIssueComment(doer, issue.Repo, issue, comment)
  36. return comment, nil
  37. }
  38. review, err := models.GetCurrentReview(doer, issue)
  39. if err != nil {
  40. if !models.IsErrReviewNotExist(err) {
  41. return nil, err
  42. }
  43. review, err = models.CreateReview(models.CreateReviewOptions{
  44. Type: models.ReviewTypePending,
  45. Reviewer: doer,
  46. Issue: issue,
  47. })
  48. if err != nil {
  49. return nil, err
  50. }
  51. }
  52. comment, err := createCodeComment(
  53. doer,
  54. issue.Repo,
  55. issue,
  56. content,
  57. treePath,
  58. line,
  59. review.ID,
  60. )
  61. if err != nil {
  62. return nil, err
  63. }
  64. // NOTICE: it's a pending review, so the notifications will not be fired until user submit review.
  65. return comment, nil
  66. }
  67. // createCodeComment creates a plain code comment at the specified line / path
  68. func createCodeComment(doer *models.User, repo *models.Repository, issue *models.Issue, content, treePath string, line, reviewID int64) (*models.Comment, error) {
  69. var commitID, patch string
  70. if err := issue.LoadPullRequest(); err != nil {
  71. return nil, fmt.Errorf("GetPullRequestByIssueID: %v", err)
  72. }
  73. pr := issue.PullRequest
  74. if err := pr.GetBaseRepo(); err != nil {
  75. return nil, fmt.Errorf("GetHeadRepo: %v", err)
  76. }
  77. gitRepo, err := git.OpenRepository(pr.BaseRepo.RepoPath())
  78. if err != nil {
  79. return nil, fmt.Errorf("OpenRepository: %v", err)
  80. }
  81. defer gitRepo.Close()
  82. // FIXME validate treePath
  83. // Get latest commit referencing the commented line
  84. // No need for get commit for base branch changes
  85. if line > 0 {
  86. commit, err := gitRepo.LineBlame(pr.GetGitRefName(), gitRepo.Path, treePath, uint(line))
  87. if err == nil {
  88. commitID = commit.ID.String()
  89. } else if !strings.Contains(err.Error(), "exit status 128 - fatal: no such path") {
  90. return nil, fmt.Errorf("LineBlame[%s, %s, %s, %d]: %v", pr.GetGitRefName(), gitRepo.Path, treePath, line, err)
  91. }
  92. }
  93. // Only fetch diff if comment is review comment
  94. if reviewID != 0 {
  95. headCommitID, err := gitRepo.GetRefCommitID(pr.GetGitRefName())
  96. if err != nil {
  97. return nil, fmt.Errorf("GetRefCommitID[%s]: %v", pr.GetGitRefName(), err)
  98. }
  99. patchBuf := new(bytes.Buffer)
  100. if err := gitdiff.GetRawDiffForFile(gitRepo.Path, pr.MergeBase, headCommitID, gitdiff.RawDiffNormal, treePath, patchBuf); err != nil {
  101. return nil, fmt.Errorf("GetRawDiffForLine[%s, %s, %s, %s]: %v", err, gitRepo.Path, pr.MergeBase, headCommitID, treePath)
  102. }
  103. patch = gitdiff.CutDiffAroundLine(patchBuf, int64((&models.Comment{Line: line}).UnsignedLine()), line < 0, setting.UI.CodeCommentLines)
  104. }
  105. return models.CreateComment(&models.CreateCommentOptions{
  106. Type: models.CommentTypeCode,
  107. Doer: doer,
  108. Repo: repo,
  109. Issue: issue,
  110. Content: content,
  111. LineNum: line,
  112. TreePath: treePath,
  113. CommitSHA: commitID,
  114. ReviewID: reviewID,
  115. Patch: patch,
  116. NoAction: true,
  117. })
  118. }
  119. // SubmitReview creates a review out of the existing pending review or creates a new one if no pending review exist
  120. func SubmitReview(doer *models.User, issue *models.Issue, reviewType models.ReviewType, content string) (*models.Review, *models.Comment, error) {
  121. review, comm, err := models.SubmitReview(doer, issue, reviewType, content)
  122. if err != nil {
  123. return nil, nil, err
  124. }
  125. pr, err := issue.GetPullRequest()
  126. if err != nil {
  127. return nil, nil, err
  128. }
  129. notification.NotifyPullRequestReview(pr, review, comm)
  130. return review, comm, nil
  131. }