1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270 |
- // Copyright 2019 The Gitea Authors. All rights reserved.
- // Use of this source code is governed by a MIT-style
- // license that can be found in the LICENSE file.
-
- package cmd
-
- import (
- "context"
- "testing"
-
- "code.gitea.io/gitea/models/auth"
- "code.gitea.io/gitea/services/auth/source/ldap"
-
- "github.com/stretchr/testify/assert"
- "github.com/urfave/cli"
- )
-
- func TestAddLdapBindDn(t *testing.T) {
- // Mock cli functions to do not exit on error
- var osExiter = cli.OsExiter
- defer func() { cli.OsExiter = osExiter }()
- cli.OsExiter = func(code int) {}
-
- // Test cases
- var cases = []struct {
- args []string
- source *auth.Source
- errMsg string
- }{
- // case 0
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source full",
- "--not-active",
- "--security-protocol", "ldaps",
- "--skip-tls-verify",
- "--host", "ldap-bind-server full",
- "--port", "9876",
- "--user-search-base", "ou=Users,dc=full-domain-bind,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=full-domain-bind,dc=org)",
- "--admin-filter", "(memberOf=cn=admin-group,ou=example,dc=full-domain-bind,dc=org)",
- "--restricted-filter", "(memberOf=cn=restricted-group,ou=example,dc=full-domain-bind,dc=org)",
- "--username-attribute", "uid-bind full",
- "--firstname-attribute", "givenName-bind full",
- "--surname-attribute", "sn-bind full",
- "--email-attribute", "mail-bind full",
- "--public-ssh-key-attribute", "publickey-bind full",
- "--avatar-attribute", "avatar-bind full",
- "--bind-dn", "cn=readonly,dc=full-domain-bind,dc=org",
- "--bind-password", "secret-bind-full",
- "--attributes-in-bind",
- "--synchronize-users",
- "--page-size", "99",
- },
- source: &auth.Source{
- Type: auth.LDAP,
- Name: "ldap (via Bind DN) source full",
- IsActive: false,
- IsSyncEnabled: true,
- Cfg: &ldap.Source{
- Name: "ldap (via Bind DN) source full",
- Host: "ldap-bind-server full",
- Port: 9876,
- SecurityProtocol: ldap.SecurityProtocol(1),
- SkipVerify: true,
- BindDN: "cn=readonly,dc=full-domain-bind,dc=org",
- BindPassword: "secret-bind-full",
- UserBase: "ou=Users,dc=full-domain-bind,dc=org",
- AttributeUsername: "uid-bind full",
- AttributeName: "givenName-bind full",
- AttributeSurname: "sn-bind full",
- AttributeMail: "mail-bind full",
- AttributesInBind: true,
- AttributeSSHPublicKey: "publickey-bind full",
- AttributeAvatar: "avatar-bind full",
- SearchPageSize: 99,
- Filter: "(memberOf=cn=user-group,ou=example,dc=full-domain-bind,dc=org)",
- AdminFilter: "(memberOf=cn=admin-group,ou=example,dc=full-domain-bind,dc=org)",
- RestrictedFilter: "(memberOf=cn=restricted-group,ou=example,dc=full-domain-bind,dc=org)",
- Enabled: true,
- },
- },
- },
- // case 1
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source min",
- "--security-protocol", "unencrypted",
- "--host", "ldap-bind-server min",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=min-domain-bind,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=min-domain-bind,dc=org)",
- "--email-attribute", "mail-bind min",
- },
- source: &auth.Source{
- Type: auth.LDAP,
- Name: "ldap (via Bind DN) source min",
- IsActive: true,
- Cfg: &ldap.Source{
- Name: "ldap (via Bind DN) source min",
- Host: "ldap-bind-server min",
- Port: 1234,
- SecurityProtocol: ldap.SecurityProtocol(0),
- UserBase: "ou=Users,dc=min-domain-bind,dc=org",
- AttributeMail: "mail-bind min",
- Filter: "(memberOf=cn=user-group,ou=example,dc=min-domain-bind,dc=org)",
- Enabled: true,
- },
- },
- },
- // case 2
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source",
- "--security-protocol", "zzzzz",
- "--host", "ldap-server",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- "--email-attribute", "mail",
- },
- errMsg: "Unknown security protocol name: zzzzz",
- },
- // case 3
- {
- args: []string{
- "ldap-test",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- "--email-attribute", "mail",
- },
- errMsg: "name is not set",
- },
- // case 4
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source",
- "--host", "ldap-server",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- "--email-attribute", "mail",
- },
- errMsg: "security-protocol is not set",
- },
- // case 5
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source",
- "--security-protocol", "unencrypted",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- "--email-attribute", "mail",
- },
- errMsg: "host is not set",
- },
- // case 6
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- "--email-attribute", "mail",
- },
- errMsg: "port is not set",
- },
- // case 7
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--email-attribute", "mail",
- },
- errMsg: "user-filter is not set",
- },
- // case 8
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (via Bind DN) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "1234",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- },
- errMsg: "email-attribute is not set",
- },
- }
-
- for n, c := range cases {
- // Mock functions.
- var createdAuthSource *auth.Source
- service := &authService{
- initDB: func(context.Context) error {
- return nil
- },
- createAuthSource: func(authSource *auth.Source) error {
- createdAuthSource = authSource
- return nil
- },
- updateAuthSource: func(authSource *auth.Source) error {
- assert.FailNow(t, "case %d: should not call updateAuthSource", n)
- return nil
- },
- getAuthSourceByID: func(id int64) (*auth.Source, error) {
- assert.FailNow(t, "case %d: should not call getAuthSourceByID", n)
- return nil, nil
- },
- }
-
- // Create a copy of command to test
- app := cli.NewApp()
- app.Flags = cmdAuthAddLdapBindDn.Flags
- app.Action = service.addLdapBindDn
-
- // Run it
- err := app.Run(c.args)
- if c.errMsg != "" {
- assert.EqualError(t, err, c.errMsg, "case %d: error should match", n)
- } else {
- assert.NoError(t, err, "case %d: should have no errors", n)
- assert.Equal(t, c.source, createdAuthSource, "case %d: wrong authSource", n)
- }
- }
- }
-
- func TestAddLdapSimpleAuth(t *testing.T) {
- // Mock cli functions to do not exit on error
- var osExiter = cli.OsExiter
- defer func() { cli.OsExiter = osExiter }()
- cli.OsExiter = func(code int) {}
-
- // Test cases
- var cases = []struct {
- args []string
- authSource *auth.Source
- errMsg string
- }{
- // case 0
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source full",
- "--not-active",
- "--security-protocol", "starttls",
- "--skip-tls-verify",
- "--host", "ldap-simple-server full",
- "--port", "987",
- "--user-search-base", "ou=Users,dc=full-domain-simple,dc=org",
- "--user-filter", "(&(objectClass=posixAccount)(full-simple-cn=%s))",
- "--admin-filter", "(memberOf=cn=admin-group,ou=example,dc=full-domain-simple,dc=org)",
- "--restricted-filter", "(memberOf=cn=restricted-group,ou=example,dc=full-domain-simple,dc=org)",
- "--username-attribute", "uid-simple full",
- "--firstname-attribute", "givenName-simple full",
- "--surname-attribute", "sn-simple full",
- "--email-attribute", "mail-simple full",
- "--public-ssh-key-attribute", "publickey-simple full",
- "--avatar-attribute", "avatar-simple full",
- "--user-dn", "cn=%s,ou=Users,dc=full-domain-simple,dc=org",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Name: "ldap (simple auth) source full",
- IsActive: false,
- Cfg: &ldap.Source{
- Name: "ldap (simple auth) source full",
- Host: "ldap-simple-server full",
- Port: 987,
- SecurityProtocol: ldap.SecurityProtocol(2),
- SkipVerify: true,
- UserDN: "cn=%s,ou=Users,dc=full-domain-simple,dc=org",
- UserBase: "ou=Users,dc=full-domain-simple,dc=org",
- AttributeUsername: "uid-simple full",
- AttributeName: "givenName-simple full",
- AttributeSurname: "sn-simple full",
- AttributeMail: "mail-simple full",
- AttributeSSHPublicKey: "publickey-simple full",
- AttributeAvatar: "avatar-simple full",
- Filter: "(&(objectClass=posixAccount)(full-simple-cn=%s))",
- AdminFilter: "(memberOf=cn=admin-group,ou=example,dc=full-domain-simple,dc=org)",
- RestrictedFilter: "(memberOf=cn=restricted-group,ou=example,dc=full-domain-simple,dc=org)",
- Enabled: true,
- },
- },
- },
- // case 1
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source min",
- "--security-protocol", "unencrypted",
- "--host", "ldap-simple-server min",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(min-simple-cn=%s))",
- "--email-attribute", "mail-simple min",
- "--user-dn", "cn=%s,ou=Users,dc=min-domain-simple,dc=org",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Name: "ldap (simple auth) source min",
- IsActive: true,
- Cfg: &ldap.Source{
- Name: "ldap (simple auth) source min",
- Host: "ldap-simple-server min",
- Port: 123,
- SecurityProtocol: ldap.SecurityProtocol(0),
- UserDN: "cn=%s,ou=Users,dc=min-domain-simple,dc=org",
- AttributeMail: "mail-simple min",
- Filter: "(&(objectClass=posixAccount)(min-simple-cn=%s))",
- Enabled: true,
- },
- },
- },
- // case 2
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--security-protocol", "zzzzz",
- "--host", "ldap-server",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--email-attribute", "mail",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "Unknown security protocol name: zzzzz",
- },
- // case 3
- {
- args: []string{
- "ldap-test",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--email-attribute", "mail",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "name is not set",
- },
- // case 4
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--host", "ldap-server",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--email-attribute", "mail",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "security-protocol is not set",
- },
- // case 5
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--security-protocol", "unencrypted",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--email-attribute", "mail",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "host is not set",
- },
- // case 6
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--email-attribute", "mail",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "port is not set",
- },
- // case 7
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "123",
- "--email-attribute", "mail",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "user-filter is not set",
- },
- // case 8
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- errMsg: "email-attribute is not set",
- },
- // case 9
- {
- args: []string{
- "ldap-test",
- "--name", "ldap (simple auth) source",
- "--security-protocol", "unencrypted",
- "--host", "ldap-server",
- "--port", "123",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- "--email-attribute", "mail",
- },
- errMsg: "user-dn is not set",
- },
- }
-
- for n, c := range cases {
- // Mock functions.
- var createdAuthSource *auth.Source
- service := &authService{
- initDB: func(context.Context) error {
- return nil
- },
- createAuthSource: func(authSource *auth.Source) error {
- createdAuthSource = authSource
- return nil
- },
- updateAuthSource: func(authSource *auth.Source) error {
- assert.FailNow(t, "case %d: should not call updateAuthSource", n)
- return nil
- },
- getAuthSourceByID: func(id int64) (*auth.Source, error) {
- assert.FailNow(t, "case %d: should not call getAuthSourceByID", n)
- return nil, nil
- },
- }
-
- // Create a copy of command to test
- app := cli.NewApp()
- app.Flags = cmdAuthAddLdapSimpleAuth.Flags
- app.Action = service.addLdapSimpleAuth
-
- // Run it
- err := app.Run(c.args)
- if c.errMsg != "" {
- assert.EqualError(t, err, c.errMsg, "case %d: error should match", n)
- } else {
- assert.NoError(t, err, "case %d: should have no errors", n)
- assert.Equal(t, c.authSource, createdAuthSource, "case %d: wrong authSource", n)
- }
- }
- }
-
- func TestUpdateLdapBindDn(t *testing.T) {
- // Mock cli functions to do not exit on error
- var osExiter = cli.OsExiter
- defer func() { cli.OsExiter = osExiter }()
- cli.OsExiter = func(code int) {}
-
- // Test cases
- var cases = []struct {
- args []string
- id int64
- existingAuthSource *auth.Source
- authSource *auth.Source
- errMsg string
- }{
- // case 0
- {
- args: []string{
- "ldap-test",
- "--id", "23",
- "--name", "ldap (via Bind DN) source full",
- "--not-active",
- "--security-protocol", "LDAPS",
- "--skip-tls-verify",
- "--host", "ldap-bind-server full",
- "--port", "9876",
- "--user-search-base", "ou=Users,dc=full-domain-bind,dc=org",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=full-domain-bind,dc=org)",
- "--admin-filter", "(memberOf=cn=admin-group,ou=example,dc=full-domain-bind,dc=org)",
- "--restricted-filter", "(memberOf=cn=restricted-group,ou=example,dc=full-domain-bind,dc=org)",
- "--username-attribute", "uid-bind full",
- "--firstname-attribute", "givenName-bind full",
- "--surname-attribute", "sn-bind full",
- "--email-attribute", "mail-bind full",
- "--public-ssh-key-attribute", "publickey-bind full",
- "--avatar-attribute", "avatar-bind full",
- "--bind-dn", "cn=readonly,dc=full-domain-bind,dc=org",
- "--bind-password", "secret-bind-full",
- "--synchronize-users",
- "--page-size", "99",
- },
- id: 23,
- existingAuthSource: &auth.Source{
- Type: auth.LDAP,
- IsActive: true,
- Cfg: &ldap.Source{
- Enabled: true,
- },
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Name: "ldap (via Bind DN) source full",
- IsActive: false,
- IsSyncEnabled: true,
- Cfg: &ldap.Source{
- Name: "ldap (via Bind DN) source full",
- Host: "ldap-bind-server full",
- Port: 9876,
- SecurityProtocol: ldap.SecurityProtocol(1),
- SkipVerify: true,
- BindDN: "cn=readonly,dc=full-domain-bind,dc=org",
- BindPassword: "secret-bind-full",
- UserBase: "ou=Users,dc=full-domain-bind,dc=org",
- AttributeUsername: "uid-bind full",
- AttributeName: "givenName-bind full",
- AttributeSurname: "sn-bind full",
- AttributeMail: "mail-bind full",
- AttributesInBind: false,
- AttributeSSHPublicKey: "publickey-bind full",
- AttributeAvatar: "avatar-bind full",
- SearchPageSize: 99,
- Filter: "(memberOf=cn=user-group,ou=example,dc=full-domain-bind,dc=org)",
- AdminFilter: "(memberOf=cn=admin-group,ou=example,dc=full-domain-bind,dc=org)",
- RestrictedFilter: "(memberOf=cn=restricted-group,ou=example,dc=full-domain-bind,dc=org)",
- Enabled: true,
- },
- },
- },
- // case 1
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{},
- },
- },
- // case 2
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--name", "ldap (via Bind DN) source",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Name: "ldap (via Bind DN) source",
- Cfg: &ldap.Source{
- Name: "ldap (via Bind DN) source",
- },
- },
- },
- // case 3
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--not-active",
- },
- existingAuthSource: &auth.Source{
- Type: auth.LDAP,
- IsActive: true,
- Cfg: &ldap.Source{},
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- IsActive: false,
- Cfg: &ldap.Source{},
- },
- },
- // case 4
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--security-protocol", "LDAPS",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- SecurityProtocol: ldap.SecurityProtocol(1),
- },
- },
- },
- // case 5
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--skip-tls-verify",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- SkipVerify: true,
- },
- },
- },
- // case 6
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--host", "ldap-server",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- Host: "ldap-server",
- },
- },
- },
- // case 7
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--port", "389",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- Port: 389,
- },
- },
- },
- // case 8
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- UserBase: "ou=Users,dc=domain,dc=org",
- },
- },
- },
- // case 9
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--user-filter", "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- Filter: "(memberOf=cn=user-group,ou=example,dc=domain,dc=org)",
- },
- },
- },
- // case 10
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--admin-filter", "(memberOf=cn=admin-group,ou=example,dc=domain,dc=org)",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AdminFilter: "(memberOf=cn=admin-group,ou=example,dc=domain,dc=org)",
- },
- },
- },
- // case 11
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--username-attribute", "uid",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AttributeUsername: "uid",
- },
- },
- },
- // case 12
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--firstname-attribute", "givenName",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AttributeName: "givenName",
- },
- },
- },
- // case 13
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--surname-attribute", "sn",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AttributeSurname: "sn",
- },
- },
- },
- // case 14
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--email-attribute", "mail",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AttributeMail: "mail",
- },
- },
- },
- // case 15
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--attributes-in-bind",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AttributesInBind: true,
- },
- },
- },
- // case 16
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--public-ssh-key-attribute", "publickey",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- AttributeSSHPublicKey: "publickey",
- },
- },
- },
- // case 17
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--bind-dn", "cn=readonly,dc=domain,dc=org",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- BindDN: "cn=readonly,dc=domain,dc=org",
- },
- },
- },
- // case 18
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--bind-password", "secret",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- BindPassword: "secret",
- },
- },
- },
- // case 19
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--synchronize-users",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- IsSyncEnabled: true,
- Cfg: &ldap.Source{},
- },
- },
- // case 20
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--page-size", "12",
- },
- authSource: &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{
- SearchPageSize: 12,
- },
- },
- },
- // case 21
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--security-protocol", "xxxxx",
- },
- errMsg: "Unknown security protocol name: xxxxx",
- },
- // case 22
- {
- args: []string{
- "ldap-test",
- },
- errMsg: "id is not set",
- },
- // case 23
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- },
- existingAuthSource: &auth.Source{
- Type: auth.OAuth2,
- Cfg: &ldap.Source{},
- },
- errMsg: "Invalid authentication type. expected: LDAP (via BindDN), actual: OAuth2",
- },
- }
-
- for n, c := range cases {
- // Mock functions.
- var updatedAuthSource *auth.Source
- service := &authService{
- initDB: func(context.Context) error {
- return nil
- },
- createAuthSource: func(authSource *auth.Source) error {
- assert.FailNow(t, "case %d: should not call createAuthSource", n)
- return nil
- },
- updateAuthSource: func(authSource *auth.Source) error {
- updatedAuthSource = authSource
- return nil
- },
- getAuthSourceByID: func(id int64) (*auth.Source, error) {
- if c.id != 0 {
- assert.Equal(t, c.id, id, "case %d: wrong id", n)
- }
- if c.existingAuthSource != nil {
- return c.existingAuthSource, nil
- }
- return &auth.Source{
- Type: auth.LDAP,
- Cfg: &ldap.Source{},
- }, nil
- },
- }
-
- // Create a copy of command to test
- app := cli.NewApp()
- app.Flags = cmdAuthUpdateLdapBindDn.Flags
- app.Action = service.updateLdapBindDn
-
- // Run it
- err := app.Run(c.args)
- if c.errMsg != "" {
- assert.EqualError(t, err, c.errMsg, "case %d: error should match", n)
- } else {
- assert.NoError(t, err, "case %d: should have no errors", n)
- assert.Equal(t, c.authSource, updatedAuthSource, "case %d: wrong authSource", n)
- }
- }
- }
-
- func TestUpdateLdapSimpleAuth(t *testing.T) {
- // Mock cli functions to do not exit on error
- var osExiter = cli.OsExiter
- defer func() { cli.OsExiter = osExiter }()
- cli.OsExiter = func(code int) {}
-
- // Test cases
- var cases = []struct {
- args []string
- id int64
- existingAuthSource *auth.Source
- authSource *auth.Source
- errMsg string
- }{
- // case 0
- {
- args: []string{
- "ldap-test",
- "--id", "7",
- "--name", "ldap (simple auth) source full",
- "--not-active",
- "--security-protocol", "starttls",
- "--skip-tls-verify",
- "--host", "ldap-simple-server full",
- "--port", "987",
- "--user-search-base", "ou=Users,dc=full-domain-simple,dc=org",
- "--user-filter", "(&(objectClass=posixAccount)(full-simple-cn=%s))",
- "--admin-filter", "(memberOf=cn=admin-group,ou=example,dc=full-domain-simple,dc=org)",
- "--restricted-filter", "(memberOf=cn=restricted-group,ou=example,dc=full-domain-simple,dc=org)",
- "--username-attribute", "uid-simple full",
- "--firstname-attribute", "givenName-simple full",
- "--surname-attribute", "sn-simple full",
- "--email-attribute", "mail-simple full",
- "--public-ssh-key-attribute", "publickey-simple full",
- "--avatar-attribute", "avatar-simple full",
- "--user-dn", "cn=%s,ou=Users,dc=full-domain-simple,dc=org",
- },
- id: 7,
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Name: "ldap (simple auth) source full",
- IsActive: false,
- Cfg: &ldap.Source{
- Name: "ldap (simple auth) source full",
- Host: "ldap-simple-server full",
- Port: 987,
- SecurityProtocol: ldap.SecurityProtocol(2),
- SkipVerify: true,
- UserDN: "cn=%s,ou=Users,dc=full-domain-simple,dc=org",
- UserBase: "ou=Users,dc=full-domain-simple,dc=org",
- AttributeUsername: "uid-simple full",
- AttributeName: "givenName-simple full",
- AttributeSurname: "sn-simple full",
- AttributeMail: "mail-simple full",
- AttributeSSHPublicKey: "publickey-simple full",
- AttributeAvatar: "avatar-simple full",
- Filter: "(&(objectClass=posixAccount)(full-simple-cn=%s))",
- AdminFilter: "(memberOf=cn=admin-group,ou=example,dc=full-domain-simple,dc=org)",
- RestrictedFilter: "(memberOf=cn=restricted-group,ou=example,dc=full-domain-simple,dc=org)",
- },
- },
- },
- // case 1
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{},
- },
- },
- // case 2
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--name", "ldap (simple auth) source",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Name: "ldap (simple auth) source",
- Cfg: &ldap.Source{
- Name: "ldap (simple auth) source",
- },
- },
- },
- // case 3
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--not-active",
- },
- existingAuthSource: &auth.Source{
- Type: auth.DLDAP,
- IsActive: true,
- Cfg: &ldap.Source{},
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- IsActive: false,
- Cfg: &ldap.Source{},
- },
- },
- // case 4
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--security-protocol", "starttls",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- SecurityProtocol: ldap.SecurityProtocol(2),
- },
- },
- },
- // case 5
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--skip-tls-verify",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- SkipVerify: true,
- },
- },
- },
- // case 6
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--host", "ldap-server",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- Host: "ldap-server",
- },
- },
- },
- // case 7
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--port", "987",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- Port: 987,
- },
- },
- },
- // case 8
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--user-search-base", "ou=Users,dc=domain,dc=org",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- UserBase: "ou=Users,dc=domain,dc=org",
- },
- },
- },
- // case 9
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--user-filter", "(&(objectClass=posixAccount)(cn=%s))",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- Filter: "(&(objectClass=posixAccount)(cn=%s))",
- },
- },
- },
- // case 10
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--admin-filter", "(memberOf=cn=admin-group,ou=example,dc=domain,dc=org)",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- AdminFilter: "(memberOf=cn=admin-group,ou=example,dc=domain,dc=org)",
- },
- },
- },
- // case 11
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--username-attribute", "uid",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- AttributeUsername: "uid",
- },
- },
- },
- // case 12
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--firstname-attribute", "givenName",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- AttributeName: "givenName",
- },
- },
- },
- // case 13
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--surname-attribute", "sn",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- AttributeSurname: "sn",
- },
- },
- },
- // case 14
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--email-attribute", "mail",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
-
- AttributeMail: "mail",
- },
- },
- },
- // case 15
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--public-ssh-key-attribute", "publickey",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- AttributeSSHPublicKey: "publickey",
- },
- },
- },
- // case 16
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--user-dn", "cn=%s,ou=Users,dc=domain,dc=org",
- },
- authSource: &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{
- UserDN: "cn=%s,ou=Users,dc=domain,dc=org",
- },
- },
- },
- // case 17
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- "--security-protocol", "xxxxx",
- },
- errMsg: "Unknown security protocol name: xxxxx",
- },
- // case 18
- {
- args: []string{
- "ldap-test",
- },
- errMsg: "id is not set",
- },
- // case 19
- {
- args: []string{
- "ldap-test",
- "--id", "1",
- },
- existingAuthSource: &auth.Source{
- Type: auth.PAM,
- Cfg: &ldap.Source{},
- },
- errMsg: "Invalid authentication type. expected: LDAP (simple auth), actual: PAM",
- },
- }
-
- for n, c := range cases {
- // Mock functions.
- var updatedAuthSource *auth.Source
- service := &authService{
- initDB: func(context.Context) error {
- return nil
- },
- createAuthSource: func(authSource *auth.Source) error {
- assert.FailNow(t, "case %d: should not call createAuthSource", n)
- return nil
- },
- updateAuthSource: func(authSource *auth.Source) error {
- updatedAuthSource = authSource
- return nil
- },
- getAuthSourceByID: func(id int64) (*auth.Source, error) {
- if c.id != 0 {
- assert.Equal(t, c.id, id, "case %d: wrong id", n)
- }
- if c.existingAuthSource != nil {
- return c.existingAuthSource, nil
- }
- return &auth.Source{
- Type: auth.DLDAP,
- Cfg: &ldap.Source{},
- }, nil
- },
- }
-
- // Create a copy of command to test
- app := cli.NewApp()
- app.Flags = cmdAuthUpdateLdapSimpleAuth.Flags
- app.Action = service.updateLdapSimpleAuth
-
- // Run it
- err := app.Run(c.args)
- if c.errMsg != "" {
- assert.EqualError(t, err, c.errMsg, "case %d: error should match", n)
- } else {
- assert.NoError(t, err, "case %d: should have no errors", n)
- assert.Equal(t, c.authSource, updatedAuthSource, "case %d: wrong authSource", n)
- }
- }
- }
|