You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // SPDX-License-Identifier: MIT
  3. package issues_test
  4. import (
  5. "context"
  6. "fmt"
  7. "sort"
  8. "sync"
  9. "testing"
  10. "time"
  11. "code.gitea.io/gitea/models/db"
  12. issues_model "code.gitea.io/gitea/models/issues"
  13. repo_model "code.gitea.io/gitea/models/repo"
  14. "code.gitea.io/gitea/models/unittest"
  15. user_model "code.gitea.io/gitea/models/user"
  16. "code.gitea.io/gitea/modules/setting"
  17. "github.com/stretchr/testify/assert"
  18. "xorm.io/builder"
  19. )
  20. func TestIssue_ReplaceLabels(t *testing.T) {
  21. assert.NoError(t, unittest.PrepareTestDatabase())
  22. testSuccess := func(issueID int64, labelIDs, expectedLabelIDs []int64) {
  23. issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issueID})
  24. repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: issue.RepoID})
  25. doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
  26. labels := make([]*issues_model.Label, len(labelIDs))
  27. for i, labelID := range labelIDs {
  28. labels[i] = unittest.AssertExistsAndLoadBean(t, &issues_model.Label{ID: labelID, RepoID: repo.ID})
  29. }
  30. assert.NoError(t, issues_model.ReplaceIssueLabels(issue, labels, doer))
  31. unittest.AssertCount(t, &issues_model.IssueLabel{IssueID: issueID}, len(expectedLabelIDs))
  32. for _, labelID := range expectedLabelIDs {
  33. unittest.AssertExistsAndLoadBean(t, &issues_model.IssueLabel{IssueID: issueID, LabelID: labelID})
  34. }
  35. }
  36. testSuccess(1, []int64{2}, []int64{2})
  37. testSuccess(1, []int64{1, 2}, []int64{1, 2})
  38. testSuccess(1, []int64{}, []int64{})
  39. // mutually exclusive scoped labels 7 and 8
  40. testSuccess(18, []int64{6, 7}, []int64{6, 7})
  41. testSuccess(18, []int64{7, 8}, []int64{8})
  42. testSuccess(18, []int64{6, 8, 7}, []int64{6, 7})
  43. }
  44. func Test_GetIssueIDsByRepoID(t *testing.T) {
  45. assert.NoError(t, unittest.PrepareTestDatabase())
  46. ids, err := issues_model.GetIssueIDsByRepoID(db.DefaultContext, 1)
  47. assert.NoError(t, err)
  48. assert.Len(t, ids, 5)
  49. }
  50. func TestIssueAPIURL(t *testing.T) {
  51. assert.NoError(t, unittest.PrepareTestDatabase())
  52. issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1})
  53. err := issue.LoadAttributes(db.DefaultContext)
  54. assert.NoError(t, err)
  55. assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/issues/1", issue.APIURL())
  56. }
  57. func TestGetIssuesByIDs(t *testing.T) {
  58. assert.NoError(t, unittest.PrepareTestDatabase())
  59. testSuccess := func(expectedIssueIDs, nonExistentIssueIDs []int64) {
  60. issues, err := issues_model.GetIssuesByIDs(db.DefaultContext, append(expectedIssueIDs, nonExistentIssueIDs...), true)
  61. assert.NoError(t, err)
  62. actualIssueIDs := make([]int64, len(issues))
  63. for i, issue := range issues {
  64. actualIssueIDs[i] = issue.ID
  65. }
  66. assert.Equal(t, expectedIssueIDs, actualIssueIDs)
  67. }
  68. testSuccess([]int64{1, 2, 3}, []int64{})
  69. testSuccess([]int64{1, 2, 3}, []int64{unittest.NonexistentID})
  70. testSuccess([]int64{3, 2, 1}, []int64{})
  71. }
  72. func TestGetParticipantIDsByIssue(t *testing.T) {
  73. assert.NoError(t, unittest.PrepareTestDatabase())
  74. checkParticipants := func(issueID int64, userIDs []int) {
  75. issue, err := issues_model.GetIssueByID(db.DefaultContext, issueID)
  76. assert.NoError(t, err)
  77. participants, err := issue.GetParticipantIDsByIssue(db.DefaultContext)
  78. if assert.NoError(t, err) {
  79. participantsIDs := make([]int, len(participants))
  80. for i, uid := range participants {
  81. participantsIDs[i] = int(uid)
  82. }
  83. sort.Ints(participantsIDs)
  84. sort.Ints(userIDs)
  85. assert.Equal(t, userIDs, participantsIDs)
  86. }
  87. }
  88. // User 1 is issue1 poster (see fixtures/issue.yml)
  89. // User 2 only labeled issue1 (see fixtures/comment.yml)
  90. // Users 3 and 5 made actual comments (see fixtures/comment.yml)
  91. // User 3 is inactive, thus not active participant
  92. checkParticipants(1, []int{1, 5})
  93. }
  94. func TestIssue_ClearLabels(t *testing.T) {
  95. tests := []struct {
  96. issueID int64
  97. doerID int64
  98. }{
  99. {1, 2}, // non-pull-request, has labels
  100. {2, 2}, // pull-request, has labels
  101. {3, 2}, // pull-request, has no labels
  102. }
  103. for _, test := range tests {
  104. assert.NoError(t, unittest.PrepareTestDatabase())
  105. issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: test.issueID})
  106. doer := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: test.doerID})
  107. assert.NoError(t, issues_model.ClearIssueLabels(issue, doer))
  108. unittest.AssertNotExistsBean(t, &issues_model.IssueLabel{IssueID: test.issueID})
  109. }
  110. }
  111. func TestUpdateIssueCols(t *testing.T) {
  112. assert.NoError(t, unittest.PrepareTestDatabase())
  113. issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{})
  114. const newTitle = "New Title for unit test"
  115. issue.Title = newTitle
  116. prevContent := issue.Content
  117. issue.Content = "This should have no effect"
  118. now := time.Now().Unix()
  119. assert.NoError(t, issues_model.UpdateIssueCols(db.DefaultContext, issue, "name"))
  120. then := time.Now().Unix()
  121. updatedIssue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: issue.ID})
  122. assert.EqualValues(t, newTitle, updatedIssue.Title)
  123. assert.EqualValues(t, prevContent, updatedIssue.Content)
  124. unittest.AssertInt64InRange(t, now, then, int64(updatedIssue.UpdatedUnix))
  125. }
  126. func TestIssues(t *testing.T) {
  127. assert.NoError(t, unittest.PrepareTestDatabase())
  128. for _, test := range []struct {
  129. Opts issues_model.IssuesOptions
  130. ExpectedIssueIDs []int64
  131. }{
  132. {
  133. issues_model.IssuesOptions{
  134. AssigneeID: 1,
  135. SortType: "oldest",
  136. },
  137. []int64{1, 6},
  138. },
  139. {
  140. issues_model.IssuesOptions{
  141. RepoCond: builder.In("repo_id", 1, 3),
  142. SortType: "oldest",
  143. Paginator: &db.ListOptions{
  144. Page: 1,
  145. PageSize: 4,
  146. },
  147. },
  148. []int64{1, 2, 3, 5},
  149. },
  150. {
  151. issues_model.IssuesOptions{
  152. LabelIDs: []int64{1},
  153. Paginator: &db.ListOptions{
  154. Page: 1,
  155. PageSize: 4,
  156. },
  157. },
  158. []int64{2, 1},
  159. },
  160. {
  161. issues_model.IssuesOptions{
  162. LabelIDs: []int64{1, 2},
  163. Paginator: &db.ListOptions{
  164. Page: 1,
  165. PageSize: 4,
  166. },
  167. },
  168. []int64{}, // issues with **both** label 1 and 2, none of these issues matches, TODO: add more tests
  169. },
  170. } {
  171. issues, err := issues_model.Issues(db.DefaultContext, &test.Opts)
  172. assert.NoError(t, err)
  173. if assert.Len(t, issues, len(test.ExpectedIssueIDs)) {
  174. for i, issue := range issues {
  175. assert.EqualValues(t, test.ExpectedIssueIDs[i], issue.ID)
  176. }
  177. }
  178. }
  179. }
  180. func TestIssue_loadTotalTimes(t *testing.T) {
  181. assert.NoError(t, unittest.PrepareTestDatabase())
  182. ms, err := issues_model.GetIssueByID(db.DefaultContext, 2)
  183. assert.NoError(t, err)
  184. assert.NoError(t, ms.LoadTotalTimes(db.DefaultContext))
  185. assert.Equal(t, int64(3682), ms.TotalTrackedTime)
  186. }
  187. func TestGetRepoIDsForIssuesOptions(t *testing.T) {
  188. assert.NoError(t, unittest.PrepareTestDatabase())
  189. user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
  190. for _, test := range []struct {
  191. Opts issues_model.IssuesOptions
  192. ExpectedRepoIDs []int64
  193. }{
  194. {
  195. issues_model.IssuesOptions{
  196. AssigneeID: 2,
  197. },
  198. []int64{3, 32},
  199. },
  200. {
  201. issues_model.IssuesOptions{
  202. RepoCond: builder.In("repo_id", 1, 2),
  203. },
  204. []int64{1, 2},
  205. },
  206. } {
  207. repoIDs, err := issues_model.GetRepoIDsForIssuesOptions(&test.Opts, user)
  208. assert.NoError(t, err)
  209. if assert.Len(t, repoIDs, len(test.ExpectedRepoIDs)) {
  210. for i, repoID := range repoIDs {
  211. assert.EqualValues(t, test.ExpectedRepoIDs[i], repoID)
  212. }
  213. }
  214. }
  215. }
  216. func testInsertIssue(t *testing.T, title, content string, expectIndex int64) *issues_model.Issue {
  217. var newIssue issues_model.Issue
  218. t.Run(title, func(t *testing.T) {
  219. repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
  220. user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
  221. issue := issues_model.Issue{
  222. RepoID: repo.ID,
  223. PosterID: user.ID,
  224. Poster: user,
  225. Title: title,
  226. Content: content,
  227. }
  228. err := issues_model.NewIssue(repo, &issue, nil, nil)
  229. assert.NoError(t, err)
  230. has, err := db.GetEngine(db.DefaultContext).ID(issue.ID).Get(&newIssue)
  231. assert.NoError(t, err)
  232. assert.True(t, has)
  233. assert.EqualValues(t, issue.Title, newIssue.Title)
  234. assert.EqualValues(t, issue.Content, newIssue.Content)
  235. if expectIndex > 0 {
  236. assert.EqualValues(t, expectIndex, newIssue.Index)
  237. }
  238. })
  239. return &newIssue
  240. }
  241. func TestIssue_InsertIssue(t *testing.T) {
  242. assert.NoError(t, unittest.PrepareTestDatabase())
  243. // there are 5 issues and max index is 5 on repository 1, so this one should 6
  244. issue := testInsertIssue(t, "my issue1", "special issue's comments?", 6)
  245. _, err := db.GetEngine(db.DefaultContext).ID(issue.ID).Delete(new(issues_model.Issue))
  246. assert.NoError(t, err)
  247. issue = testInsertIssue(t, `my issue2, this is my son's love \n \r \ `, "special issue's '' comments?", 7)
  248. _, err = db.GetEngine(db.DefaultContext).ID(issue.ID).Delete(new(issues_model.Issue))
  249. assert.NoError(t, err)
  250. }
  251. func TestIssue_ResolveMentions(t *testing.T) {
  252. assert.NoError(t, unittest.PrepareTestDatabase())
  253. testSuccess := func(owner, repo, doer string, mentions []string, expected []int64) {
  254. o := unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: owner})
  255. r := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{OwnerID: o.ID, LowerName: repo})
  256. issue := &issues_model.Issue{RepoID: r.ID}
  257. d := unittest.AssertExistsAndLoadBean(t, &user_model.User{LowerName: doer})
  258. resolved, err := issues_model.ResolveIssueMentionsByVisibility(db.DefaultContext, issue, d, mentions)
  259. assert.NoError(t, err)
  260. ids := make([]int64, len(resolved))
  261. for i, user := range resolved {
  262. ids[i] = user.ID
  263. }
  264. sort.Slice(ids, func(i, j int) bool { return ids[i] < ids[j] })
  265. assert.EqualValues(t, expected, ids)
  266. }
  267. // Public repo, existing user
  268. testSuccess("user2", "repo1", "user1", []string{"user5"}, []int64{5})
  269. // Public repo, non-existing user
  270. testSuccess("user2", "repo1", "user1", []string{"nonexisting"}, []int64{})
  271. // Public repo, doer
  272. testSuccess("user2", "repo1", "user1", []string{"user1"}, []int64{})
  273. // Private repo, team member
  274. testSuccess("org17", "big_test_private_4", "user20", []string{"user2"}, []int64{2})
  275. // Private repo, not a team member
  276. testSuccess("org17", "big_test_private_4", "user20", []string{"user5"}, []int64{})
  277. // Private repo, whole team
  278. testSuccess("org17", "big_test_private_4", "user15", []string{"org17/owners"}, []int64{18})
  279. }
  280. func TestResourceIndex(t *testing.T) {
  281. assert.NoError(t, unittest.PrepareTestDatabase())
  282. var wg sync.WaitGroup
  283. for i := 0; i < 100; i++ {
  284. wg.Add(1)
  285. go func(i int) {
  286. testInsertIssue(t, fmt.Sprintf("issue %d", i+1), "my issue", 0)
  287. wg.Done()
  288. }(i)
  289. }
  290. wg.Wait()
  291. }
  292. func TestCorrectIssueStats(t *testing.T) {
  293. assert.NoError(t, unittest.PrepareTestDatabase())
  294. // Because the condition is to have chunked database look-ups,
  295. // We have to more issues than `maxQueryParameters`, we will insert.
  296. // maxQueryParameters + 10 issues into the testDatabase.
  297. // Each new issues will have a constant description "Bugs are nasty"
  298. // Which will be used later on.
  299. issueAmount := issues_model.MaxQueryParameters + 10
  300. var wg sync.WaitGroup
  301. for i := 0; i < issueAmount; i++ {
  302. wg.Add(1)
  303. go func(i int) {
  304. testInsertIssue(t, fmt.Sprintf("Issue %d", i+1), "Bugs are nasty", 0)
  305. wg.Done()
  306. }(i)
  307. }
  308. wg.Wait()
  309. // Now we will get all issueID's that match the "Bugs are nasty" query.
  310. issues, err := issues_model.Issues(context.TODO(), &issues_model.IssuesOptions{
  311. Paginator: &db.ListOptions{
  312. PageSize: issueAmount,
  313. },
  314. RepoIDs: []int64{1},
  315. })
  316. total := int64(len(issues))
  317. var ids []int64
  318. for _, issue := range issues {
  319. if issue.Content == "Bugs are nasty" {
  320. ids = append(ids, issue.ID)
  321. }
  322. }
  323. // Just to be sure.
  324. assert.NoError(t, err)
  325. assert.EqualValues(t, issueAmount, total)
  326. // Now we will call the GetIssueStats with these IDs and if working,
  327. // get the correct stats back.
  328. issueStats, err := issues_model.GetIssueStats(db.DefaultContext, &issues_model.IssuesOptions{
  329. RepoIDs: []int64{1},
  330. IssueIDs: ids,
  331. })
  332. // Now check the values.
  333. assert.NoError(t, err)
  334. assert.EqualValues(t, issueStats.OpenCount, issueAmount)
  335. }
  336. func TestMilestoneList_LoadTotalTrackedTimes(t *testing.T) {
  337. assert.NoError(t, unittest.PrepareTestDatabase())
  338. miles := issues_model.MilestoneList{
  339. unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: 1}),
  340. }
  341. assert.NoError(t, miles.LoadTotalTrackedTimes(db.DefaultContext))
  342. assert.Equal(t, int64(3682), miles[0].TotalTrackedTime)
  343. }
  344. func TestLoadTotalTrackedTime(t *testing.T) {
  345. assert.NoError(t, unittest.PrepareTestDatabase())
  346. milestone := unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: 1})
  347. assert.NoError(t, milestone.LoadTotalTrackedTime(db.DefaultContext))
  348. assert.Equal(t, int64(3682), milestone.TotalTrackedTime)
  349. }
  350. func TestCountIssues(t *testing.T) {
  351. assert.NoError(t, unittest.PrepareTestDatabase())
  352. count, err := issues_model.CountIssues(db.DefaultContext, &issues_model.IssuesOptions{})
  353. assert.NoError(t, err)
  354. assert.EqualValues(t, 20, count)
  355. }
  356. func TestIssueLoadAttributes(t *testing.T) {
  357. assert.NoError(t, unittest.PrepareTestDatabase())
  358. setting.Service.EnableTimetracking = true
  359. issueList := issues_model.IssueList{
  360. unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 1}),
  361. unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 4}),
  362. }
  363. for _, issue := range issueList {
  364. assert.NoError(t, issue.LoadAttributes(db.DefaultContext))
  365. assert.EqualValues(t, issue.RepoID, issue.Repo.ID)
  366. for _, label := range issue.Labels {
  367. assert.EqualValues(t, issue.RepoID, label.RepoID)
  368. unittest.AssertExistsAndLoadBean(t, &issues_model.IssueLabel{IssueID: issue.ID, LabelID: label.ID})
  369. }
  370. if issue.PosterID > 0 {
  371. assert.EqualValues(t, issue.PosterID, issue.Poster.ID)
  372. }
  373. if issue.AssigneeID > 0 {
  374. assert.EqualValues(t, issue.AssigneeID, issue.Assignee.ID)
  375. }
  376. if issue.MilestoneID > 0 {
  377. assert.EqualValues(t, issue.MilestoneID, issue.Milestone.ID)
  378. }
  379. if issue.IsPull {
  380. assert.EqualValues(t, issue.ID, issue.PullRequest.IssueID)
  381. }
  382. for _, attachment := range issue.Attachments {
  383. assert.EqualValues(t, issue.ID, attachment.IssueID)
  384. }
  385. for _, comment := range issue.Comments {
  386. assert.EqualValues(t, issue.ID, comment.IssueID)
  387. }
  388. if issue.ID == int64(1) {
  389. assert.Equal(t, int64(400), issue.TotalTrackedTime)
  390. assert.NotNil(t, issue.Project)
  391. assert.Equal(t, int64(1), issue.Project.ID)
  392. } else {
  393. assert.Nil(t, issue.Project)
  394. }
  395. }
  396. }
  397. func assertCreateIssues(t *testing.T, isPull bool) {
  398. assert.NoError(t, unittest.PrepareTestDatabase())
  399. reponame := "repo1"
  400. repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{Name: reponame})
  401. owner := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: repo.OwnerID})
  402. label := unittest.AssertExistsAndLoadBean(t, &issues_model.Label{ID: 1})
  403. milestone := unittest.AssertExistsAndLoadBean(t, &issues_model.Milestone{ID: 1})
  404. assert.EqualValues(t, milestone.ID, 1)
  405. reaction := &issues_model.Reaction{
  406. Type: "heart",
  407. UserID: owner.ID,
  408. }
  409. title := "issuetitle1"
  410. is := &issues_model.Issue{
  411. RepoID: repo.ID,
  412. MilestoneID: milestone.ID,
  413. Repo: repo,
  414. Title: title,
  415. Content: "issuecontent1",
  416. IsPull: isPull,
  417. PosterID: owner.ID,
  418. Poster: owner,
  419. IsClosed: true,
  420. Labels: []*issues_model.Label{label},
  421. Reactions: []*issues_model.Reaction{reaction},
  422. }
  423. err := issues_model.InsertIssues(is)
  424. assert.NoError(t, err)
  425. i := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{Title: title})
  426. unittest.AssertExistsAndLoadBean(t, &issues_model.Reaction{Type: "heart", UserID: owner.ID, IssueID: i.ID})
  427. }
  428. func TestMigrate_CreateIssuesIsPullFalse(t *testing.T) {
  429. assertCreateIssues(t, false)
  430. }
  431. func TestMigrate_CreateIssuesIsPullTrue(t *testing.T) {
  432. assertCreateIssues(t, true)
  433. }