You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_xref_test.go 7.6KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183
  1. // Copyright 2019 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package models
  5. import (
  6. "fmt"
  7. "testing"
  8. "code.gitea.io/gitea/models/db"
  9. repo_model "code.gitea.io/gitea/models/repo"
  10. "code.gitea.io/gitea/models/unittest"
  11. user_model "code.gitea.io/gitea/models/user"
  12. "code.gitea.io/gitea/modules/references"
  13. "github.com/stretchr/testify/assert"
  14. )
  15. func TestXRef_AddCrossReferences(t *testing.T) {
  16. assert.NoError(t, unittest.PrepareTestDatabase())
  17. // Issue #1 to test against
  18. itarget := testCreateIssue(t, 1, 2, "title1", "content1", false)
  19. // PR to close issue #1
  20. content := fmt.Sprintf("content2, closes #%d", itarget.Index)
  21. pr := testCreateIssue(t, 1, 2, "title2", content, true)
  22. ref := unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: itarget.ID, RefIssueID: pr.ID, RefCommentID: 0}).(*Comment)
  23. assert.Equal(t, CommentTypePullRef, ref.Type)
  24. assert.Equal(t, pr.RepoID, ref.RefRepoID)
  25. assert.True(t, ref.RefIsPull)
  26. assert.Equal(t, references.XRefActionCloses, ref.RefAction)
  27. // Comment on PR to reopen issue #1
  28. content = fmt.Sprintf("content2, reopens #%d", itarget.Index)
  29. c := testCreateComment(t, 1, 2, pr.ID, content)
  30. ref = unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: itarget.ID, RefIssueID: pr.ID, RefCommentID: c.ID}).(*Comment)
  31. assert.Equal(t, CommentTypeCommentRef, ref.Type)
  32. assert.Equal(t, pr.RepoID, ref.RefRepoID)
  33. assert.True(t, ref.RefIsPull)
  34. assert.Equal(t, references.XRefActionReopens, ref.RefAction)
  35. // Issue mentioning issue #1
  36. content = fmt.Sprintf("content3, mentions #%d", itarget.Index)
  37. i := testCreateIssue(t, 1, 2, "title3", content, false)
  38. ref = unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: itarget.ID, RefIssueID: i.ID, RefCommentID: 0}).(*Comment)
  39. assert.Equal(t, CommentTypeIssueRef, ref.Type)
  40. assert.Equal(t, pr.RepoID, ref.RefRepoID)
  41. assert.False(t, ref.RefIsPull)
  42. assert.Equal(t, references.XRefActionNone, ref.RefAction)
  43. // Issue #4 to test against
  44. itarget = testCreateIssue(t, 3, 3, "title4", "content4", false)
  45. // Cross-reference to issue #4 by admin
  46. content = fmt.Sprintf("content5, mentions user3/repo3#%d", itarget.Index)
  47. i = testCreateIssue(t, 2, 1, "title5", content, false)
  48. ref = unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: itarget.ID, RefIssueID: i.ID, RefCommentID: 0}).(*Comment)
  49. assert.Equal(t, CommentTypeIssueRef, ref.Type)
  50. assert.Equal(t, i.RepoID, ref.RefRepoID)
  51. assert.False(t, ref.RefIsPull)
  52. assert.Equal(t, references.XRefActionNone, ref.RefAction)
  53. // Cross-reference to issue #4 with no permission
  54. content = fmt.Sprintf("content6, mentions user3/repo3#%d", itarget.Index)
  55. i = testCreateIssue(t, 4, 5, "title6", content, false)
  56. unittest.AssertNotExistsBean(t, &Comment{IssueID: itarget.ID, RefIssueID: i.ID, RefCommentID: 0})
  57. }
  58. func TestXRef_NeuterCrossReferences(t *testing.T) {
  59. assert.NoError(t, unittest.PrepareTestDatabase())
  60. // Issue #1 to test against
  61. itarget := testCreateIssue(t, 1, 2, "title1", "content1", false)
  62. // Issue mentioning issue #1
  63. title := fmt.Sprintf("title2, mentions #%d", itarget.Index)
  64. i := testCreateIssue(t, 1, 2, title, "content2", false)
  65. ref := unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: itarget.ID, RefIssueID: i.ID, RefCommentID: 0}).(*Comment)
  66. assert.Equal(t, CommentTypeIssueRef, ref.Type)
  67. assert.Equal(t, references.XRefActionNone, ref.RefAction)
  68. d := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).(*user_model.User)
  69. i.Title = "title2, no mentions"
  70. assert.NoError(t, ChangeIssueTitle(i, d, title))
  71. ref = unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: itarget.ID, RefIssueID: i.ID, RefCommentID: 0}).(*Comment)
  72. assert.Equal(t, CommentTypeIssueRef, ref.Type)
  73. assert.Equal(t, references.XRefActionNeutered, ref.RefAction)
  74. }
  75. func TestXRef_ResolveCrossReferences(t *testing.T) {
  76. assert.NoError(t, unittest.PrepareTestDatabase())
  77. d := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2}).(*user_model.User)
  78. i1 := testCreateIssue(t, 1, 2, "title1", "content1", false)
  79. i2 := testCreateIssue(t, 1, 2, "title2", "content2", false)
  80. i3 := testCreateIssue(t, 1, 2, "title3", "content3", false)
  81. _, err := ChangeIssueStatus(db.DefaultContext, i3, d, true)
  82. assert.NoError(t, err)
  83. pr := testCreatePR(t, 1, 2, "titlepr", fmt.Sprintf("closes #%d", i1.Index))
  84. rp := unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: i1.ID, RefIssueID: pr.Issue.ID, RefCommentID: 0}).(*Comment)
  85. c1 := testCreateComment(t, 1, 2, pr.Issue.ID, fmt.Sprintf("closes #%d", i2.Index))
  86. r1 := unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: i2.ID, RefIssueID: pr.Issue.ID, RefCommentID: c1.ID}).(*Comment)
  87. // Must be ignored
  88. c2 := testCreateComment(t, 1, 2, pr.Issue.ID, fmt.Sprintf("mentions #%d", i2.Index))
  89. unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: i2.ID, RefIssueID: pr.Issue.ID, RefCommentID: c2.ID})
  90. // Must be superseded by c4/r4
  91. c3 := testCreateComment(t, 1, 2, pr.Issue.ID, fmt.Sprintf("reopens #%d", i3.Index))
  92. unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: i3.ID, RefIssueID: pr.Issue.ID, RefCommentID: c3.ID})
  93. c4 := testCreateComment(t, 1, 2, pr.Issue.ID, fmt.Sprintf("closes #%d", i3.Index))
  94. r4 := unittest.AssertExistsAndLoadBean(t, &Comment{IssueID: i3.ID, RefIssueID: pr.Issue.ID, RefCommentID: c4.ID}).(*Comment)
  95. refs, err := pr.ResolveCrossReferences(db.DefaultContext)
  96. assert.NoError(t, err)
  97. assert.Len(t, refs, 3)
  98. assert.Equal(t, rp.ID, refs[0].ID, "bad ref rp: %+v", refs[0])
  99. assert.Equal(t, r1.ID, refs[1].ID, "bad ref r1: %+v", refs[1])
  100. assert.Equal(t, r4.ID, refs[2].ID, "bad ref r4: %+v", refs[2])
  101. }
  102. func testCreateIssue(t *testing.T, repo, doer int64, title, content string, ispull bool) *Issue {
  103. r := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: repo}).(*repo_model.Repository)
  104. d := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: doer}).(*user_model.User)
  105. idx, err := db.GetNextResourceIndex("issue_index", r.ID)
  106. assert.NoError(t, err)
  107. i := &Issue{
  108. RepoID: r.ID,
  109. PosterID: d.ID,
  110. Poster: d,
  111. Title: title,
  112. Content: content,
  113. IsPull: ispull,
  114. Index: idx,
  115. }
  116. ctx, committer, err := db.TxContext()
  117. assert.NoError(t, err)
  118. defer committer.Close()
  119. err = newIssue(ctx, d, NewIssueOptions{
  120. Repo: r,
  121. Issue: i,
  122. })
  123. assert.NoError(t, err)
  124. i, err = getIssueByID(ctx, i.ID)
  125. assert.NoError(t, err)
  126. assert.NoError(t, i.addCrossReferences(ctx, d, false))
  127. assert.NoError(t, committer.Commit())
  128. return i
  129. }
  130. func testCreatePR(t *testing.T, repo, doer int64, title, content string) *PullRequest {
  131. r := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: repo}).(*repo_model.Repository)
  132. d := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: doer}).(*user_model.User)
  133. i := &Issue{RepoID: r.ID, PosterID: d.ID, Poster: d, Title: title, Content: content, IsPull: true}
  134. pr := &PullRequest{HeadRepoID: repo, BaseRepoID: repo, HeadBranch: "head", BaseBranch: "base", Status: PullRequestStatusMergeable}
  135. assert.NoError(t, NewPullRequest(db.DefaultContext, r, i, nil, nil, pr))
  136. pr.Issue = i
  137. return pr
  138. }
  139. func testCreateComment(t *testing.T, repo, doer, issue int64, content string) *Comment {
  140. d := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: doer}).(*user_model.User)
  141. i := unittest.AssertExistsAndLoadBean(t, &Issue{ID: issue}).(*Issue)
  142. c := &Comment{Type: CommentTypeComment, PosterID: doer, Poster: d, IssueID: issue, Issue: i, Content: content}
  143. ctx, committer, err := db.TxContext()
  144. assert.NoError(t, err)
  145. defer committer.Close()
  146. err = db.Insert(ctx, c)
  147. assert.NoError(t, err)
  148. assert.NoError(t, c.addCrossReferences(ctx, d, false))
  149. assert.NoError(t, committer.Commit())
  150. return c
  151. }