You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

issue_test.go 11KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404
  1. // Copyright 2017 The Gitea Authors. All rights reserved.
  2. // Use of this source code is governed by a MIT-style
  3. // license that can be found in the LICENSE file.
  4. package models
  5. import (
  6. "sort"
  7. "testing"
  8. "time"
  9. "github.com/stretchr/testify/assert"
  10. )
  11. func TestIssue_ReplaceLabels(t *testing.T) {
  12. assert.NoError(t, PrepareTestDatabase())
  13. testSuccess := func(issueID int64, labelIDs []int64) {
  14. issue := AssertExistsAndLoadBean(t, &Issue{ID: issueID}).(*Issue)
  15. repo := AssertExistsAndLoadBean(t, &Repository{ID: issue.RepoID}).(*Repository)
  16. doer := AssertExistsAndLoadBean(t, &User{ID: repo.OwnerID}).(*User)
  17. labels := make([]*Label, len(labelIDs))
  18. for i, labelID := range labelIDs {
  19. labels[i] = AssertExistsAndLoadBean(t, &Label{ID: labelID, RepoID: repo.ID}).(*Label)
  20. }
  21. assert.NoError(t, issue.ReplaceLabels(labels, doer))
  22. AssertCount(t, &IssueLabel{IssueID: issueID}, len(labelIDs))
  23. for _, labelID := range labelIDs {
  24. AssertExistsAndLoadBean(t, &IssueLabel{IssueID: issueID, LabelID: labelID})
  25. }
  26. }
  27. testSuccess(1, []int64{2})
  28. testSuccess(1, []int64{1, 2})
  29. testSuccess(1, []int64{})
  30. }
  31. func TestIssueAPIURL(t *testing.T) {
  32. assert.NoError(t, PrepareTestDatabase())
  33. issue := AssertExistsAndLoadBean(t, &Issue{ID: 1}).(*Issue)
  34. err := issue.LoadAttributes()
  35. assert.NoError(t, err)
  36. assert.Equal(t, "https://try.gitea.io/api/v1/repos/user2/repo1/issues/1", issue.APIURL())
  37. }
  38. func TestGetIssuesByIDs(t *testing.T) {
  39. assert.NoError(t, PrepareTestDatabase())
  40. testSuccess := func(expectedIssueIDs []int64, nonExistentIssueIDs []int64) {
  41. issues, err := GetIssuesByIDs(append(expectedIssueIDs, nonExistentIssueIDs...))
  42. assert.NoError(t, err)
  43. actualIssueIDs := make([]int64, len(issues))
  44. for i, issue := range issues {
  45. actualIssueIDs[i] = issue.ID
  46. }
  47. assert.Equal(t, expectedIssueIDs, actualIssueIDs)
  48. }
  49. testSuccess([]int64{1, 2, 3}, []int64{})
  50. testSuccess([]int64{1, 2, 3}, []int64{NonexistentID})
  51. }
  52. func TestGetParticipantIDsByIssue(t *testing.T) {
  53. assert.NoError(t, PrepareTestDatabase())
  54. checkParticipants := func(issueID int64, userIDs []int) {
  55. issue, err := GetIssueByID(issueID)
  56. assert.NoError(t, err)
  57. participants, err := issue.getParticipantIDsByIssue(x)
  58. if assert.NoError(t, err) {
  59. participantsIDs := make([]int, len(participants))
  60. for i, uid := range participants {
  61. participantsIDs[i] = int(uid)
  62. }
  63. sort.Ints(participantsIDs)
  64. sort.Ints(userIDs)
  65. assert.Equal(t, userIDs, participantsIDs)
  66. }
  67. }
  68. // User 1 is issue1 poster (see fixtures/issue.yml)
  69. // User 2 only labeled issue1 (see fixtures/comment.yml)
  70. // Users 3 and 5 made actual comments (see fixtures/comment.yml)
  71. // User 3 is inactive, thus not active participant
  72. checkParticipants(1, []int{1, 5})
  73. }
  74. func TestIssue_ClearLabels(t *testing.T) {
  75. var tests = []struct {
  76. issueID int64
  77. doerID int64
  78. }{
  79. {1, 2}, // non-pull-request, has labels
  80. {2, 2}, // pull-request, has labels
  81. {3, 2}, // pull-request, has no labels
  82. }
  83. for _, test := range tests {
  84. assert.NoError(t, PrepareTestDatabase())
  85. issue := AssertExistsAndLoadBean(t, &Issue{ID: test.issueID}).(*Issue)
  86. doer := AssertExistsAndLoadBean(t, &User{ID: test.doerID}).(*User)
  87. assert.NoError(t, issue.ClearLabels(doer))
  88. AssertNotExistsBean(t, &IssueLabel{IssueID: test.issueID})
  89. }
  90. }
  91. func TestUpdateIssueCols(t *testing.T) {
  92. assert.NoError(t, PrepareTestDatabase())
  93. issue := AssertExistsAndLoadBean(t, &Issue{}).(*Issue)
  94. const newTitle = "New Title for unit test"
  95. issue.Title = newTitle
  96. prevContent := issue.Content
  97. issue.Content = "This should have no effect"
  98. now := time.Now().Unix()
  99. assert.NoError(t, updateIssueCols(x, issue, "name"))
  100. then := time.Now().Unix()
  101. updatedIssue := AssertExistsAndLoadBean(t, &Issue{ID: issue.ID}).(*Issue)
  102. assert.EqualValues(t, newTitle, updatedIssue.Title)
  103. assert.EqualValues(t, prevContent, updatedIssue.Content)
  104. AssertInt64InRange(t, now, then, int64(updatedIssue.UpdatedUnix))
  105. }
  106. func TestIssues(t *testing.T) {
  107. assert.NoError(t, PrepareTestDatabase())
  108. for _, test := range []struct {
  109. Opts IssuesOptions
  110. ExpectedIssueIDs []int64
  111. }{
  112. {
  113. IssuesOptions{
  114. AssigneeID: 1,
  115. SortType: "oldest",
  116. },
  117. []int64{1, 6},
  118. },
  119. {
  120. IssuesOptions{
  121. RepoIDs: []int64{1, 3},
  122. SortType: "oldest",
  123. ListOptions: ListOptions{
  124. Page: 1,
  125. PageSize: 4,
  126. },
  127. },
  128. []int64{1, 2, 3, 5},
  129. },
  130. {
  131. IssuesOptions{
  132. LabelIDs: []int64{1},
  133. ListOptions: ListOptions{
  134. Page: 1,
  135. PageSize: 4,
  136. },
  137. },
  138. []int64{2, 1},
  139. },
  140. {
  141. IssuesOptions{
  142. LabelIDs: []int64{1, 2},
  143. ListOptions: ListOptions{
  144. Page: 1,
  145. PageSize: 4,
  146. },
  147. },
  148. []int64{}, // issues with **both** label 1 and 2, none of these issues matches, TODO: add more tests
  149. },
  150. } {
  151. issues, err := Issues(&test.Opts)
  152. assert.NoError(t, err)
  153. if assert.Len(t, issues, len(test.ExpectedIssueIDs)) {
  154. for i, issue := range issues {
  155. assert.EqualValues(t, test.ExpectedIssueIDs[i], issue.ID)
  156. }
  157. }
  158. }
  159. }
  160. func TestGetUserIssueStats(t *testing.T) {
  161. assert.NoError(t, PrepareTestDatabase())
  162. for _, test := range []struct {
  163. Opts UserIssueStatsOptions
  164. ExpectedIssueStats IssueStats
  165. }{
  166. {
  167. UserIssueStatsOptions{
  168. UserID: 1,
  169. RepoIDs: []int64{1},
  170. FilterMode: FilterModeAll,
  171. },
  172. IssueStats{
  173. YourRepositoriesCount: 0,
  174. AssignCount: 1,
  175. CreateCount: 1,
  176. OpenCount: 0,
  177. ClosedCount: 0,
  178. },
  179. },
  180. {
  181. UserIssueStatsOptions{
  182. UserID: 1,
  183. FilterMode: FilterModeAssign,
  184. },
  185. IssueStats{
  186. YourRepositoriesCount: 0,
  187. AssignCount: 2,
  188. CreateCount: 2,
  189. OpenCount: 2,
  190. ClosedCount: 0,
  191. },
  192. },
  193. {
  194. UserIssueStatsOptions{
  195. UserID: 1,
  196. FilterMode: FilterModeCreate,
  197. },
  198. IssueStats{
  199. YourRepositoriesCount: 0,
  200. AssignCount: 2,
  201. CreateCount: 2,
  202. OpenCount: 2,
  203. ClosedCount: 0,
  204. },
  205. },
  206. {
  207. UserIssueStatsOptions{
  208. UserID: 2,
  209. UserRepoIDs: []int64{1, 2},
  210. FilterMode: FilterModeAll,
  211. IsClosed: true,
  212. },
  213. IssueStats{
  214. YourRepositoriesCount: 2,
  215. AssignCount: 0,
  216. CreateCount: 2,
  217. OpenCount: 2,
  218. ClosedCount: 2,
  219. },
  220. },
  221. {
  222. UserIssueStatsOptions{
  223. UserID: 1,
  224. FilterMode: FilterModeMention,
  225. },
  226. IssueStats{
  227. YourRepositoriesCount: 0,
  228. AssignCount: 2,
  229. CreateCount: 2,
  230. OpenCount: 0,
  231. ClosedCount: 0,
  232. },
  233. },
  234. {
  235. UserIssueStatsOptions{
  236. UserID: 1,
  237. FilterMode: FilterModeCreate,
  238. IssueIDs: []int64{1},
  239. },
  240. IssueStats{
  241. YourRepositoriesCount: 0,
  242. AssignCount: 1,
  243. CreateCount: 1,
  244. OpenCount: 1,
  245. ClosedCount: 0,
  246. },
  247. },
  248. } {
  249. stats, err := GetUserIssueStats(test.Opts)
  250. if !assert.NoError(t, err) {
  251. continue
  252. }
  253. assert.Equal(t, test.ExpectedIssueStats, *stats)
  254. }
  255. }
  256. func TestIssue_loadTotalTimes(t *testing.T) {
  257. assert.NoError(t, PrepareTestDatabase())
  258. ms, err := GetIssueByID(2)
  259. assert.NoError(t, err)
  260. assert.NoError(t, ms.loadTotalTimes(x))
  261. assert.Equal(t, int64(3682), ms.TotalTrackedTime)
  262. }
  263. func TestIssue_SearchIssueIDsByKeyword(t *testing.T) {
  264. assert.NoError(t, PrepareTestDatabase())
  265. total, ids, err := SearchIssueIDsByKeyword("issue2", []int64{1}, 10, 0)
  266. assert.NoError(t, err)
  267. assert.EqualValues(t, 1, total)
  268. assert.EqualValues(t, []int64{2}, ids)
  269. total, ids, err = SearchIssueIDsByKeyword("first", []int64{1}, 10, 0)
  270. assert.NoError(t, err)
  271. assert.EqualValues(t, 1, total)
  272. assert.EqualValues(t, []int64{1}, ids)
  273. total, ids, err = SearchIssueIDsByKeyword("for", []int64{1}, 10, 0)
  274. assert.NoError(t, err)
  275. assert.EqualValues(t, 5, total)
  276. assert.EqualValues(t, []int64{1, 2, 3, 5, 11}, ids)
  277. // issue1's comment id 2
  278. total, ids, err = SearchIssueIDsByKeyword("good", []int64{1}, 10, 0)
  279. assert.NoError(t, err)
  280. assert.EqualValues(t, 1, total)
  281. assert.EqualValues(t, []int64{1}, ids)
  282. }
  283. func TestGetRepoIDsForIssuesOptions(t *testing.T) {
  284. assert.NoError(t, PrepareTestDatabase())
  285. user := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
  286. for _, test := range []struct {
  287. Opts IssuesOptions
  288. ExpectedRepoIDs []int64
  289. }{
  290. {
  291. IssuesOptions{
  292. AssigneeID: 2,
  293. },
  294. []int64{3},
  295. },
  296. {
  297. IssuesOptions{
  298. RepoIDs: []int64{1, 2},
  299. },
  300. []int64{1, 2},
  301. },
  302. } {
  303. repoIDs, err := GetRepoIDsForIssuesOptions(&test.Opts, user)
  304. assert.NoError(t, err)
  305. if assert.Len(t, repoIDs, len(test.ExpectedRepoIDs)) {
  306. for i, repoID := range repoIDs {
  307. assert.EqualValues(t, test.ExpectedRepoIDs[i], repoID)
  308. }
  309. }
  310. }
  311. }
  312. func testInsertIssue(t *testing.T, title, content string) {
  313. repo := AssertExistsAndLoadBean(t, &Repository{ID: 1}).(*Repository)
  314. user := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
  315. var issue = Issue{
  316. RepoID: repo.ID,
  317. PosterID: user.ID,
  318. Title: title,
  319. Content: content,
  320. }
  321. err := NewIssue(repo, &issue, nil, nil)
  322. assert.NoError(t, err)
  323. var newIssue Issue
  324. has, err := x.ID(issue.ID).Get(&newIssue)
  325. assert.NoError(t, err)
  326. assert.True(t, has)
  327. assert.EqualValues(t, issue.Title, newIssue.Title)
  328. assert.EqualValues(t, issue.Content, newIssue.Content)
  329. // there are 5 issues and max index is 5 on repository 1, so this one should 6
  330. assert.EqualValues(t, 6, newIssue.Index)
  331. _, err = x.ID(issue.ID).Delete(new(Issue))
  332. assert.NoError(t, err)
  333. }
  334. func TestIssue_InsertIssue(t *testing.T) {
  335. assert.NoError(t, PrepareTestDatabase())
  336. testInsertIssue(t, "my issue1", "special issue's comments?")
  337. testInsertIssue(t, `my issue2, this is my son's love \n \r \ `, "special issue's '' comments?")
  338. }
  339. func TestIssue_ResolveMentions(t *testing.T) {
  340. assert.NoError(t, PrepareTestDatabase())
  341. testSuccess := func(owner, repo, doer string, mentions []string, expected []int64) {
  342. o := AssertExistsAndLoadBean(t, &User{LowerName: owner}).(*User)
  343. r := AssertExistsAndLoadBean(t, &Repository{OwnerID: o.ID, LowerName: repo}).(*Repository)
  344. issue := &Issue{RepoID: r.ID}
  345. d := AssertExistsAndLoadBean(t, &User{LowerName: doer}).(*User)
  346. resolved, err := issue.ResolveMentionsByVisibility(DefaultDBContext(), d, mentions)
  347. assert.NoError(t, err)
  348. ids := make([]int64, len(resolved))
  349. for i, user := range resolved {
  350. ids[i] = user.ID
  351. }
  352. sort.Slice(ids, func(i, j int) bool { return ids[i] < ids[j] })
  353. assert.EqualValues(t, expected, ids)
  354. }
  355. // Public repo, existing user
  356. testSuccess("user2", "repo1", "user1", []string{"user5"}, []int64{5})
  357. // Public repo, non-existing user
  358. testSuccess("user2", "repo1", "user1", []string{"nonexisting"}, []int64{})
  359. // Public repo, doer
  360. testSuccess("user2", "repo1", "user1", []string{"user1"}, []int64{})
  361. // Private repo, team member
  362. testSuccess("user17", "big_test_private_4", "user20", []string{"user2"}, []int64{2})
  363. // Private repo, not a team member
  364. testSuccess("user17", "big_test_private_4", "user20", []string{"user5"}, []int64{})
  365. // Private repo, whole team
  366. testSuccess("user17", "big_test_private_4", "user15", []string{"owners"}, []int64{18})
  367. }