You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

check.go 13KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396
  1. // Copyright 2019 The Gitea Authors.
  2. // All rights reserved.
  3. // SPDX-License-Identifier: MIT
  4. package pull
  5. import (
  6. "context"
  7. "errors"
  8. "fmt"
  9. "strconv"
  10. "strings"
  11. "code.gitea.io/gitea/models"
  12. "code.gitea.io/gitea/models/db"
  13. git_model "code.gitea.io/gitea/models/git"
  14. issues_model "code.gitea.io/gitea/models/issues"
  15. access_model "code.gitea.io/gitea/models/perm/access"
  16. repo_model "code.gitea.io/gitea/models/repo"
  17. "code.gitea.io/gitea/models/unit"
  18. user_model "code.gitea.io/gitea/models/user"
  19. "code.gitea.io/gitea/modules/git"
  20. "code.gitea.io/gitea/modules/graceful"
  21. "code.gitea.io/gitea/modules/log"
  22. "code.gitea.io/gitea/modules/notification"
  23. "code.gitea.io/gitea/modules/process"
  24. "code.gitea.io/gitea/modules/queue"
  25. "code.gitea.io/gitea/modules/timeutil"
  26. asymkey_service "code.gitea.io/gitea/services/asymkey"
  27. )
  28. // prPatchCheckerQueue represents a queue to handle update pull request tests
  29. var prPatchCheckerQueue *queue.WorkerPoolQueue[string]
  30. var (
  31. ErrIsClosed = errors.New("pull is closed")
  32. ErrUserNotAllowedToMerge = models.ErrDisallowedToMerge{}
  33. ErrHasMerged = errors.New("has already been merged")
  34. ErrIsWorkInProgress = errors.New("work in progress PRs cannot be merged")
  35. ErrIsChecking = errors.New("cannot merge while conflict checking is in progress")
  36. ErrNotMergableState = errors.New("not in mergeable state")
  37. ErrDependenciesLeft = errors.New("is blocked by an open dependency")
  38. )
  39. // AddToTaskQueue adds itself to pull request test task queue.
  40. func AddToTaskQueue(pr *issues_model.PullRequest) {
  41. pr.Status = issues_model.PullRequestStatusChecking
  42. err := pr.UpdateColsIfNotMerged(db.DefaultContext, "status")
  43. if err != nil {
  44. log.Error("AddToTaskQueue(%-v).UpdateCols.(add to queue): %v", pr, err)
  45. return
  46. }
  47. log.Trace("Adding %-v to the test pull requests queue", pr)
  48. err = prPatchCheckerQueue.Push(strconv.FormatInt(pr.ID, 10))
  49. if err != nil && err != queue.ErrAlreadyInQueue {
  50. log.Error("Error adding %-v to the test pull requests queue: %v", pr, err)
  51. }
  52. }
  53. type MergeCheckType int
  54. const (
  55. MergeCheckTypeGeneral MergeCheckType = iota // general merge checks for "merge", "rebase", "squash", etc
  56. MergeCheckTypeManually // Manually Merged button (mark a PR as merged manually)
  57. MergeCheckTypeAuto // Auto Merge (Scheduled Merge) After Checks Succeed
  58. )
  59. // CheckPullMergable check if the pull mergable based on all conditions (branch protection, merge options, ...)
  60. func CheckPullMergable(stdCtx context.Context, doer *user_model.User, perm *access_model.Permission, pr *issues_model.PullRequest, mergeCheckType MergeCheckType, adminSkipProtectionCheck bool) error {
  61. return db.WithTx(stdCtx, func(ctx context.Context) error {
  62. if pr.HasMerged {
  63. return ErrHasMerged
  64. }
  65. if err := pr.LoadIssue(ctx); err != nil {
  66. log.Error("Unable to load issue[%d] for %-v: %v", pr.IssueID, pr, err)
  67. return err
  68. } else if pr.Issue.IsClosed {
  69. return ErrIsClosed
  70. }
  71. if allowedMerge, err := IsUserAllowedToMerge(ctx, pr, *perm, doer); err != nil {
  72. log.Error("Error whilst checking if %-v is allowed to merge %-v: %v", doer, pr, err)
  73. return err
  74. } else if !allowedMerge {
  75. return ErrUserNotAllowedToMerge
  76. }
  77. if mergeCheckType == MergeCheckTypeManually {
  78. // if doer is doing "manually merge" (mark as merged manually), do not check anything
  79. return nil
  80. }
  81. if pr.IsWorkInProgress() {
  82. return ErrIsWorkInProgress
  83. }
  84. if !pr.CanAutoMerge() && !pr.IsEmpty() {
  85. return ErrNotMergableState
  86. }
  87. if pr.IsChecking() {
  88. return ErrIsChecking
  89. }
  90. if err := CheckPullBranchProtections(ctx, pr, false); err != nil {
  91. if !models.IsErrDisallowedToMerge(err) {
  92. log.Error("Error whilst checking pull branch protection for %-v: %v", pr, err)
  93. return err
  94. }
  95. // Now the branch protection check failed, check whether the failure could be skipped (skip by setting err = nil)
  96. // * when doing Auto Merge (Scheduled Merge After Checks Succeed), skip the branch protection check
  97. if mergeCheckType == MergeCheckTypeAuto {
  98. err = nil
  99. }
  100. // * if the doer is admin, they could skip the branch protection check
  101. if adminSkipProtectionCheck {
  102. if isRepoAdmin, errCheckAdmin := access_model.IsUserRepoAdmin(ctx, pr.BaseRepo, doer); errCheckAdmin != nil {
  103. log.Error("Unable to check if %-v is a repo admin in %-v: %v", doer, pr.BaseRepo, errCheckAdmin)
  104. return errCheckAdmin
  105. } else if isRepoAdmin {
  106. err = nil // repo admin can skip the check, so clear the error
  107. }
  108. }
  109. // If there is still a branch protection check error, return it
  110. if err != nil {
  111. return err
  112. }
  113. }
  114. if _, err := isSignedIfRequired(ctx, pr, doer); err != nil {
  115. return err
  116. }
  117. if noDeps, err := issues_model.IssueNoDependenciesLeft(ctx, pr.Issue); err != nil {
  118. return err
  119. } else if !noDeps {
  120. return ErrDependenciesLeft
  121. }
  122. return nil
  123. })
  124. }
  125. // isSignedIfRequired check if merge will be signed if required
  126. func isSignedIfRequired(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User) (bool, error) {
  127. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  128. if err != nil {
  129. return false, err
  130. }
  131. if pb == nil || !pb.RequireSignedCommits {
  132. return true, nil
  133. }
  134. sign, _, _, err := asymkey_service.SignMerge(ctx, pr, doer, pr.BaseRepo.RepoPath(), pr.BaseBranch, pr.GetGitRefName())
  135. return sign, err
  136. }
  137. // checkAndUpdateStatus checks if pull request is possible to leaving checking status,
  138. // and set to be either conflict or mergeable.
  139. func checkAndUpdateStatus(ctx context.Context, pr *issues_model.PullRequest) {
  140. // If status has not been changed to conflict by testPatch then we are mergeable
  141. if pr.Status == issues_model.PullRequestStatusChecking {
  142. pr.Status = issues_model.PullRequestStatusMergeable
  143. }
  144. // Make sure there is no waiting test to process before leaving the checking status.
  145. has, err := prPatchCheckerQueue.Has(strconv.FormatInt(pr.ID, 10))
  146. if err != nil {
  147. log.Error("Unable to check if the queue is waiting to reprocess %-v. Error: %v", pr, err)
  148. }
  149. if has {
  150. log.Trace("Not updating status for %-v as it is due to be rechecked", pr)
  151. return
  152. }
  153. if err := pr.UpdateColsIfNotMerged(ctx, "merge_base", "status", "conflicted_files", "changed_protected_files"); err != nil {
  154. log.Error("Update[%-v]: %v", pr, err)
  155. }
  156. }
  157. // getMergeCommit checks if a pull request has been merged
  158. // Returns the git.Commit of the pull request if merged
  159. func getMergeCommit(ctx context.Context, pr *issues_model.PullRequest) (*git.Commit, error) {
  160. if err := pr.LoadBaseRepo(ctx); err != nil {
  161. return nil, fmt.Errorf("unable to load base repo for %s: %w", pr, err)
  162. }
  163. prHeadRef := pr.GetGitRefName()
  164. // Check if the pull request is merged into BaseBranch
  165. if _, _, err := git.NewCommand(ctx, "merge-base", "--is-ancestor").
  166. AddDynamicArguments(prHeadRef, pr.BaseBranch).
  167. RunStdString(&git.RunOpts{Dir: pr.BaseRepo.RepoPath()}); err != nil {
  168. if strings.Contains(err.Error(), "exit status 1") {
  169. // prHeadRef is not an ancestor of the base branch
  170. return nil, nil
  171. }
  172. // Errors are signaled by a non-zero status that is not 1
  173. return nil, fmt.Errorf("%-v git merge-base --is-ancestor: %w", pr, err)
  174. }
  175. // If merge-base successfully exits then prHeadRef is an ancestor of pr.BaseBranch
  176. // Find the head commit id
  177. prHeadCommitID, err := git.GetFullCommitID(ctx, pr.BaseRepo.RepoPath(), prHeadRef)
  178. if err != nil {
  179. return nil, fmt.Errorf("GetFullCommitID(%s) in %s: %w", prHeadRef, pr.BaseRepo.FullName(), err)
  180. }
  181. // Get the commit from BaseBranch where the pull request got merged
  182. mergeCommit, _, err := git.NewCommand(ctx, "rev-list", "--ancestry-path", "--merges", "--reverse").
  183. AddDynamicArguments(prHeadCommitID + ".." + pr.BaseBranch).
  184. RunStdString(&git.RunOpts{Dir: pr.BaseRepo.RepoPath()})
  185. if err != nil {
  186. return nil, fmt.Errorf("git rev-list --ancestry-path --merges --reverse: %w", err)
  187. } else if len(mergeCommit) < git.SHAFullLength {
  188. // PR was maybe fast-forwarded, so just use last commit of PR
  189. mergeCommit = prHeadCommitID
  190. }
  191. mergeCommit = strings.TrimSpace(mergeCommit)
  192. gitRepo, err := git.OpenRepository(ctx, pr.BaseRepo.RepoPath())
  193. if err != nil {
  194. return nil, fmt.Errorf("%-v OpenRepository: %w", pr.BaseRepo, err)
  195. }
  196. defer gitRepo.Close()
  197. commit, err := gitRepo.GetCommit(mergeCommit)
  198. if err != nil {
  199. return nil, fmt.Errorf("GetMergeCommit[%s]: %w", mergeCommit, err)
  200. }
  201. return commit, nil
  202. }
  203. // manuallyMerged checks if a pull request got manually merged
  204. // When a pull request got manually merged mark the pull request as merged
  205. func manuallyMerged(ctx context.Context, pr *issues_model.PullRequest) bool {
  206. if err := pr.LoadBaseRepo(ctx); err != nil {
  207. log.Error("%-v LoadBaseRepo: %v", pr, err)
  208. return false
  209. }
  210. if unit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests); err == nil {
  211. config := unit.PullRequestsConfig()
  212. if !config.AutodetectManualMerge {
  213. return false
  214. }
  215. } else {
  216. log.Error("%-v BaseRepo.GetUnit(unit.TypePullRequests): %v", pr, err)
  217. return false
  218. }
  219. commit, err := getMergeCommit(ctx, pr)
  220. if err != nil {
  221. log.Error("%-v getMergeCommit: %v", pr, err)
  222. return false
  223. }
  224. if commit == nil {
  225. // no merge commit found
  226. return false
  227. }
  228. pr.MergedCommitID = commit.ID.String()
  229. pr.MergedUnix = timeutil.TimeStamp(commit.Author.When.Unix())
  230. pr.Status = issues_model.PullRequestStatusManuallyMerged
  231. merger, _ := user_model.GetUserByEmail(ctx, commit.Author.Email)
  232. // When the commit author is unknown set the BaseRepo owner as merger
  233. if merger == nil {
  234. if pr.BaseRepo.Owner == nil {
  235. if err = pr.BaseRepo.LoadOwner(ctx); err != nil {
  236. log.Error("%-v BaseRepo.LoadOwner: %v", pr, err)
  237. return false
  238. }
  239. }
  240. merger = pr.BaseRepo.Owner
  241. }
  242. pr.Merger = merger
  243. pr.MergerID = merger.ID
  244. if merged, err := pr.SetMerged(ctx); err != nil {
  245. log.Error("%-v setMerged : %v", pr, err)
  246. return false
  247. } else if !merged {
  248. return false
  249. }
  250. notification.NotifyMergePullRequest(ctx, merger, pr)
  251. log.Info("manuallyMerged[%-v]: Marked as manually merged into %s/%s by commit id: %s", pr, pr.BaseRepo.Name, pr.BaseBranch, commit.ID.String())
  252. return true
  253. }
  254. // InitializePullRequests checks and tests untested patches of pull requests.
  255. func InitializePullRequests(ctx context.Context) {
  256. prs, err := issues_model.GetPullRequestIDsByCheckStatus(issues_model.PullRequestStatusChecking)
  257. if err != nil {
  258. log.Error("Find Checking PRs: %v", err)
  259. return
  260. }
  261. for _, prID := range prs {
  262. select {
  263. case <-ctx.Done():
  264. return
  265. default:
  266. log.Trace("Adding PR[%d] to the pull requests patch checking queue", prID)
  267. if err := prPatchCheckerQueue.Push(strconv.FormatInt(prID, 10)); err != nil {
  268. log.Error("Error adding PR[%d] to the pull requests patch checking queue %v", prID, err)
  269. }
  270. }
  271. }
  272. }
  273. // handle passed PR IDs and test the PRs
  274. func handler(items ...string) []string {
  275. for _, s := range items {
  276. id, _ := strconv.ParseInt(s, 10, 64)
  277. testPR(id)
  278. }
  279. return nil
  280. }
  281. func testPR(id int64) {
  282. pullWorkingPool.CheckIn(fmt.Sprint(id))
  283. defer pullWorkingPool.CheckOut(fmt.Sprint(id))
  284. ctx, _, finished := process.GetManager().AddContext(graceful.GetManager().HammerContext(), fmt.Sprintf("Test PR[%d] from patch checking queue", id))
  285. defer finished()
  286. pr, err := issues_model.GetPullRequestByID(ctx, id)
  287. if err != nil {
  288. log.Error("Unable to GetPullRequestByID[%d] for testPR: %v", id, err)
  289. return
  290. }
  291. log.Trace("Testing %-v", pr)
  292. defer func() {
  293. log.Trace("Done testing %-v (status: %s)", pr, pr.Status)
  294. }()
  295. if pr.HasMerged {
  296. log.Trace("%-v is already merged (status: %s, merge commit: %s)", pr, pr.Status, pr.MergedCommitID)
  297. return
  298. }
  299. if manuallyMerged(ctx, pr) {
  300. log.Trace("%-v is manually merged (status: %s, merge commit: %s)", pr, pr.Status, pr.MergedCommitID)
  301. return
  302. }
  303. if err := TestPatch(pr); err != nil {
  304. log.Error("testPatch[%-v]: %v", pr, err)
  305. pr.Status = issues_model.PullRequestStatusError
  306. if err := pr.UpdateCols("status"); err != nil {
  307. log.Error("update pr [%-v] status to PullRequestStatusError failed: %v", pr, err)
  308. }
  309. return
  310. }
  311. checkAndUpdateStatus(ctx, pr)
  312. }
  313. // CheckPRsForBaseBranch check all pulls with baseBrannch
  314. func CheckPRsForBaseBranch(baseRepo *repo_model.Repository, baseBranchName string) error {
  315. prs, err := issues_model.GetUnmergedPullRequestsByBaseInfo(baseRepo.ID, baseBranchName)
  316. if err != nil {
  317. return err
  318. }
  319. for _, pr := range prs {
  320. AddToTaskQueue(pr)
  321. }
  322. return nil
  323. }
  324. // Init runs the task queue to test all the checking status pull requests
  325. func Init() error {
  326. prPatchCheckerQueue = queue.CreateUniqueQueue(graceful.GetManager().ShutdownContext(), "pr_patch_checker", handler)
  327. if prPatchCheckerQueue == nil {
  328. return fmt.Errorf("unable to create pr_patch_checker queue")
  329. }
  330. go graceful.GetManager().RunWithCancel(prPatchCheckerQueue)
  331. go graceful.GetManager().RunWithShutdownContext(InitializePullRequests)
  332. return nil
  333. }