You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

merge.go 18KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534
  1. // Copyright 2019 The Gitea Authors.
  2. // All rights reserved.
  3. // SPDX-License-Identifier: MIT
  4. package pull
  5. import (
  6. "context"
  7. "fmt"
  8. "os"
  9. "path/filepath"
  10. "regexp"
  11. "strconv"
  12. "strings"
  13. "code.gitea.io/gitea/models"
  14. "code.gitea.io/gitea/models/db"
  15. git_model "code.gitea.io/gitea/models/git"
  16. issues_model "code.gitea.io/gitea/models/issues"
  17. access_model "code.gitea.io/gitea/models/perm/access"
  18. pull_model "code.gitea.io/gitea/models/pull"
  19. repo_model "code.gitea.io/gitea/models/repo"
  20. "code.gitea.io/gitea/models/unit"
  21. user_model "code.gitea.io/gitea/models/user"
  22. "code.gitea.io/gitea/modules/cache"
  23. "code.gitea.io/gitea/modules/git"
  24. "code.gitea.io/gitea/modules/graceful"
  25. "code.gitea.io/gitea/modules/log"
  26. "code.gitea.io/gitea/modules/notification"
  27. "code.gitea.io/gitea/modules/references"
  28. repo_module "code.gitea.io/gitea/modules/repository"
  29. "code.gitea.io/gitea/modules/setting"
  30. "code.gitea.io/gitea/modules/timeutil"
  31. issue_service "code.gitea.io/gitea/services/issue"
  32. )
  33. // getMergeMessage composes the message used when merging a pull request.
  34. func getMergeMessage(ctx context.Context, baseGitRepo *git.Repository, pr *issues_model.PullRequest, mergeStyle repo_model.MergeStyle, extraVars map[string]string) (message, body string, err error) {
  35. if err := pr.LoadBaseRepo(ctx); err != nil {
  36. return "", "", err
  37. }
  38. if err := pr.LoadHeadRepo(ctx); err != nil {
  39. return "", "", err
  40. }
  41. if err := pr.LoadIssue(ctx); err != nil {
  42. return "", "", err
  43. }
  44. if err := pr.Issue.LoadPoster(ctx); err != nil {
  45. return "", "", err
  46. }
  47. isExternalTracker := pr.BaseRepo.UnitEnabled(ctx, unit.TypeExternalTracker)
  48. issueReference := "#"
  49. if isExternalTracker {
  50. issueReference = "!"
  51. }
  52. if mergeStyle != "" {
  53. templateFilepath := fmt.Sprintf(".gitea/default_merge_message/%s_TEMPLATE.md", strings.ToUpper(string(mergeStyle)))
  54. commit, err := baseGitRepo.GetBranchCommit(pr.BaseRepo.DefaultBranch)
  55. if err != nil {
  56. return "", "", err
  57. }
  58. templateContent, err := commit.GetFileContent(templateFilepath, setting.Repository.PullRequest.DefaultMergeMessageSize)
  59. if err != nil {
  60. if !git.IsErrNotExist(err) {
  61. return "", "", err
  62. }
  63. } else {
  64. vars := map[string]string{
  65. "BaseRepoOwnerName": pr.BaseRepo.OwnerName,
  66. "BaseRepoName": pr.BaseRepo.Name,
  67. "BaseBranch": pr.BaseBranch,
  68. "HeadRepoOwnerName": "",
  69. "HeadRepoName": "",
  70. "HeadBranch": pr.HeadBranch,
  71. "PullRequestTitle": pr.Issue.Title,
  72. "PullRequestDescription": pr.Issue.Content,
  73. "PullRequestPosterName": pr.Issue.Poster.Name,
  74. "PullRequestIndex": strconv.FormatInt(pr.Index, 10),
  75. "PullRequestReference": fmt.Sprintf("%s%d", issueReference, pr.Index),
  76. }
  77. if pr.HeadRepo != nil {
  78. vars["HeadRepoOwnerName"] = pr.HeadRepo.OwnerName
  79. vars["HeadRepoName"] = pr.HeadRepo.Name
  80. }
  81. for extraKey, extraValue := range extraVars {
  82. vars[extraKey] = extraValue
  83. }
  84. refs, err := pr.ResolveCrossReferences(ctx)
  85. if err == nil {
  86. closeIssueIndexes := make([]string, 0, len(refs))
  87. closeWord := "close"
  88. if len(setting.Repository.PullRequest.CloseKeywords) > 0 {
  89. closeWord = setting.Repository.PullRequest.CloseKeywords[0]
  90. }
  91. for _, ref := range refs {
  92. if ref.RefAction == references.XRefActionCloses {
  93. if err := ref.LoadIssue(ctx); err != nil {
  94. return "", "", err
  95. }
  96. closeIssueIndexes = append(closeIssueIndexes, fmt.Sprintf("%s %s%d", closeWord, issueReference, ref.Issue.Index))
  97. }
  98. }
  99. if len(closeIssueIndexes) > 0 {
  100. vars["ClosingIssues"] = strings.Join(closeIssueIndexes, ", ")
  101. } else {
  102. vars["ClosingIssues"] = ""
  103. }
  104. }
  105. message, body = expandDefaultMergeMessage(templateContent, vars)
  106. return message, body, nil
  107. }
  108. }
  109. if mergeStyle == repo_model.MergeStyleRebase {
  110. // for fast-forward rebase, do not amend the last commit if there is no template
  111. return "", "", nil
  112. }
  113. // Squash merge has a different from other styles.
  114. if mergeStyle == repo_model.MergeStyleSquash {
  115. return fmt.Sprintf("%s (%s%d)", pr.Issue.Title, issueReference, pr.Issue.Index), "", nil
  116. }
  117. if pr.BaseRepoID == pr.HeadRepoID {
  118. return fmt.Sprintf("Merge pull request '%s' (%s%d) from %s into %s", pr.Issue.Title, issueReference, pr.Issue.Index, pr.HeadBranch, pr.BaseBranch), "", nil
  119. }
  120. if pr.HeadRepo == nil {
  121. return fmt.Sprintf("Merge pull request '%s' (%s%d) from <deleted>:%s into %s", pr.Issue.Title, issueReference, pr.Issue.Index, pr.HeadBranch, pr.BaseBranch), "", nil
  122. }
  123. return fmt.Sprintf("Merge pull request '%s' (%s%d) from %s:%s into %s", pr.Issue.Title, issueReference, pr.Issue.Index, pr.HeadRepo.FullName(), pr.HeadBranch, pr.BaseBranch), "", nil
  124. }
  125. func expandDefaultMergeMessage(template string, vars map[string]string) (message, body string) {
  126. message = strings.TrimSpace(template)
  127. if splits := strings.SplitN(message, "\n", 2); len(splits) == 2 {
  128. message = splits[0]
  129. body = strings.TrimSpace(splits[1])
  130. }
  131. mapping := func(s string) string { return vars[s] }
  132. return os.Expand(message, mapping), os.Expand(body, mapping)
  133. }
  134. // GetDefaultMergeMessage returns default message used when merging pull request
  135. func GetDefaultMergeMessage(ctx context.Context, baseGitRepo *git.Repository, pr *issues_model.PullRequest, mergeStyle repo_model.MergeStyle) (message, body string, err error) {
  136. return getMergeMessage(ctx, baseGitRepo, pr, mergeStyle, nil)
  137. }
  138. // Merge merges pull request to base repository.
  139. // Caller should check PR is ready to be merged (review and status checks)
  140. func Merge(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User, baseGitRepo *git.Repository, mergeStyle repo_model.MergeStyle, expectedHeadCommitID, message string, wasAutoMerged bool) error {
  141. if err := pr.LoadBaseRepo(ctx); err != nil {
  142. log.Error("Unable to load base repo: %v", err)
  143. return fmt.Errorf("unable to load base repo: %w", err)
  144. } else if err := pr.LoadHeadRepo(ctx); err != nil {
  145. log.Error("Unable to load head repo: %v", err)
  146. return fmt.Errorf("unable to load head repo: %w", err)
  147. }
  148. pullWorkingPool.CheckIn(fmt.Sprint(pr.ID))
  149. defer pullWorkingPool.CheckOut(fmt.Sprint(pr.ID))
  150. // Removing an auto merge pull and ignore if not exist
  151. // FIXME: is this the correct point to do this? Shouldn't this be after IsMergeStyleAllowed?
  152. if err := pull_model.DeleteScheduledAutoMerge(ctx, pr.ID); err != nil && !db.IsErrNotExist(err) {
  153. return err
  154. }
  155. prUnit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests)
  156. if err != nil {
  157. log.Error("pr.BaseRepo.GetUnit(unit.TypePullRequests): %v", err)
  158. return err
  159. }
  160. prConfig := prUnit.PullRequestsConfig()
  161. // Check if merge style is correct and allowed
  162. if !prConfig.IsMergeStyleAllowed(mergeStyle) {
  163. return models.ErrInvalidMergeStyle{ID: pr.BaseRepo.ID, Style: mergeStyle}
  164. }
  165. defer func() {
  166. go AddTestPullRequestTask(doer, pr.BaseRepo.ID, pr.BaseBranch, false, "", "")
  167. }()
  168. // Run the merge in the hammer context to prevent cancellation
  169. hammerCtx := graceful.GetManager().HammerContext()
  170. pr.MergedCommitID, err = doMergeAndPush(hammerCtx, pr, doer, mergeStyle, expectedHeadCommitID, message)
  171. if err != nil {
  172. return err
  173. }
  174. pr.MergedUnix = timeutil.TimeStampNow()
  175. pr.Merger = doer
  176. pr.MergerID = doer.ID
  177. if _, err := pr.SetMerged(hammerCtx); err != nil {
  178. log.Error("SetMerged %-v: %v", pr, err)
  179. }
  180. if err := pr.LoadIssue(hammerCtx); err != nil {
  181. log.Error("LoadIssue %-v: %v", pr, err)
  182. }
  183. if err := pr.Issue.LoadRepo(hammerCtx); err != nil {
  184. log.Error("pr.Issue.LoadRepo %-v: %v", pr, err)
  185. }
  186. if err := pr.Issue.Repo.LoadOwner(hammerCtx); err != nil {
  187. log.Error("LoadOwner for %-v: %v", pr, err)
  188. }
  189. if wasAutoMerged {
  190. notification.NotifyAutoMergePullRequest(hammerCtx, doer, pr)
  191. } else {
  192. notification.NotifyMergePullRequest(hammerCtx, doer, pr)
  193. }
  194. // Reset cached commit count
  195. cache.Remove(pr.Issue.Repo.GetCommitsCountCacheKey(pr.BaseBranch, true))
  196. // Resolve cross references
  197. refs, err := pr.ResolveCrossReferences(hammerCtx)
  198. if err != nil {
  199. log.Error("ResolveCrossReferences: %v", err)
  200. return nil
  201. }
  202. for _, ref := range refs {
  203. if err = ref.LoadIssue(hammerCtx); err != nil {
  204. return err
  205. }
  206. if err = ref.Issue.LoadRepo(hammerCtx); err != nil {
  207. return err
  208. }
  209. close := ref.RefAction == references.XRefActionCloses
  210. if close != ref.Issue.IsClosed {
  211. if err = issue_service.ChangeStatus(ref.Issue, doer, pr.MergedCommitID, close); err != nil {
  212. // Allow ErrDependenciesLeft
  213. if !issues_model.IsErrDependenciesLeft(err) {
  214. return err
  215. }
  216. }
  217. }
  218. }
  219. return nil
  220. }
  221. // doMergeAndPush performs the merge operation without changing any pull information in database and pushes it up to the base repository
  222. func doMergeAndPush(ctx context.Context, pr *issues_model.PullRequest, doer *user_model.User, mergeStyle repo_model.MergeStyle, expectedHeadCommitID, message string) (string, error) {
  223. // Clone base repo.
  224. mergeCtx, cancel, err := createTemporaryRepoForMerge(ctx, pr, doer, expectedHeadCommitID)
  225. if err != nil {
  226. return "", err
  227. }
  228. defer cancel()
  229. // Merge commits.
  230. switch mergeStyle {
  231. case repo_model.MergeStyleMerge:
  232. if err := doMergeStyleMerge(mergeCtx, message); err != nil {
  233. return "", err
  234. }
  235. case repo_model.MergeStyleRebase, repo_model.MergeStyleRebaseMerge:
  236. if err := doMergeStyleRebase(mergeCtx, mergeStyle, message); err != nil {
  237. return "", err
  238. }
  239. case repo_model.MergeStyleSquash:
  240. if err := doMergeStyleSquash(mergeCtx, message); err != nil {
  241. return "", err
  242. }
  243. default:
  244. return "", models.ErrInvalidMergeStyle{ID: pr.BaseRepo.ID, Style: mergeStyle}
  245. }
  246. // OK we should cache our current head and origin/headbranch
  247. mergeHeadSHA, err := git.GetFullCommitID(ctx, mergeCtx.tmpBasePath, "HEAD")
  248. if err != nil {
  249. return "", fmt.Errorf("Failed to get full commit id for HEAD: %w", err)
  250. }
  251. mergeBaseSHA, err := git.GetFullCommitID(ctx, mergeCtx.tmpBasePath, "original_"+baseBranch)
  252. if err != nil {
  253. return "", fmt.Errorf("Failed to get full commit id for origin/%s: %w", pr.BaseBranch, err)
  254. }
  255. mergeCommitID, err := git.GetFullCommitID(ctx, mergeCtx.tmpBasePath, baseBranch)
  256. if err != nil {
  257. return "", fmt.Errorf("Failed to get full commit id for the new merge: %w", err)
  258. }
  259. // Now it's questionable about where this should go - either after or before the push
  260. // I think in the interests of data safety - failures to push to the lfs should prevent
  261. // the merge as you can always remerge.
  262. if setting.LFS.StartServer {
  263. if err := LFSPush(ctx, mergeCtx.tmpBasePath, mergeHeadSHA, mergeBaseSHA, pr); err != nil {
  264. return "", err
  265. }
  266. }
  267. var headUser *user_model.User
  268. err = pr.HeadRepo.LoadOwner(ctx)
  269. if err != nil {
  270. if !user_model.IsErrUserNotExist(err) {
  271. log.Error("Can't find user: %d for head repository in %-v: %v", pr.HeadRepo.OwnerID, pr, err)
  272. return "", err
  273. }
  274. log.Warn("Can't find user: %d for head repository in %-v - defaulting to doer: %s - %v", pr.HeadRepo.OwnerID, pr, doer.Name, err)
  275. headUser = doer
  276. } else {
  277. headUser = pr.HeadRepo.Owner
  278. }
  279. mergeCtx.env = repo_module.FullPushingEnvironment(
  280. headUser,
  281. doer,
  282. pr.BaseRepo,
  283. pr.BaseRepo.Name,
  284. pr.ID,
  285. )
  286. pushCmd := git.NewCommand(ctx, "push", "origin").AddDynamicArguments(baseBranch + ":" + git.BranchPrefix + pr.BaseBranch)
  287. // Push back to upstream.
  288. // TODO: this cause an api call to "/api/internal/hook/post-receive/...",
  289. // that prevents us from doint the whole merge in one db transaction
  290. if err := pushCmd.Run(mergeCtx.RunOpts()); err != nil {
  291. if strings.Contains(mergeCtx.errbuf.String(), "non-fast-forward") {
  292. return "", &git.ErrPushOutOfDate{
  293. StdOut: mergeCtx.outbuf.String(),
  294. StdErr: mergeCtx.errbuf.String(),
  295. Err: err,
  296. }
  297. } else if strings.Contains(mergeCtx.errbuf.String(), "! [remote rejected]") {
  298. err := &git.ErrPushRejected{
  299. StdOut: mergeCtx.outbuf.String(),
  300. StdErr: mergeCtx.errbuf.String(),
  301. Err: err,
  302. }
  303. err.GenerateMessage()
  304. return "", err
  305. }
  306. return "", fmt.Errorf("git push: %s", mergeCtx.errbuf.String())
  307. }
  308. mergeCtx.outbuf.Reset()
  309. mergeCtx.errbuf.Reset()
  310. return mergeCommitID, nil
  311. }
  312. func commitAndSignNoAuthor(ctx *mergeContext, message string) error {
  313. cmdCommit := git.NewCommand(ctx, "commit").AddOptionFormat("--message=%s", message)
  314. if ctx.signKeyID == "" {
  315. cmdCommit.AddArguments("--no-gpg-sign")
  316. } else {
  317. cmdCommit.AddOptionFormat("-S%s", ctx.signKeyID)
  318. }
  319. if err := cmdCommit.Run(ctx.RunOpts()); err != nil {
  320. log.Error("git commit %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  321. return fmt.Errorf("git commit %v: %w\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  322. }
  323. return nil
  324. }
  325. func runMergeCommand(ctx *mergeContext, mergeStyle repo_model.MergeStyle, cmd *git.Command) error {
  326. if err := cmd.Run(ctx.RunOpts()); err != nil {
  327. // Merge will leave a MERGE_HEAD file in the .git folder if there is a conflict
  328. if _, statErr := os.Stat(filepath.Join(ctx.tmpBasePath, ".git", "MERGE_HEAD")); statErr == nil {
  329. // We have a merge conflict error
  330. log.Debug("MergeConflict %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  331. return models.ErrMergeConflicts{
  332. Style: mergeStyle,
  333. StdOut: ctx.outbuf.String(),
  334. StdErr: ctx.errbuf.String(),
  335. Err: err,
  336. }
  337. } else if strings.Contains(ctx.errbuf.String(), "refusing to merge unrelated histories") {
  338. log.Debug("MergeUnrelatedHistories %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  339. return models.ErrMergeUnrelatedHistories{
  340. Style: mergeStyle,
  341. StdOut: ctx.outbuf.String(),
  342. StdErr: ctx.errbuf.String(),
  343. Err: err,
  344. }
  345. }
  346. log.Error("git merge %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  347. return fmt.Errorf("git merge %v: %w\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  348. }
  349. ctx.outbuf.Reset()
  350. ctx.errbuf.Reset()
  351. return nil
  352. }
  353. var escapedSymbols = regexp.MustCompile(`([*[?! \\])`)
  354. // IsUserAllowedToMerge check if user is allowed to merge PR with given permissions and branch protections
  355. func IsUserAllowedToMerge(ctx context.Context, pr *issues_model.PullRequest, p access_model.Permission, user *user_model.User) (bool, error) {
  356. if user == nil {
  357. return false, nil
  358. }
  359. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  360. if err != nil {
  361. return false, err
  362. }
  363. if (p.CanWrite(unit.TypeCode) && pb == nil) || (pb != nil && git_model.IsUserMergeWhitelisted(ctx, pb, user.ID, p)) {
  364. return true, nil
  365. }
  366. return false, nil
  367. }
  368. // CheckPullBranchProtections checks whether the PR is ready to be merged (reviews and status checks)
  369. func CheckPullBranchProtections(ctx context.Context, pr *issues_model.PullRequest, skipProtectedFilesCheck bool) (err error) {
  370. if err = pr.LoadBaseRepo(ctx); err != nil {
  371. return fmt.Errorf("LoadBaseRepo: %w", err)
  372. }
  373. pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)
  374. if err != nil {
  375. return fmt.Errorf("LoadProtectedBranch: %v", err)
  376. }
  377. if pb == nil {
  378. return nil
  379. }
  380. isPass, err := IsPullCommitStatusPass(ctx, pr)
  381. if err != nil {
  382. return err
  383. }
  384. if !isPass {
  385. return models.ErrDisallowedToMerge{
  386. Reason: "Not all required status checks successful",
  387. }
  388. }
  389. if !issues_model.HasEnoughApprovals(ctx, pb, pr) {
  390. return models.ErrDisallowedToMerge{
  391. Reason: "Does not have enough approvals",
  392. }
  393. }
  394. if issues_model.MergeBlockedByRejectedReview(ctx, pb, pr) {
  395. return models.ErrDisallowedToMerge{
  396. Reason: "There are requested changes",
  397. }
  398. }
  399. if issues_model.MergeBlockedByOfficialReviewRequests(ctx, pb, pr) {
  400. return models.ErrDisallowedToMerge{
  401. Reason: "There are official review requests",
  402. }
  403. }
  404. if issues_model.MergeBlockedByOutdatedBranch(pb, pr) {
  405. return models.ErrDisallowedToMerge{
  406. Reason: "The head branch is behind the base branch",
  407. }
  408. }
  409. if skipProtectedFilesCheck {
  410. return nil
  411. }
  412. if pb.MergeBlockedByProtectedFiles(pr.ChangedProtectedFiles) {
  413. return models.ErrDisallowedToMerge{
  414. Reason: "Changed protected files",
  415. }
  416. }
  417. return nil
  418. }
  419. // MergedManually mark pr as merged manually
  420. func MergedManually(pr *issues_model.PullRequest, doer *user_model.User, baseGitRepo *git.Repository, commitID string) error {
  421. pullWorkingPool.CheckIn(fmt.Sprint(pr.ID))
  422. defer pullWorkingPool.CheckOut(fmt.Sprint(pr.ID))
  423. if err := db.WithTx(db.DefaultContext, func(ctx context.Context) error {
  424. if err := pr.LoadBaseRepo(ctx); err != nil {
  425. return err
  426. }
  427. prUnit, err := pr.BaseRepo.GetUnit(ctx, unit.TypePullRequests)
  428. if err != nil {
  429. return err
  430. }
  431. prConfig := prUnit.PullRequestsConfig()
  432. // Check if merge style is correct and allowed
  433. if !prConfig.IsMergeStyleAllowed(repo_model.MergeStyleManuallyMerged) {
  434. return models.ErrInvalidMergeStyle{ID: pr.BaseRepo.ID, Style: repo_model.MergeStyleManuallyMerged}
  435. }
  436. if len(commitID) < git.SHAFullLength {
  437. return fmt.Errorf("Wrong commit ID")
  438. }
  439. commit, err := baseGitRepo.GetCommit(commitID)
  440. if err != nil {
  441. if git.IsErrNotExist(err) {
  442. return fmt.Errorf("Wrong commit ID")
  443. }
  444. return err
  445. }
  446. commitID = commit.ID.String()
  447. ok, err := baseGitRepo.IsCommitInBranch(commitID, pr.BaseBranch)
  448. if err != nil {
  449. return err
  450. }
  451. if !ok {
  452. return fmt.Errorf("Wrong commit ID")
  453. }
  454. pr.MergedCommitID = commitID
  455. pr.MergedUnix = timeutil.TimeStamp(commit.Author.When.Unix())
  456. pr.Status = issues_model.PullRequestStatusManuallyMerged
  457. pr.Merger = doer
  458. pr.MergerID = doer.ID
  459. var merged bool
  460. if merged, err = pr.SetMerged(ctx); err != nil {
  461. return err
  462. } else if !merged {
  463. return fmt.Errorf("SetMerged failed")
  464. }
  465. return nil
  466. }); err != nil {
  467. return err
  468. }
  469. notification.NotifyMergePullRequest(baseGitRepo.Ctx, doer, pr)
  470. log.Info("manuallyMerged[%d]: Marked as manually merged into %s/%s by commit id: %s", pr.ID, pr.BaseRepo.Name, pr.BaseBranch, commitID)
  471. return nil
  472. }