You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

merge_rebase.go 4.0KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120
  1. // Copyright 2023 The Gitea Authors. All rights reserved.
  2. // SPDX-License-Identifier: MIT
  3. package pull
  4. import (
  5. "fmt"
  6. "strings"
  7. repo_model "code.gitea.io/gitea/models/repo"
  8. "code.gitea.io/gitea/modules/git"
  9. "code.gitea.io/gitea/modules/log"
  10. )
  11. // getRebaseAmendMessage composes the message to amend commits in rebase merge of a pull request.
  12. func getRebaseAmendMessage(ctx *mergeContext, baseGitRepo *git.Repository) (message string, err error) {
  13. // Get existing commit message.
  14. commitMessage, _, err := git.NewCommand(ctx, "show", "--format=%B", "-s").RunStdString(&git.RunOpts{Dir: ctx.tmpBasePath})
  15. if err != nil {
  16. return "", err
  17. }
  18. commitTitle, commitBody, _ := strings.Cut(commitMessage, "\n")
  19. extraVars := map[string]string{"CommitTitle": strings.TrimSpace(commitTitle), "CommitBody": strings.TrimSpace(commitBody)}
  20. message, body, err := getMergeMessage(ctx, baseGitRepo, ctx.pr, repo_model.MergeStyleRebase, extraVars)
  21. if err != nil || message == "" {
  22. return "", err
  23. }
  24. if len(body) > 0 {
  25. message = message + "\n\n" + body
  26. }
  27. return message, err
  28. }
  29. // Perform rebase merge without merge commit.
  30. func doMergeRebaseFastForward(ctx *mergeContext) error {
  31. baseHeadSHA, err := git.GetFullCommitID(ctx, ctx.tmpBasePath, "HEAD")
  32. if err != nil {
  33. return fmt.Errorf("Failed to get full commit id for HEAD: %w", err)
  34. }
  35. cmd := git.NewCommand(ctx, "merge", "--ff-only").AddDynamicArguments(stagingBranch)
  36. if err := runMergeCommand(ctx, repo_model.MergeStyleRebase, cmd); err != nil {
  37. log.Error("Unable to merge staging into base: %v", err)
  38. return err
  39. }
  40. // Check if anything actually changed before we amend the message, fast forward can skip commits.
  41. newMergeHeadSHA, err := git.GetFullCommitID(ctx, ctx.tmpBasePath, "HEAD")
  42. if err != nil {
  43. return fmt.Errorf("Failed to get full commit id for HEAD: %w", err)
  44. }
  45. if baseHeadSHA == newMergeHeadSHA {
  46. return nil
  47. }
  48. // Original repo to read template from.
  49. baseGitRepo, err := git.OpenRepository(ctx, ctx.pr.BaseRepo.RepoPath())
  50. if err != nil {
  51. log.Error("Unable to get Git repo for rebase: %v", err)
  52. return err
  53. }
  54. defer baseGitRepo.Close()
  55. // Amend last commit message based on template, if one exists
  56. newMessage, err := getRebaseAmendMessage(ctx, baseGitRepo)
  57. if err != nil {
  58. log.Error("Unable to get commit message for amend: %v", err)
  59. return err
  60. }
  61. if newMessage != "" {
  62. if err := git.NewCommand(ctx, "commit", "--amend").AddOptionFormat("--message=%s", newMessage).Run(&git.RunOpts{Dir: ctx.tmpBasePath}); err != nil {
  63. log.Error("Unable to amend commit message: %v", err)
  64. return err
  65. }
  66. }
  67. return nil
  68. }
  69. // Perform rebase merge with merge commit.
  70. func doMergeRebaseMergeCommit(ctx *mergeContext, message string) error {
  71. cmd := git.NewCommand(ctx, "merge").AddArguments("--no-ff", "--no-commit").AddDynamicArguments(stagingBranch)
  72. if err := runMergeCommand(ctx, repo_model.MergeStyleRebaseMerge, cmd); err != nil {
  73. log.Error("Unable to merge staging into base: %v", err)
  74. return err
  75. }
  76. if err := commitAndSignNoAuthor(ctx, message); err != nil {
  77. log.Error("Unable to make final commit: %v", err)
  78. return err
  79. }
  80. return nil
  81. }
  82. // doMergeStyleRebase rebases the tracking branch on the base branch as the current HEAD with or with a merge commit to the original pr branch
  83. func doMergeStyleRebase(ctx *mergeContext, mergeStyle repo_model.MergeStyle, message string) error {
  84. if err := rebaseTrackingOnToBase(ctx, mergeStyle); err != nil {
  85. return err
  86. }
  87. // Checkout base branch again
  88. if err := git.NewCommand(ctx, "checkout").AddDynamicArguments(baseBranch).
  89. Run(ctx.RunOpts()); err != nil {
  90. log.Error("git checkout base prior to merge post staging rebase %-v: %v\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  91. return fmt.Errorf("git checkout base prior to merge post staging rebase %v: %w\n%s\n%s", ctx.pr, err, ctx.outbuf.String(), ctx.errbuf.String())
  92. }
  93. ctx.outbuf.Reset()
  94. ctx.errbuf.Reset()
  95. if mergeStyle == repo_model.MergeStyleRebase {
  96. return doMergeRebaseFastForward(ctx)
  97. }
  98. return doMergeRebaseMergeCommit(ctx, message)
  99. }