123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301 |
- // Copyright 2019 The Gitea Authors. All rights reserved.
- // SPDX-License-Identifier: MIT
-
- package issue
-
- import (
- "testing"
-
- activities_model "code.gitea.io/gitea/models/activities"
- "code.gitea.io/gitea/models/db"
- issues_model "code.gitea.io/gitea/models/issues"
- repo_model "code.gitea.io/gitea/models/repo"
- "code.gitea.io/gitea/models/unittest"
- user_model "code.gitea.io/gitea/models/user"
- "code.gitea.io/gitea/modules/repository"
- "code.gitea.io/gitea/modules/setting"
-
- "github.com/stretchr/testify/assert"
- )
-
- func TestUpdateIssuesCommit(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- pushCommits := []*repository.PushCommit{
- {
- Sha1: "abcdef1",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user4@example.com",
- AuthorName: "User Four",
- Message: "start working on #FST-1, #1",
- },
- {
- Sha1: "abcdef2",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user2@example.com",
- AuthorName: "User Two",
- Message: "a plain message",
- },
- {
- Sha1: "abcdef2",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user2@example.com",
- AuthorName: "User Two",
- Message: "close #2",
- },
- }
-
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
- repo.Owner = user
-
- commentBean := &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef1",
- PosterID: user.ID,
- IssueID: 1,
- }
- issueBean := &issues_model.Issue{RepoID: repo.ID, Index: 4}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, &issues_model.Issue{RepoID: repo.ID, Index: 2}, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, repo.DefaultBranch))
- unittest.AssertExistsAndLoadBean(t, commentBean)
- unittest.AssertExistsAndLoadBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
-
- // Test that push to a non-default branch closes no issue.
- pushCommits = []*repository.PushCommit{
- {
- Sha1: "abcdef1",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user4@example.com",
- AuthorName: "User Four",
- Message: "close #1",
- },
- }
- repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
- commentBean = &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef1",
- PosterID: user.ID,
- IssueID: 6,
- }
- issueBean = &issues_model.Issue{RepoID: repo.ID, Index: 1}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, &issues_model.Issue{RepoID: repo.ID, Index: 1}, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, "non-existing-branch"))
- unittest.AssertExistsAndLoadBean(t, commentBean)
- unittest.AssertNotExistsBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
-
- pushCommits = []*repository.PushCommit{
- {
- Sha1: "abcdef3",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user2@example.com",
- AuthorName: "User Two",
- Message: "close " + setting.AppURL + repo.FullName() + "/pulls/1",
- },
- }
- repo = unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 3})
- commentBean = &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef3",
- PosterID: user.ID,
- IssueID: 6,
- }
- issueBean = &issues_model.Issue{RepoID: repo.ID, Index: 1}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, &issues_model.Issue{RepoID: repo.ID, Index: 1}, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, repo.DefaultBranch))
- unittest.AssertExistsAndLoadBean(t, commentBean)
- unittest.AssertExistsAndLoadBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
- }
-
- func TestUpdateIssuesCommit_Colon(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- pushCommits := []*repository.PushCommit{
- {
- Sha1: "abcdef2",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user2@example.com",
- AuthorName: "User Two",
- Message: "close: #2",
- },
- }
-
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
- repo.Owner = user
-
- issueBean := &issues_model.Issue{RepoID: repo.ID, Index: 4}
-
- unittest.AssertNotExistsBean(t, &issues_model.Issue{RepoID: repo.ID, Index: 2}, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, repo.DefaultBranch))
- unittest.AssertExistsAndLoadBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
- }
-
- func TestUpdateIssuesCommit_Issue5957(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
- // Test that push to a non-default branch closes an issue.
- pushCommits := []*repository.PushCommit{
- {
- Sha1: "abcdef1",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user4@example.com",
- AuthorName: "User Four",
- Message: "close #2",
- },
- }
-
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
- commentBean := &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef1",
- PosterID: user.ID,
- IssueID: 7,
- }
-
- issueBean := &issues_model.Issue{RepoID: repo.ID, Index: 2, ID: 7}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, issueBean, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, "non-existing-branch"))
- unittest.AssertExistsAndLoadBean(t, commentBean)
- unittest.AssertExistsAndLoadBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
- }
-
- func TestUpdateIssuesCommit_AnotherRepo(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
- // Test that a push to default branch closes issue in another repo
- // If the user also has push permissions to that repo
- pushCommits := []*repository.PushCommit{
- {
- Sha1: "abcdef1",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user2@example.com",
- AuthorName: "User Two",
- Message: "close user2/repo1#1",
- },
- }
-
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
- commentBean := &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef1",
- PosterID: user.ID,
- IssueID: 1,
- }
-
- issueBean := &issues_model.Issue{RepoID: 1, Index: 1, ID: 1}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, issueBean, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, repo.DefaultBranch))
- unittest.AssertExistsAndLoadBean(t, commentBean)
- unittest.AssertExistsAndLoadBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
- }
-
- func TestUpdateIssuesCommit_AnotherRepo_FullAddress(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-
- // Test that a push to default branch closes issue in another repo
- // If the user also has push permissions to that repo
- pushCommits := []*repository.PushCommit{
- {
- Sha1: "abcdef1",
- CommitterEmail: "user2@example.com",
- CommitterName: "User Two",
- AuthorEmail: "user2@example.com",
- AuthorName: "User Two",
- Message: "close " + setting.AppURL + "user2/repo1/issues/1",
- },
- }
-
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
- commentBean := &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef1",
- PosterID: user.ID,
- IssueID: 1,
- }
-
- issueBean := &issues_model.Issue{RepoID: 1, Index: 1, ID: 1}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, issueBean, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, repo.DefaultBranch))
- unittest.AssertExistsAndLoadBean(t, commentBean)
- unittest.AssertExistsAndLoadBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
- }
-
- func TestUpdateIssuesCommit_AnotherRepoNoPermission(t *testing.T) {
- assert.NoError(t, unittest.PrepareTestDatabase())
- user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 10})
-
- // Test that a push with close reference *can not* close issue
- // If the committer doesn't have push rights in that repo
- pushCommits := []*repository.PushCommit{
- {
- Sha1: "abcdef3",
- CommitterEmail: "user10@example.com",
- CommitterName: "User Ten",
- AuthorEmail: "user10@example.com",
- AuthorName: "User Ten",
- Message: "close org3/repo3#1",
- },
- {
- Sha1: "abcdef4",
- CommitterEmail: "user10@example.com",
- CommitterName: "User Ten",
- AuthorEmail: "user10@example.com",
- AuthorName: "User Ten",
- Message: "close " + setting.AppURL + "org3/repo3/issues/1",
- },
- }
-
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 6})
- commentBean := &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef3",
- PosterID: user.ID,
- IssueID: 6,
- }
- commentBean2 := &issues_model.Comment{
- Type: issues_model.CommentTypeCommitRef,
- CommitSHA: "abcdef4",
- PosterID: user.ID,
- IssueID: 6,
- }
-
- issueBean := &issues_model.Issue{RepoID: 3, Index: 1, ID: 6}
-
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, commentBean2)
- unittest.AssertNotExistsBean(t, issueBean, "is_closed=1")
- assert.NoError(t, UpdateIssuesCommit(db.DefaultContext, user, repo, pushCommits, repo.DefaultBranch))
- unittest.AssertNotExistsBean(t, commentBean)
- unittest.AssertNotExistsBean(t, commentBean2)
- unittest.AssertNotExistsBean(t, issueBean, "is_closed=1")
- unittest.CheckConsistencyFor(t, &activities_model.Action{})
- }
|