123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433 |
- // Copyright 2020 The Gitea Authors. All rights reserved.
- // SPDX-License-Identifier: MIT
-
- package integration
-
- import (
- "fmt"
- "net/http"
- "testing"
-
- auth_model "code.gitea.io/gitea/models/auth"
- "code.gitea.io/gitea/models/db"
- issues_model "code.gitea.io/gitea/models/issues"
- repo_model "code.gitea.io/gitea/models/repo"
- "code.gitea.io/gitea/models/unittest"
- user_model "code.gitea.io/gitea/models/user"
- "code.gitea.io/gitea/modules/json"
- api "code.gitea.io/gitea/modules/structs"
- issue_service "code.gitea.io/gitea/services/issue"
- "code.gitea.io/gitea/tests"
-
- "github.com/stretchr/testify/assert"
- "xorm.io/builder"
- )
-
- func TestAPIPullReview(t *testing.T) {
- defer tests.PrepareTestEnv(t)()
- pullIssue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 3})
- assert.NoError(t, pullIssue.LoadAttributes(db.DefaultContext))
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pullIssue.RepoID})
-
- // test ListPullReviews
- session := loginUser(t, "user2")
- token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
- req := NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token)
- resp := MakeRequest(t, req, http.StatusOK)
-
- var reviews []*api.PullReview
- DecodeJSON(t, resp, &reviews)
- if !assert.Len(t, reviews, 6) {
- return
- }
- for _, r := range reviews {
- assert.EqualValues(t, pullIssue.HTMLURL(), r.HTMLPullURL)
- }
- assert.EqualValues(t, 8, reviews[3].ID)
- assert.EqualValues(t, "APPROVED", reviews[3].State)
- assert.EqualValues(t, 0, reviews[3].CodeCommentsCount)
- assert.True(t, reviews[3].Stale)
- assert.False(t, reviews[3].Official)
-
- assert.EqualValues(t, 10, reviews[5].ID)
- assert.EqualValues(t, "REQUEST_CHANGES", reviews[5].State)
- assert.EqualValues(t, 1, reviews[5].CodeCommentsCount)
- assert.EqualValues(t, -1, reviews[5].Reviewer.ID) // ghost user
- assert.False(t, reviews[5].Stale)
- assert.True(t, reviews[5].Official)
-
- // test GetPullReview
- req = NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/reviews/%d?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, reviews[3].ID, token)
- resp = MakeRequest(t, req, http.StatusOK)
- var review api.PullReview
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, *reviews[3], review)
-
- req = NewRequestf(t, "GET", "/api/v1/repos/%s/%s/pulls/%d/reviews/%d?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, reviews[5].ID, token)
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, *reviews[5], review)
-
- // test GetPullReviewComments
- comment := unittest.AssertExistsAndLoadBean(t, &issues_model.Comment{ID: 7})
- req = NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/reviews/%d/comments?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, 10, token)
- resp = MakeRequest(t, req, http.StatusOK)
- var reviewComments []*api.PullReviewComment
- DecodeJSON(t, resp, &reviewComments)
- assert.Len(t, reviewComments, 1)
- assert.EqualValues(t, "Ghost", reviewComments[0].Poster.UserName)
- assert.EqualValues(t, "a review from a deleted user", reviewComments[0].Body)
- assert.EqualValues(t, comment.ID, reviewComments[0].ID)
- assert.EqualValues(t, comment.UpdatedUnix, reviewComments[0].Updated.Unix())
- assert.EqualValues(t, comment.HTMLURL(db.DefaultContext), reviewComments[0].HTMLURL)
-
- // test CreatePullReview
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.CreatePullReviewOptions{
- Body: "body1",
- // Event: "" # will result in PENDING
- Comments: []api.CreatePullReviewComment{
- {
- Path: "README.md",
- Body: "first new line",
- OldLineNum: 0,
- NewLineNum: 1,
- }, {
- Path: "README.md",
- Body: "first old line",
- OldLineNum: 1,
- NewLineNum: 0,
- }, {
- Path: "iso-8859-1.txt",
- Body: "this line contains a non-utf-8 character",
- OldLineNum: 0,
- NewLineNum: 1,
- },
- },
- })
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, 6, review.ID)
- assert.EqualValues(t, "PENDING", review.State)
- assert.EqualValues(t, 3, review.CodeCommentsCount)
-
- // test SubmitPullReview
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews/%d?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, review.ID, token), &api.SubmitPullReviewOptions{
- Event: "APPROVED",
- Body: "just two nits",
- })
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, 6, review.ID)
- assert.EqualValues(t, "APPROVED", review.State)
- assert.EqualValues(t, 3, review.CodeCommentsCount)
-
- // test dismiss review
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews/%d/dismissals?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, review.ID, token), &api.DismissPullReviewOptions{
- Message: "test",
- })
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, 6, review.ID)
- assert.True(t, review.Dismissed)
-
- // test dismiss review
- req = NewRequest(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews/%d/undismissals?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, review.ID, token))
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, 6, review.ID)
- assert.False(t, review.Dismissed)
-
- // test DeletePullReview
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.CreatePullReviewOptions{
- Body: "just a comment",
- Event: "COMMENT",
- })
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &review)
- assert.EqualValues(t, "COMMENT", review.State)
- assert.EqualValues(t, 0, review.CodeCommentsCount)
- req = NewRequestf(t, http.MethodDelete, "/api/v1/repos/%s/%s/pulls/%d/reviews/%d?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, review.ID, token)
- MakeRequest(t, req, http.StatusNoContent)
-
- // test CreatePullReview Comment without body but with comments
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.CreatePullReviewOptions{
- // Body: "",
- Event: "COMMENT",
- Comments: []api.CreatePullReviewComment{
- {
- Path: "README.md",
- Body: "first new line",
- OldLineNum: 0,
- NewLineNum: 1,
- }, {
- Path: "README.md",
- Body: "first old line",
- OldLineNum: 1,
- NewLineNum: 0,
- },
- },
- })
- var commentReview api.PullReview
-
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &commentReview)
- assert.EqualValues(t, "COMMENT", commentReview.State)
- assert.EqualValues(t, 2, commentReview.CodeCommentsCount)
- assert.Empty(t, commentReview.Body)
- assert.False(t, commentReview.Dismissed)
-
- // test CreatePullReview Comment with body but without comments
- commentBody := "This is a body of the comment."
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.CreatePullReviewOptions{
- Body: commentBody,
- Event: "COMMENT",
- Comments: []api.CreatePullReviewComment{},
- })
-
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &commentReview)
- assert.EqualValues(t, "COMMENT", commentReview.State)
- assert.EqualValues(t, 0, commentReview.CodeCommentsCount)
- assert.EqualValues(t, commentBody, commentReview.Body)
- assert.False(t, commentReview.Dismissed)
-
- // test CreatePullReview Comment without body and no comments
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.CreatePullReviewOptions{
- Body: "",
- Event: "COMMENT",
- Comments: []api.CreatePullReviewComment{},
- })
- resp = MakeRequest(t, req, http.StatusUnprocessableEntity)
- errMap := make(map[string]any)
- json.Unmarshal(resp.Body.Bytes(), &errMap)
- assert.EqualValues(t, "review event COMMENT requires a body or a comment", errMap["message"].(string))
-
- // test get review requests
- // to make it simple, use same api with get review
- pullIssue12 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 12})
- assert.NoError(t, pullIssue12.LoadAttributes(db.DefaultContext))
- repo3 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pullIssue12.RepoID})
-
- req = NewRequestf(t, http.MethodGet, "/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token)
- resp = MakeRequest(t, req, http.StatusOK)
- DecodeJSON(t, resp, &reviews)
- assert.EqualValues(t, 11, reviews[0].ID)
- assert.EqualValues(t, "REQUEST_REVIEW", reviews[0].State)
- assert.EqualValues(t, 0, reviews[0].CodeCommentsCount)
- assert.False(t, reviews[0].Stale)
- assert.True(t, reviews[0].Official)
- assert.EqualValues(t, "test_team", reviews[0].ReviewerTeam.Name)
-
- assert.EqualValues(t, 12, reviews[1].ID)
- assert.EqualValues(t, "REQUEST_REVIEW", reviews[1].State)
- assert.EqualValues(t, 0, reviews[0].CodeCommentsCount)
- assert.False(t, reviews[1].Stale)
- assert.True(t, reviews[1].Official)
- assert.EqualValues(t, 1, reviews[1].Reviewer.ID)
- }
-
- func TestAPIPullReviewRequest(t *testing.T) {
- defer tests.PrepareTestEnv(t)()
- pullIssue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 3})
- assert.NoError(t, pullIssue.LoadAttributes(db.DefaultContext))
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pullIssue.RepoID})
-
- // Test add Review Request
- session := loginUser(t, "user2")
- token := getTokenForLoggedInUser(t, session, auth_model.AccessTokenScopeWriteRepository)
- req := NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.PullReviewRequestOptions{
- Reviewers: []string{"user4@example.com", "user8"},
- })
- MakeRequest(t, req, http.StatusCreated)
-
- // poster of pr can't be reviewer
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.PullReviewRequestOptions{
- Reviewers: []string{"user1"},
- })
- MakeRequest(t, req, http.StatusUnprocessableEntity)
-
- // test user not exist
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.PullReviewRequestOptions{
- Reviewers: []string{"testOther"},
- })
- MakeRequest(t, req, http.StatusNotFound)
-
- // Test Remove Review Request
- session2 := loginUser(t, "user4")
- token2 := getTokenForLoggedInUser(t, session2, auth_model.AccessTokenScopeWriteRepository)
-
- req = NewRequestWithJSON(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token2), &api.PullReviewRequestOptions{
- Reviewers: []string{"user4"},
- })
- MakeRequest(t, req, http.StatusNoContent)
-
- // doer is not admin
- req = NewRequestWithJSON(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token2), &api.PullReviewRequestOptions{
- Reviewers: []string{"user8"},
- })
- MakeRequest(t, req, http.StatusUnprocessableEntity)
-
- req = NewRequestWithJSON(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token), &api.PullReviewRequestOptions{
- Reviewers: []string{"user8"},
- })
- MakeRequest(t, req, http.StatusNoContent)
-
- // Test team review request
- pullIssue12 := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 12})
- assert.NoError(t, pullIssue12.LoadAttributes(db.DefaultContext))
- repo3 := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pullIssue12.RepoID})
-
- // Test add Team Review Request
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token), &api.PullReviewRequestOptions{
- TeamReviewers: []string{"team1", "owners"},
- })
- MakeRequest(t, req, http.StatusCreated)
-
- // Test add Team Review Request to not allowned
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token), &api.PullReviewRequestOptions{
- TeamReviewers: []string{"test_team"},
- })
- MakeRequest(t, req, http.StatusUnprocessableEntity)
-
- // Test add Team Review Request to not exist
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token), &api.PullReviewRequestOptions{
- TeamReviewers: []string{"not_exist_team"},
- })
- MakeRequest(t, req, http.StatusNotFound)
-
- // Test Remove team Review Request
- req = NewRequestWithJSON(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token), &api.PullReviewRequestOptions{
- TeamReviewers: []string{"team1"},
- })
- MakeRequest(t, req, http.StatusNoContent)
-
- // empty request test
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token), &api.PullReviewRequestOptions{})
- MakeRequest(t, req, http.StatusCreated)
-
- req = NewRequestWithJSON(t, http.MethodDelete, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo3.OwnerName, repo3.Name, pullIssue12.Index, token), &api.PullReviewRequestOptions{})
- MakeRequest(t, req, http.StatusNoContent)
- }
-
- func TestAPIPullReviewStayDismissed(t *testing.T) {
- // This test against issue https://github.com/go-gitea/gitea/issues/28542
- // where old reviews surface after a review request got dismissed.
- defer tests.PrepareTestEnv(t)()
- pullIssue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 3})
- assert.NoError(t, pullIssue.LoadAttributes(db.DefaultContext))
- repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pullIssue.RepoID})
- user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
- session2 := loginUser(t, user2.LoginName)
- token2 := getTokenForLoggedInUser(t, session2, auth_model.AccessTokenScopeWriteRepository)
- user8 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 8})
- session8 := loginUser(t, user8.LoginName)
- token8 := getTokenForLoggedInUser(t, session8, auth_model.AccessTokenScopeWriteRepository)
-
- // user2 request user8
- req := NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token2), &api.PullReviewRequestOptions{
- Reviewers: []string{user8.LoginName},
- })
- MakeRequest(t, req, http.StatusCreated)
-
- reviewsCountCheck(t,
- "check we have only one review request",
- pullIssue.ID, user8.ID, 0, 1, 1, false)
-
- // user2 request user8 again, it is expected to be ignored
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token2), &api.PullReviewRequestOptions{
- Reviewers: []string{user8.LoginName},
- })
- MakeRequest(t, req, http.StatusCreated)
-
- reviewsCountCheck(t,
- "check we have only one review request, even after re-request it again",
- pullIssue.ID, user8.ID, 0, 1, 1, false)
-
- // user8 reviews it as accept
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token8), &api.CreatePullReviewOptions{
- Event: "APPROVED",
- Body: "lgtm",
- })
- MakeRequest(t, req, http.StatusOK)
-
- reviewsCountCheck(t,
- "check we have one valid approval",
- pullIssue.ID, user8.ID, 0, 0, 1, true)
-
- // emulate of auto-dismiss lgtm on a protected branch that where a pull just got an update
- _, err := db.GetEngine(db.DefaultContext).Where("issue_id = ? AND reviewer_id = ?", pullIssue.ID, user8.ID).
- Cols("dismissed").Update(&issues_model.Review{Dismissed: true})
- assert.NoError(t, err)
-
- // user2 request user8 again
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/requested_reviewers?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token2), &api.PullReviewRequestOptions{
- Reviewers: []string{user8.LoginName},
- })
- MakeRequest(t, req, http.StatusCreated)
-
- reviewsCountCheck(t,
- "check we have no valid approval and one review request",
- pullIssue.ID, user8.ID, 1, 1, 2, false)
-
- // user8 dismiss review
- _, err = issue_service.ReviewRequest(db.DefaultContext, pullIssue, user8, user8, false)
- assert.NoError(t, err)
-
- reviewsCountCheck(t,
- "check new review request is now dismissed",
- pullIssue.ID, user8.ID, 1, 0, 1, false)
-
- // add a new valid approval
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token8), &api.CreatePullReviewOptions{
- Event: "APPROVED",
- Body: "lgtm",
- })
- MakeRequest(t, req, http.StatusOK)
-
- reviewsCountCheck(t,
- "check that old reviews requests are deleted",
- pullIssue.ID, user8.ID, 1, 0, 2, true)
-
- // now add a change request witch should dismiss the approval
- req = NewRequestWithJSON(t, http.MethodPost, fmt.Sprintf("/api/v1/repos/%s/%s/pulls/%d/reviews?token=%s", repo.OwnerName, repo.Name, pullIssue.Index, token8), &api.CreatePullReviewOptions{
- Event: "REQUEST_CHANGES",
- Body: "please change XYZ",
- })
- MakeRequest(t, req, http.StatusOK)
-
- reviewsCountCheck(t,
- "check that old reviews are dismissed",
- pullIssue.ID, user8.ID, 2, 0, 3, false)
- }
-
- func reviewsCountCheck(t *testing.T, name string, issueID, reviewerID int64, expectedDismissed, expectedRequested, expectedTotal int, expectApproval bool) {
- t.Run(name, func(t *testing.T) {
- unittest.AssertCountByCond(t, "review", builder.Eq{
- "issue_id": issueID,
- "reviewer_id": reviewerID,
- "dismissed": true,
- }, expectedDismissed)
-
- unittest.AssertCountByCond(t, "review", builder.Eq{
- "issue_id": issueID,
- "reviewer_id": reviewerID,
- }, expectedTotal)
-
- unittest.AssertCountByCond(t, "review", builder.Eq{
- "issue_id": issueID,
- "reviewer_id": reviewerID,
- "type": issues_model.ReviewTypeRequest,
- }, expectedRequested)
-
- approvalCount := 0
- if expectApproval {
- approvalCount = 1
- }
- unittest.AssertCountByCond(t, "review", builder.Eq{
- "issue_id": issueID,
- "reviewer_id": reviewerID,
- "type": issues_model.ReviewTypeApprove,
- "dismissed": false,
- }, approvalCount)
- })
- }
|