# Conflicts:
#	pom.xml
#	src/main/javassist/ByteArrayClassPath.java
#	src/main/javassist/ClassClassPath.java
#	src/main/javassist/ClassPoolTail.java
#	src/main/javassist/LoaderClassPath.java
#	src/main/javassist/URLClassPath.java

Source walk/Spring clean/Parameterize/Enhance/Squash warnings et.al.

With the unit tests warnings were squashed by suppressing them with SuppressWarnings annotations, instead of
reparing the issues as was done with the source. Reasons being...
 * The tests might be relying on the types as they were defined.
 * If the tests were written to test against the correct forms they would've/should've stipulated those.
 * Even unused members might be important to tests so we attempt to change as little as possible.

The following were applied during multiple itterations through the source.
 * Parameterize raw types.
 * Mark unused members.
 * Annotate override and deprecated methods.
 * Convert loops to enhance for loop.
 * Remove redundant else statements.
 * Widening collection type references.
 * Optimize code for improved readability.
 * Squash compiler warnings.
 * Identify smells.

Changed to org.junit.Assert.

Changed to org.junit.Assert.

To honour the Object.equals contract.

To honour the Object.equals contract.

To honour the Object.equals contract.

To honour the Object.equals contract.

Changed to org.junit.Assert.

There were minimal changes:
Some tests had their own runners these were discontinued as IDEs/maven run the tests anyway.
Removed the main methods for these.
2 tests were dependent on the running order so added the test sorter.

All tests succeed on junit 4 with legacy support.

In order to squash the mvn build warnings.

In order to squash the mvn build warnings.

Move the test output folder 'runtests' to target or build directory so that mvn clean can clean that.

A fix for older JDK8 versions: https://bugs.openjdk.java.net/browse/JDK-8041920

A fix for older JDK8 versions: https://bugs.openjdk.java.net/browse/JDK-8041920
This caused random failures a little time after startup. Reported now so that when we upgrade javassist for JDK9 then we would not have to fork this class.

Due to the specification change of jigsaw, ClassLoader#defineClass()
cannot be invoked through reflection API.  As a workaround,
  --add-opens java.base/java.lang=ALL-UNNAMED
must be given to the JVM.  The ant target "runtest9" adds this jvm
argument.

See #ClassFilesAsResources in JSR 376.  We don't need to hack the module system to read a class file in java.lang.

http://openjdk.java.net/projects/jigsaw/spec/issues/

create a proxy object due to access controls by jigsaw.

LoaderClassPath is modified to show the same behavior in both Java 8 and 9.