|
123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414 |
- {
- "comments": [
- {
- "key": {
- "uuid": "8b753cc4_7f0ae80d",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphOutPutStream.java",
- "patchSetId": 2
- },
- "lineNbr": 46,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "nit: remove trailing whitespace",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "439ae4d6_5feabe09",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphOutPutStream.java",
- "patchSetId": 2
- },
- "lineNbr": 46,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Done",
- "parentUuid": "8b753cc4_7f0ae80d",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "6e3a87df_081e2fbb",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 65,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "why do you create an alias for an already established constant ?",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "1e61675d_46a88449",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 65,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Yes, using Constants.OBJECT_ID_LENGTH directly is much better.\nDone.",
- "parentUuid": "6e3a87df_081e2fbb",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "44b70337_a4a429be",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 185,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "fix boxing warning:\n\n Integer.valueOf(numChunks)",
- "range": {
- "startLine": 185,
- "startChar": 4,
- "endLine": 185,
- "endChar": 13
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "4ccc0bd7_0504c0ca",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 185,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:38:48Z",
- "side": 1,
- "message": "Done",
- "parentUuid": "44b70337_a4a429be",
- "range": {
- "startLine": 185,
- "startChar": 4,
- "endLine": 185,
- "endChar": 13
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "ad8b2e8a_1dfb602a",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 310,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "this local variable hides a field with the same name",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "6d8aa6ae_61a09e57",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 310,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Done",
- "parentUuid": "ad8b2e8a_1dfb602a",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "685db554_ec25b9e2",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 374,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "this variable hides a field with the same name",
- "range": {
- "startLine": 374,
- "startChar": 14,
- "endLine": 374,
- "endChar": 18
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "2ea95680_0b9da5e2",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/internal/storage/commitgraph/CommitGraphWriter.java",
- "patchSetId": 2
- },
- "lineNbr": 374,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Done",
- "parentUuid": "685db554_ec25b9e2",
- "range": {
- "startLine": 374,
- "startChar": 14,
- "endLine": 374,
- "endChar": 18
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "f6c31824_bb287437",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 18,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "spell out object database instead of an unusual acronym",
- "range": {
- "startLine": 18,
- "startChar": 30,
- "endLine": 18,
- "endChar": 33
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "7b73dd60_86509ab2",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 18,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Done",
- "parentUuid": "f6c31824_bb287437",
- "range": {
- "startLine": 18,
- "startChar": 30,
- "endLine": 18,
- "endChar": 33
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "77e0549f_5ba48aab",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 31,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "why isn\u0027t this an interface ?",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "279be571_9a12edf3",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 31,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Ack",
- "parentUuid": "77e0549f_5ba48aab",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- },
- {
- "key": {
- "uuid": "bcf821de_35017f70",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 37,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "- remove NUMBER from this name ? it\u0027s an int so that should be obvious\n- maybe something like NOT_IN_GRAPH instead of INFINITY ?",
- "range": {
- "startLine": 37,
- "startChar": 25,
- "endLine": 37,
- "endChar": 51
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "7709463c_08af3e0a",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 37,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "\u003e remove NUMBER from this name ? it\u0027s an int so that should be obvious\nI just use the name the same with the CGit, document[1] mention it.\nBut the name seems difficult to understand, indeed.\n\n[1] https://git-scm.com/docs/commit-graph\n\u003e maybe something like NOT_IN_GRAPH instead of INFINITY ?\nWe need to indicate that this constant is used for generation number, maybe GENERATION_UNKNOWN?",
- "parentUuid": "bcf821de_35017f70",
- "range": {
- "startLine": 37,
- "startChar": 25,
- "endLine": 37,
- "endChar": 51
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "1c4e1170_dc888239",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 44,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "maybe GENERATION_UNKNOWN ?",
- "range": {
- "startLine": 44,
- "startChar": 25,
- "endLine": 44,
- "endChar": 47
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "5f8b63fa_b48f61c1",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 44,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "GENERATION_NOT_COMPUTED is better?",
- "parentUuid": "1c4e1170_dc888239",
- "range": {
- "startLine": 44,
- "startChar": 25,
- "endLine": 44,
- "endChar": 47
- },
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "e2076e4f_33e72d5d",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 76,
- "author": {
- "id": 4
- },
- "writtenOn": "2021-07-08T18:37:08Z",
- "side": 1,
- "message": "why isn\u0027t this an interface ?",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": true
- },
- {
- "key": {
- "uuid": "ca82d4bc_78aea305",
- "filename": "org.eclipse.jgit/src/org/eclipse/jgit/lib/CommitGraph.java",
- "patchSetId": 2
- },
- "lineNbr": 76,
- "author": {
- "id": 304466
- },
- "writtenOn": "2021-07-09T08:22:24Z",
- "side": 1,
- "message": "Ack",
- "parentUuid": "e2076e4f_33e72d5d",
- "revId": "f54f22462bbe047feb86f12547d53a2cd62f6013",
- "serverId": "97ee7c02-f12f-4043-b43e-dea463d88b31",
- "unresolved": false
- }
- ]
- }
|