There is no point in calling back to the RemoteReader to resolve a 40-digit hex SHA-1 to itself. We already skip that call when not ignoring remote failures; skip it when ignoring remote failures, too. This should simplify RemoteReader implementations. Reported-by: Han-Wen Nienhuys <hanwen@google.com> Change-Id: I7566968ed1f39b1ad73574fa903faf3ee308eb87tags/v4.10.0.201712302008-r
@@ -534,8 +534,7 @@ public class RepoCommand extends GitCommand<RevCommit> { | |||
String path = proj.getPath(); | |||
String nameUri = proj.getName(); | |||
ObjectId objectId; | |||
if (ObjectId.isId(proj.getRevision()) | |||
&& !ignoreRemoteFailures) { | |||
if (ObjectId.isId(proj.getRevision())) { | |||
objectId = ObjectId.fromString(proj.getRevision()); | |||
} else { | |||
objectId = callback.sha1(nameUri, proj.getRevision()); |