Browse Source

s/StringBuffer/StringBuilder as appropriate where no concurrency is needed

tags/v0.8.1
Karthik K 14 years ago
parent
commit
2c14e78a22

+ 3
- 3
org.eclipse.jgit/src/org/eclipse/jgit/lib/Config.java View File

private static String escapeValue(final String x) { private static String escapeValue(final String x) {
boolean inquote = false; boolean inquote = false;
int lineStart = 0; int lineStart = 0;
final StringBuffer r = new StringBuffer(x.length());
final StringBuilder r = new StringBuilder(x.length());
for (int k = 0; k < x.length(); k++) { for (int k = 0; k < x.length(); k++) {
final char c = x.charAt(k); final char c = x.charAt(k);
switch (c) { switch (c) {


private static String readKeyName(final StringReader in) private static String readKeyName(final StringReader in)
throws ConfigInvalidException { throws ConfigInvalidException {
final StringBuffer name = new StringBuffer();
final StringBuilder name = new StringBuilder();
for (;;) { for (;;) {
int c = in.read(); int c = in.read();
if (c < 0) if (c < 0)


private static String readValue(final StringReader in, boolean quote, private static String readValue(final StringReader in, boolean quote,
final int eol) throws ConfigInvalidException { final int eol) throws ConfigInvalidException {
final StringBuffer value = new StringBuffer();
final StringBuilder value = new StringBuilder();
boolean space = false; boolean space = false;
for (;;) { for (;;) {
int c = in.read(); int c = in.read();

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/lib/FileTreeEntry.java View File

} }


public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId())); r.append(ObjectId.toString(getId()));
r.append(' '); r.append(' ');
r.append(isExecutable() ? 'X' : 'F'); r.append(isExecutable() ? 'X' : 'F');

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/lib/GitlinkTreeEntry.java View File



@Override @Override
public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId())); r.append(ObjectId.toString(getId()));
r.append(" G "); r.append(" G ");
r.append(getFullName()); r.append(getFullName());

+ 4
- 4
org.eclipse.jgit/src/org/eclipse/jgit/lib/PersonIdent.java View File

* @return this person's declared time zone; null if time zone is unknown. * @return this person's declared time zone; null if time zone is unknown.
*/ */
public TimeZone getTimeZone() { public TimeZone getTimeZone() {
StringBuffer tzId = new StringBuffer(8);
StringBuilder tzId = new StringBuilder(8);
tzId.append("GMT"); tzId.append("GMT");
appendTimezone(tzId); appendTimezone(tzId);
return TimeZone.getTimeZone(tzId.toString()); return TimeZone.getTimeZone(tzId.toString());
* @return a string in the git author format * @return a string in the git author format
*/ */
public String toExternalString() { public String toExternalString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(getName()); r.append(getName());
r.append(" <"); r.append(" <");
r.append(getEmailAddress()); r.append(getEmailAddress());
return r.toString(); return r.toString();
} }


private void appendTimezone(final StringBuffer r) {
private void appendTimezone(final StringBuilder r) {
int offset = tzOffset; int offset = tzOffset;
final char sign; final char sign;
final int offsetHours; final int offsetHours;
} }


public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
final SimpleDateFormat dtfmt; final SimpleDateFormat dtfmt;
dtfmt = new SimpleDateFormat("EEE MMM d HH:mm:ss yyyy Z", Locale.US); dtfmt = new SimpleDateFormat("EEE MMM d HH:mm:ss yyyy Z", Locale.US);
dtfmt.setTimeZone(getTimeZone()); dtfmt.setTimeZone(getTimeZone());

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/lib/SymlinkTreeEntry.java View File

} }


public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId())); r.append(ObjectId.toString(getId()));
r.append(" S "); r.append(" S ");
r.append(getFullName()); r.append(getFullName());

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/lib/Tag.java View File

throw new CorruptObjectException(tagId, "no tagger/bad header"); throw new CorruptObjectException(tagId, "no tagger/bad header");


// Message should start with an empty line, but // Message should start with an empty line, but
StringBuffer tempMessage = new StringBuffer();
StringBuilder tempMessage = new StringBuilder();
char[] readBuf = new char[2048]; char[] readBuf = new char[2048];
int readLen; int readLen;
while ((readLen = br.read(readBuf)) > 0) { while ((readLen = br.read(readBuf)) > 0) {

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/lib/Tree.java View File

} }


public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append(ObjectId.toString(getId())); r.append(ObjectId.toString(getId()));
r.append(" T "); r.append(" T ");
r.append(getFullName()); r.append(getFullName());

+ 2
- 2
org.eclipse.jgit/src/org/eclipse/jgit/lib/TreeEntry.java View File

* @return repository relative name of this entry * @return repository relative name of this entry
*/ */
public String getFullName() { public String getFullName() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
appendFullName(r); appendFullName(r);
return r.toString(); return r.toString();
} }
*/ */
public abstract FileMode getMode(); public abstract FileMode getMode();


private void appendFullName(final StringBuffer r) {
private void appendFullName(final StringBuilder r) {
final TreeEntry p = getParent(); final TreeEntry p = getParent();
final String n = getName(); final String n = getName();
if (p != null) { if (p != null) {

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/filter/AndRevFilter.java View File



@Override @Override
public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("("); r.append("(");
for (int i = 0; i < subfilters.length; i++) { for (int i = 0; i < subfilters.length; i++) {
if (i > 0) if (i > 0)

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/revwalk/filter/OrRevFilter.java View File



@Override @Override
public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("("); r.append("(");
for (int i = 0; i < subfilters.length; i++) { for (int i = 0; i < subfilters.length; i++) {
if (i > 0) if (i > 0)

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/AndTreeFilter.java View File



@Override @Override
public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("("); r.append("(");
for (int i = 0; i < subfilters.length; i++) { for (int i = 0; i < subfilters.length; i++) {
if (i > 0) if (i > 0)

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/OrTreeFilter.java View File



@Override @Override
public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("("); r.append("(");
for (int i = 0; i < subfilters.length; i++) { for (int i = 0; i < subfilters.length; i++) {
if (i > 0) if (i > 0)

+ 1
- 1
org.eclipse.jgit/src/org/eclipse/jgit/treewalk/filter/PathFilterGroup.java View File

} }


public String toString() { public String toString() {
final StringBuffer r = new StringBuffer();
final StringBuilder r = new StringBuilder();
r.append("FAST("); r.append("FAST(");
for (int i = 0; i < paths.length; i++) { for (int i = 0; i < paths.length; i++) {
if (i > 0) if (i > 0)

Loading…
Cancel
Save