Browse Source

Fix DirCache re-read.

During unit tests and most likely elsewhere, updates come too fast for
a simple timestamp comparison (with one seconds resolution) to work.
I.e. DirCache thinks it hasn't changed. 

Use FileSnapshot instead which has more advanced logic.

Change-Id: Ib850f84398ef7d4b8a8a6f5a0ae6963e37f2b470
Signed-off-by: Robin Rosenberg <robin.rosenberg@dewire.com>
tags/v0.12.1
Robin Rosenberg 13 years ago
parent
commit
3947bd25d9

+ 13
- 11
org.eclipse.jgit/src/org/eclipse/jgit/dircache/DirCache.java View File

import org.eclipse.jgit.lib.Constants; import org.eclipse.jgit.lib.Constants;
import org.eclipse.jgit.lib.ObjectId; import org.eclipse.jgit.lib.ObjectId;
import org.eclipse.jgit.lib.ObjectInserter; import org.eclipse.jgit.lib.ObjectInserter;
import org.eclipse.jgit.storage.file.FileSnapshot;
import org.eclipse.jgit.storage.file.LockFile; import org.eclipse.jgit.storage.file.LockFile;
import org.eclipse.jgit.util.FS; import org.eclipse.jgit.util.FS;
import org.eclipse.jgit.util.IO; import org.eclipse.jgit.util.IO;
/** Location of the current version of the index file. */ /** Location of the current version of the index file. */
private final File liveFile; private final File liveFile;


/** Modification time of the file at the last read/write we did. */
private long lastModified;

/** Individual file index entries, sorted by path name. */ /** Individual file index entries, sorted by path name. */
private DirCacheEntry[] sortedEntries; private DirCacheEntry[] sortedEntries;


/** file system abstraction **/ /** file system abstraction **/
private final FS fs; private final FS fs;


/** Keep track of whether the index has changed or not */
private FileSnapshot snapshot;

/** /**
* Create a new in-core index representation. * Create a new in-core index representation.
* <p> * <p>
throw new IOException(JGitText.get().dirCacheDoesNotHaveABackingFile); throw new IOException(JGitText.get().dirCacheDoesNotHaveABackingFile);
if (!liveFile.exists()) if (!liveFile.exists())
clear(); clear();
else if (liveFile.lastModified() != lastModified) {
else if (snapshot == null || snapshot.isModified(liveFile)) {
try { try {
final FileInputStream inStream = new FileInputStream(liveFile); final FileInputStream inStream = new FileInputStream(liveFile);
try { try {
// //
clear(); clear();
} }
snapshot = FileSnapshot.save(liveFile);
} }
} }


public boolean isOutdated() throws IOException { public boolean isOutdated() throws IOException {
if (liveFile == null || !liveFile.exists()) if (liveFile == null || !liveFile.exists())
return false; return false;
return liveFile.lastModified() != lastModified;
return snapshot.isModified(liveFile);
} }


/** Empty this index, removing all entries. */ /** Empty this index, removing all entries. */
public void clear() { public void clear() {
lastModified = 0;
snapshot = null;
sortedEntries = NO_ENTRIES; sortedEntries = NO_ENTRIES;
entryCnt = 0; entryCnt = 0;
tree = null; tree = null;
final MutableInteger infoAt = new MutableInteger(); final MutableInteger infoAt = new MutableInteger();
for (int i = 0; i < entryCnt; i++) for (int i = 0; i < entryCnt; i++)
sortedEntries[i] = new DirCacheEntry(infos, infoAt, in, md); sortedEntries[i] = new DirCacheEntry(infos, infoAt, in, md);
lastModified = liveFile.lastModified();
snapshot = FileSnapshot.save(liveFile);


// After the file entries are index extensions, and then a footer. // After the file entries are index extensions, and then a footer.
// //


// Write the individual file entries. // Write the individual file entries.
// //
if (lastModified <= 0) {
if (snapshot == null) {
// Write a new index, as no entries require smudging. // Write a new index, as no entries require smudging.
// //
for (int i = 0; i < entryCnt; i++) for (int i = 0; i < entryCnt; i++)
sortedEntries[i].write(dos); sortedEntries[i].write(dos);
} else { } else {
final int smudge_s = (int) (lastModified / 1000);
final int smudge_ns = ((int) (lastModified % 1000)) * 1000000;
final int smudge_s = (int) (snapshot.lastModified() / 1000);
final int smudge_ns = ((int) (snapshot.lastModified() % 1000)) * 1000000;
for (int i = 0; i < entryCnt; i++) { for (int i = 0; i < entryCnt; i++) {
final DirCacheEntry e = sortedEntries[i]; final DirCacheEntry e = sortedEntries[i];
if (e.mightBeRacilyClean(smudge_s, smudge_ns)) if (e.mightBeRacilyClean(smudge_s, smudge_ns))
myLock = null; myLock = null;
if (!tmp.commit()) if (!tmp.commit())
return false; return false;
lastModified = tmp.getCommitLastModified();
snapshot = tmp.getCommitSnapshot();
return true; return true;
} }



+ 4
- 1
org.eclipse.jgit/src/org/eclipse/jgit/storage/file/FileSnapshot.java View File

this.cannotBeRacilyClean = notRacyClean(read); this.cannotBeRacilyClean = notRacyClean(read);
} }


long lastModified() {
/**
* @return time of last snapshot update
*/
public long lastModified() {
return lastModified; return lastModified;
} }



Loading…
Cancel
Save