Browse Source

Fix BadComparable error flagged by error prone

Running recent error prone version complaining on that code:

LfsPointer.java:171: error: [BadComparable] Possible sign flip from
narrowing conversion
		return (int) (getSize() - o.getSize());
		       ^
    (see https://errorprone.info/bugpattern/BadComparable)
  Did you mean 'return Long.compare(getSize(), o.getSize());'?

Bug: 562756
Change-Id: I0522f1025319a9290c448a064fbafdb4b16d1d59
Signed-off-by: David Ostrovsky <david@ostrovsky.org>
tags/v5.8.0.202006091008-r
David Ostrovsky 4 years ago
parent
commit
3e2ec7e5e8
1 changed files with 1 additions and 1 deletions
  1. 1
    1
      org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/LfsPointer.java

+ 1
- 1
org.eclipse.jgit.lfs/src/org/eclipse/jgit/lfs/LfsPointer.java View File

@@ -168,7 +168,7 @@ public class LfsPointer implements Comparable<LfsPointer> {
return x;
}

return (int) (getSize() - o.getSize());
return Long.compare(getSize(), o.getSize());
}
}


Loading…
Cancel
Save