Browse Source

Update notes for submitted changes

* Use absolute paths for file:// URIs in tests
* Use getPath() in FileResolverTest
* Extract protocol constants to a common class
* Move repeat() to utility class for tests
* Remove hardcoded target/trash from test cases
* Remove dependency on StatusCommandTest
* Remove dependency on DiffFormatterReflowTest
* Remove unnecessary import of BaseConnection in MessageWriter
notes/review
Gerrit Code Review @ Eclipse.org 10 years ago
parent
commit
4d15db25c4

+ 8
- 0
1c/4216e4bc17d3bdbce2e369a76e47607d7e3ff3 View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:39:07 -0500
Reviewed-on: https://git.eclipse.org/r/17986
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
3b/c289bcfe9e6e0e725435791572b233e5763a16 View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:41:12 -0500
Reviewed-on: https://git.eclipse.org/r/17982
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
5f/9656c4049b70607f697ba99a746a285c564ccd View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:41:01 -0500
Reviewed-on: https://git.eclipse.org/r/17983
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
69/c1244989e3524c85bc980940c7e6670bc76e11 View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:38:41 -0500
Reviewed-on: https://git.eclipse.org/r/17988
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
75/cfa03e163f72e8707e7f9126f17fbacb025b99 View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:38:27 -0500
Reviewed-on: https://git.eclipse.org/r/17989
Project: jgit/jgit
Branch: refs/heads/master

+ 9
- 0
b0/dbb78e7d2287a5391a75e399009bf2203c4f24 View File

@@ -0,0 +1,9 @@
Code-Review+2: Shawn Pearce <sop@google.com>
IP-Clean+1: Shawn Pearce <sop@google.com>
Verified+1: Shawn Pearce <sop@google.com>
Code-Review+1: Dave Borowitz <dborowitz@google.com>
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:38:59 -0500
Reviewed-on: https://git.eclipse.org/r/17987
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
cc/3ec72734fc442499cca60df957c4ef6749c4c3 View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:39:24 -0500
Reviewed-on: https://git.eclipse.org/r/17985
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
e5/9b3240957e852bfb1c35fa6250ca667743583e View File

@@ -0,0 +1,8 @@
IP-Clean+1: Shawn Pearce <sop@google.com>
Code-Review+2: Dave Borowitz <dborowitz@google.com>
Verified+1: Hudson CI
Submitted-by: Shawn Pearce <sop@google.com>
Submitted-at: Tue, 05 Nov 2013 12:40:38 -0500
Reviewed-on: https://git.eclipse.org/r/17984
Project: jgit/jgit
Branch: refs/heads/master

Loading…
Cancel
Save