mirrors
/
jgit
mirror of https://github.com/eclipse/jgit.git
Watch 1
Star 0
Fork 0
Code Issues 0 Releases 204 Wiki Activity
Browse Source

Update notes for submitted changes 

* FileRepositoryBuilderTest: Don't explicitly close BufferedWriter in try-with-resource
* Explicitly specify charset when constructing FileWriter
* Explicitly specify charset when constructing BufferedReader
* Explicitly specify charset in constructor of InputStreamReader
* Explicitly specify charset when calling getBytes
* Explicitly specify charset in constructor of String
* Make inner classes static where possible
* Bazel: Increase severity of ExpectedExceptionChecker to ERROR
notes/review
Gerrit Code Review @ Eclipse.org 5 years ago
parent
5a10c6822d
commit
6aa0d68841
8 changed files with 56 additions and 0 deletions
Split View Show Diff Stats
  1. 7
    0
      1f/14c16ae459d82b14fcde504bde8d4657b57f57
  2. 7
    0
      2f/1350c9ac51f421e5642915716f43e732c4eb14
  3. 7
    0
      62/012d0bdd3469f4d99ccc7934276d658c182af5
  4. 7
    0
      a7/d3fa3064a9c4a7d380415774b2c31ead5672f2
  5. 7
    0
      b2/ee02f53b75f1358f5784d60880f5a4be9a1d72
  6. 7
    0
      db/abe5f37a547ea1557ad0eedd9cc5d525a1c1ff
  7. 7
    0
      ee/40efcea44bc0c9a28afe29a80c87636947484e
  8. 7
    0
      fa/61fd6f61de2ff997c791154bbaf1dc00ee96b9

+ 7
- 0
1f/14c16ae459d82b14fcde504bde8d4657b57f57 View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129891
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
2f/1350c9ac51f421e5642915716f43e732c4eb14 View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129915
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
62/012d0bdd3469f4d99ccc7934276d658c182af5 View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129969
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
a7/d3fa3064a9c4a7d380415774b2c31ead5672f2 View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129899
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
b2/ee02f53b75f1358f5784d60880f5a4be9a1d72 View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/130063
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
db/abe5f37a547ea1557ad0eedd9cc5d525a1c1ff View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129925
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
ee/40efcea44bc0c9a28afe29a80c87636947484e View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129893
Project: jgit/jgit
Branch: refs/heads/master

+ 7
- 0
fa/61fd6f61de2ff997c791154bbaf1dc00ee96b9 View File

@@ -0,0 +1,7 @@
Verified+1: CI Bot
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Thu, 27 Sep 2018 16:56:00 -0400
Reviewed-on: https://git.eclipse.org/r/129970
Project: jgit/jgit
Branch: refs/heads/master

Write Preview
Loading…
Cancel
Save