Browse Source

Update notes for submitted changes

* NetscapeCookieFile: Make hash static and group overloaded write
* NetscapeCookieFile: Javadoc fixes
* Config: Handle reference-equality warning (and empty javadoc)
* Error Prone: Increase severity of ShortCircuitBoolean to ERROR
* ObjectWalk: Prefer boolean operators over logical operators in comparisons
* BasePackFetchConnection: Prefer boolean operators over logical operators in comparisons
* PackWriter: Prefer boolean operators over logical operators in comparisons
notes/review
Gerrit Code Review @ Eclipse.org 5 years ago
parent
commit
9525de6335

+ 7
- 0
0f/9063941cb5addf2edcb174750c07704fe5690a View File

@@ -0,0 +1,7 @@
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143790
Project: jgit/jgit
Branch: refs/heads/stable-5.4

+ 7
- 0
2e/eabde94a4a39dd827d4ecc8110a6137d401cba View File

@@ -0,0 +1,7 @@
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143787
Project: jgit/jgit
Branch: refs/heads/stable-5.4

+ 7
- 0
4f/e4b0a6bfaa007e381644938f7bbe07c8b843db View File

@@ -0,0 +1,7 @@
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143791
Project: jgit/jgit
Branch: refs/heads/stable-5.4

+ 7
- 0
67/b77717089e68db21af120e6b7bec159f354eca View File

@@ -0,0 +1,7 @@
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143821
Project: jgit/jgit
Branch: refs/heads/stable-5.4

+ 7
- 0
83/b0efbae622079a624332c8a8c13028697e59ec View File

@@ -0,0 +1,7 @@
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143820
Project: jgit/jgit
Branch: refs/heads/stable-5.4

+ 8
- 0
85/8736df37dd9d1b60f6173efae791912dd14d67 View File

@@ -0,0 +1,8 @@
Code-Review+1: Ivan Frade <ifrade@google.com>
Code-Review+2: Matthias Sohn <matthias.sohn@sap.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143786
Project: jgit/jgit
Branch: refs/heads/stable-5.4

+ 7
- 0
96/bd5ad8a35862b8e3d0bd5352c928057ced1ebd View File

@@ -0,0 +1,7 @@
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Submitted-by: Matthias Sohn <matthias.sohn@sap.com>
Submitted-at: Sat, 15 Jun 2019 18:45:38 -0400
Reviewed-on: https://git.eclipse.org/r/143819
Project: jgit/jgit
Branch: refs/heads/stable-5.4

Loading…
Cancel
Save