Преглед изворни кода

reset command: provide convenient and meaningful options help

This commit changes the jgit "reset" command line options help from
this:

jgit reset name [VAL ...] [-- path ... ...] [--hard] [--help (-h)]
[--mixed] [--soft]
 name        : Reset current HEAD to the specified state
 [...]

to this:

jgit reset [commit-ish] [path ... ...] [-- path ... ...] [--hard]
[--help (-h)] [--mixed] [--soft]
 commit-ish  : Reset to given reference name
 [...]

Bug: 484951
Change-Id: I614e71101b4f9f46ef8f02379d1a9d135f3292d2
Signed-off-by: Andrey Loskutov <loskutov@gmx.de>
tags/v4.2.0.201601211800-r
Andrey Loskutov пре 8 година
родитељ
комит
97b4c02cda

+ 27
- 5
org.eclipse.jgit.pgm.test/tst/org/eclipse/jgit/pgm/ResetTest.java Прегледај датотеку

import org.eclipse.jgit.lib.CLIRepositoryTestCase; import org.eclipse.jgit.lib.CLIRepositoryTestCase;
import org.eclipse.jgit.revwalk.RevCommit; import org.eclipse.jgit.revwalk.RevCommit;
import org.junit.Before; import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test; import org.junit.Test;


public class ResetTest extends CLIRepositoryTestCase { public class ResetTest extends CLIRepositoryTestCase {
git = new Git(db); git = new Git(db);
} }


@Test
public void testZombieArgument_Bug484951() throws Exception {
String[] result = execute("git reset -h");
assertFalse("Unexpected argument: " + result[0],
result[0].contains("[VAL ...]"));
}

@Test @Test
public void testResetSelf() throws Exception { public void testResetSelf() throws Exception {
RevCommit commit = git.commit().setMessage("initial commit").call(); RevCommit commit = git.commit().setMessage("initial commit").call();


@Test @Test
public void testResetPathDoubleDash() throws Exception { public void testResetPathDoubleDash() throws Exception {
resetPath(true);
resetPath(true, true);
} }


@Test @Test
public void testResetPathNoDoubleDash() throws Exception { public void testResetPathNoDoubleDash() throws Exception {
resetPath(false);
resetPath(false, true);
}

@Test
public void testResetPathDoubleDashNoRef() throws Exception {
resetPath(true, false);
}

@Ignore("Currently we cannote recognize if a name is a commit-ish or a path, "
+ "so 'git reset a' will not work if 'a' is not a branch name but a file path")
@Test
public void testResetPathNoDoubleDashNoRef() throws Exception {
resetPath(false, false);
} }


private void resetPath(boolean useDoubleDash) throws Exception {
private void resetPath(boolean useDoubleDash, boolean supplyCommit)
throws Exception {
// create files a and b // create files a and b
writeTrashFile("a", "Hello world a"); writeTrashFile("a", "Hello world a");
writeTrashFile("b", "Hello world b"); writeTrashFile("b", "Hello world b");
git.add().addFilepattern(".").call(); git.add().addFilepattern(".").call();


// reset only file a // reset only file a
String cmd = String.format("git reset %s%s a", commit.getId().name(),
(useDoubleDash) ? " --" : "");
String cmd = String.format("git reset %s%s a",
supplyCommit ? commit.getId().name() : "",
useDoubleDash ? " --" : "");
assertStringArrayEquals("", execute(cmd)); assertStringArrayEquals("", execute(cmd));
assertEquals(commit.getId(), assertEquals(commit.getId(),
git.getRepository().exactRef("HEAD").getObjectId()); git.getRepository().exactRef("HEAD").getObjectId());

+ 1
- 0
org.eclipse.jgit.pgm/resources/org/eclipse/jgit/pgm/internal/CLIText.properties Прегледај датотеку

usage_recurseIntoSubtrees=recurse into subtrees usage_recurseIntoSubtrees=recurse into subtrees
usage_renameLimit=limit size of rename matrix usage_renameLimit=limit size of rename matrix
usage_reset=Reset current HEAD to the specified state usage_reset=Reset current HEAD to the specified state
usage_resetReference=Reset to given reference name
usage_resetHard=Resets the index and working tree usage_resetHard=Resets the index and working tree
usage_resetSoft=Resets without touching the index file nor the working tree usage_resetSoft=Resets without touching the index file nor the working tree
usage_resetMixed=Resets the index but not the working tree usage_resetMixed=Resets the index but not the working tree

+ 5
- 5
org.eclipse.jgit.pgm/src/org/eclipse/jgit/pgm/Reset.java Прегледај датотеку

import org.eclipse.jgit.api.ResetCommand.ResetType; import org.eclipse.jgit.api.ResetCommand.ResetType;
import org.kohsuke.args4j.Argument; import org.kohsuke.args4j.Argument;
import org.kohsuke.args4j.Option; import org.kohsuke.args4j.Option;
import org.kohsuke.args4j.spi.StopOptionHandler;
import org.kohsuke.args4j.spi.RestOfArgumentsHandler;


@Command(common = true, usage = "usage_reset") @Command(common = true, usage = "usage_reset")
class Reset extends TextBuiltin { class Reset extends TextBuiltin {
@Option(name = "--hard", usage = "usage_resetHard") @Option(name = "--hard", usage = "usage_resetHard")
private boolean hard = false; private boolean hard = false;


@Argument(required = true, index = 0, metaVar = "metaVar_name", usage = "usage_reset")
@Argument(required = false, index = 0, metaVar = "metaVar_commitish", usage = "usage_resetReference")
private String commit; private String commit;


@Argument(index = 1)
@Option(name = "--", metaVar = "metaVar_paths", multiValued = true, handler = StopOptionHandler.class)
private List<String> paths = new ArrayList<String>();
@Argument(required = false, index = 1, metaVar = "metaVar_paths")
@Option(name = "--", metaVar = "metaVar_paths", multiValued = true, handler = RestOfArgumentsHandler.class)
private List<String> paths = new ArrayList<>();


@Override @Override
protected void run() throws Exception { protected void run() throws Exception {

Loading…
Откажи
Сачувај