Bladeren bron

PacketLineInTest: test for END and DELIM being distinguishable

Explicitly test that END and DELIM can be distinguished. If not, the
wire protocol V2 breaks down.

Bug: 568950
Change-Id: I5f3496168244303c68893f1c756831dd27440aeb
Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>
tags/v5.10.0.202012021225-rc1
Thomas Wolf 3 jaren geleden
bovenliggende
commit
c053b510b3
1 gewijzigde bestanden met toevoegingen van 8 en 3 verwijderingen
  1. 8
    3
      org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/PacketLineInTest.java

+ 8
- 3
org.eclipse.jgit.test/tst/org/eclipse/jgit/transport/PacketLineInTest.java Bestand weergeven

@@ -12,8 +12,8 @@ package org.eclipse.jgit.transport;

import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.assertSame;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;

import java.io.ByteArrayInputStream;
@@ -111,20 +111,25 @@ public class PacketLineInTest {
final String act = in.readString();
assertEquals("", act);
assertFalse(PacketLineIn.isEnd(act));
assertFalse(PacketLineIn.isDelimiter(act));
assertEOF();
}

@Test
public void testReadString_End() throws IOException {
init("0000");
assertTrue(PacketLineIn.isEnd(in.readString()));
String act = in.readString();
assertTrue(PacketLineIn.isEnd(act));
assertFalse(PacketLineIn.isDelimiter(act));
assertEOF();
}

@Test
public void testReadString_Delim() throws IOException {
init("0001");
assertTrue(PacketLineIn.isDelimiter(in.readString()));
String act = in.readString();
assertTrue(PacketLineIn.isDelimiter(act));
assertFalse(PacketLineIn.isEnd(act));
assertEOF();
}


Laden…
Annuleren
Opslaan