Browse Source

Update notes for submitted changes

* dfs: Take size as long instead of int
* dfs: Read at the aligned position
* dfs: Add a position argument
* dfs: Move the deeply nested code to its own method
notes/review
Gerrit Code Review @ Eclipse.org 4 years ago
parent
commit
c657547d55

+ 8
- 0
46/678b303c6625c039109b1a06c0df0ec82dd290 View File

@@ -0,0 +1,8 @@
Code-Review+1: Ivan Frade <ifrade@google.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Submitted-by: David Pursehouse <david.pursehouse@gmail.com>
Submitted-at: Fri, 30 Aug 2019 07:09:51 -0400
Reviewed-on: https://git.eclipse.org/r/144158
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
56/6384fa45a9dde5dc463ee90b1593f917eb227c View File

@@ -0,0 +1,8 @@
Code-Review+1: Ivan Frade <ifrade@google.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Submitted-by: David Pursehouse <david.pursehouse@gmail.com>
Submitted-at: Fri, 30 Aug 2019 07:09:51 -0400
Reviewed-on: https://git.eclipse.org/r/144156
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
c0/cfdcd2f1a14eba2240ce26b3969b9e9267027d View File

@@ -0,0 +1,8 @@
Code-Review+1: Ivan Frade <ifrade@google.com>
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Submitted-by: David Pursehouse <david.pursehouse@gmail.com>
Submitted-at: Fri, 30 Aug 2019 07:09:51 -0400
Reviewed-on: https://git.eclipse.org/r/144159
Project: jgit/jgit
Branch: refs/heads/master

+ 8
- 0
e8/37bdd0face058ad4f4f7ebdb4802514719bb94 View File

@@ -0,0 +1,8 @@
Verified+1: JGit Bot <jgit-bot@eclipse.org>
Code-Review+1: Ivan Frade <ifrade@google.com>
Code-Review+2: David Pursehouse <david.pursehouse@gmail.com>
Submitted-by: David Pursehouse <david.pursehouse@gmail.com>
Submitted-at: Fri, 30 Aug 2019 07:09:51 -0400
Reviewed-on: https://git.eclipse.org/r/144157
Project: jgit/jgit
Branch: refs/heads/master

Loading…
Cancel
Save