Author | SHA1 | Message | Date |
---|---|---|---|
David Pursehouse | 6d0168a414 |
Make inner classes static where possible
As reported by Error Prone:
An inner class should be static unless it references members of its
enclosing class. An inner class that is made non-static unnecessarily
uses more memory and does not make the intent of the class clear.
See https://errorprone.info/bugpattern/ClassCanBeStatic
Change-Id: Ib99d120532630dba63cf400cc1c61c318286fc41
Signed-off-by: David Pursehouse <david.pursehouse@gmail.com>
(cherry picked from commit
|
5 years ago |
David Pursehouse | e5b72a4d36 |
HttpClientConnectionTest: Throw UnsupportedOperationException for unused methods
The HttpResponseMock class is only used in a single test to assert on the expected headers. All of its overridden methods are empty, and this results in warnings in Eclipse: 'Empty block should be documented' Rather than adding "// Not used" comments, change all of the methods' implementations to throw UnsupportedOperationException. This not only gets rid of the warnings, but also makes it explicit that we don't intend any of them to actually be called. Change-Id: I8fe06b155e0809bb3507e4e28b00fcc4f9333b0b Signed-off-by: David Pursehouse <david.pursehouse@gmail.com> |
5 years ago |
David Pursehouse | 0a13545966 |
HttpClientConnectionTest: Reformat with the Eclipse style
Change-Id: I1066dea0bbb4573aabaf417365fb46772f0f4d0e Signed-off-by: David Pursehouse <david.pursehouse@gmail.com> |
5 years ago |
David Pursehouse | 6e797bc74a |
HttpClientConnectionTest: Add missing license header
Change-Id: I9e4bd2bfe16f4824eb8ed7ccfab332646b3233b1 Signed-off-by: David Pursehouse <david.pursehouse@gmail.com> |
5 years ago |
Gabriel Couto | 280707b0fc |
HttpClientConnection.getHeaderFields should support multiple values for same header
Bug: 537166 Change-Id: I1ba645968efe01a88f2484f030b7572228ba169c Signed-off-by: Gabriel Couto <gmcouto@gmail.com> |
5 years ago |