mirrors/jgit - jgit - source @ dussan.org

History

Jonathan Nieder 9b46a47fb7 blame: Un-break isFile check in tree walk Originally, blame's walk to find a scapegoat to blame for a file walking backward from a commit used the test treeWalk.getFileMode(0).getObjectType() != OBJ_BLOB to throw out gitlink (submodule) entries. Later, `52500d3264` (blame: Micro optimize blob lookup in tree, 2014-04-17) changed that test to (treeWalk.getRawMode(0) & TYPE_FILE) != TYPE_FILE These checks are not the same, though: the older test accepts files and symlinks, while the newer one accepts files, symlinks, and gitlink (submodule) entries. This is particularly broken in the submodule case --- trying to parse the referred-to commit as a blob produces caught an exception: GET /gerrit/+blame/master/plugins/reviewnotes HTTP/1.1 org.eclipse.jgit.errors.MissingObjectException: Missing blob `61702414c0` Stick to just (possibly executable) files instead. Symlinks are not line-oriented data so blame on a symlink is not likely to be useful. A quick grep for '& TYPE_' doesn't find any other instances of this bug. Change-Id: Iebcc91f1bee3c91adda51dccd6372e8302bf23fe Signed-off-by: Jonathan Nieder <jrn@google.com>		10 years ago
..
BlameGenerator.java	blame: Un-break isFile check in tree walk	10 years ago
BlameResult.java	Fix BlameResult.computeRange JavaDoc to exclude end index	10 years ago
Candidate.java	blame: Revert common subtree elimination "optimization"	10 years ago
Region.java	blame: Compute the origin of lines in a result file	13 years ago
ReverseWalk.java	blame: Compute the origin of lines in a result file	13 years ago
package-info.java	Add Javadoc description for packages	11 years ago