mirrors/jgit - jgit - source @ dussan.org

History

Magnus Vigerlöf 2a5d20c138 Correct the boolean logic for filtering paths The TreeWalk filtering classes need to support the three different meanings of the return value the path comparison generates. A new path comparison method (isPathMatch) is created with three distinct return values (isPathPrefix use value '0' to encode two of these) which will makes it possible for the logical operators (especially NOT) to aggregate a correct verdict. A filter like: AND(Path("path"), NOT(Path("path/to/other"))) Should filter out 'path/to/other/file', but not 'path/to/my/file'. The path-limiting feature when testing path/to/my/file, would result to run test for the following paths: path path/to path/to/my path/to/my/file isPathPrefix('path/to/other') will return '0' for the first two and since there is no way for NOT to distinguish between an exact match and a match indicating that the tested path is a 'parent', it will incorrectly return false and thus remove everything below 'path' immediately. isPathMatch has a distinguished value for 'parent' matches that will be preserved through the logic operators and should not cause an over-eager removal of paths. The functionality of isPathPrefix is required by other parts and is untouched. Unit tests are included to ensure that the logical functionality is correct and can be preserved. Change-Id: Ice2ca9406f09f1b179569e99b86a0e5d77baa20d Signed-off-by: Magnus Vigerlöf <magnus.vigerlof@gmail.com>		7 years ago
..
filter	Correct the boolean logic for filtering paths	7 years ago
AbstractTreeIteratorTest.java	Convert all JGit unit tests to JUnit 4	13 years ago
CanonicalTreeParserTest.java	Delay locating .gitattributes until requested	8 years ago
EmptyTreeIteratorTest.java	Move base test classes to the junit bundle for reuse for Java 7 tests	11 years ago
FileTreeIteratorTest.java	Enable and fix 'Should be tagged with @Override' warning	7 years ago
FileTreeIteratorWithTimeControl.java	Use fileAttributes to get more attributes in one go	10 years ago
ForPathTest.java	ForPathTest: Open TreeWalk in try-with-resource	8 years ago
NameConflictTreeWalkTest.java	Move base test classes to the junit bundle for reuse for Java 7 tests	11 years ago
PostOrderTreeWalkTest.java	PostOrderTreeWalkTest: Open TreeWalk in try-with-resource	8 years ago
TreeWalkBasicDiffTest.java	Revert "Revert "Remove deprecated Tree, TreeEntry, FileTreeEntry and	8 years ago
TreeWalkJava7Test.java	TreeWalkJava7Test: Open TreeWalk in try-with-resource	8 years ago