mirrors/jgit - jgit - source @ dussan.org

History

Thomas Wolf 2640d38f14 FS.runInShell(): handle quoted filters and hooksPath containing blanks Revert commit `2323d7a`. Using $0 in the shell command call results in the command string being taken literally. That was introduced to fix a problem with backslashes, but is actually not correct. First, the problem with backslashes occurred only on Win32/Cygwin, and has been properly fixed in commit `6f268f8`. Second, this is used only for hooks (which don't have backslashes in their names) and filter commands from the git config, where the user is responsible for properly quoting or escaping such that the commands work. Third, using $0 actually breaks correctly quoted filter commands like in the bug report. The shell really takes the command literally, and then doesn't find the command because of quotes. So revert this change. At the same time there's a related problem with hooks. If the path to the hook contains blanks, runInShell() would also fail to find the hook. In this case, the command doesn't come from user input but is just a Java File object with an absolute path containing blanks. (Can occur if core.hooksPath points to such a path with blanks, or if the repository has such a path.) The path to the hook as obtained from the file system must be quoted. Add a test for a hook path with a blank. This reverts commit `2323d7a1ef`. Bug: 561666 Change-Id: I4d7df13e6c9b245fe1706e191e4316685a8a9d59 Signed-off-by: Thomas Wolf <thomas.wolf@paranor.ch>		4 years ago
..
io	Enable and fix "Statement unnecessarily nested within else clause" warnings	4 years ago
sha1	Make Logger instances final	4 years ago
time	Fix remaining javadoc errors raised by doclint	6 years ago
Base64.java	Reorder modifiers to follow Java Language Specification	4 years ago
BlockList.java	Fix javadoc in org.eclipse.jgit util packages	6 years ago
CachedAuthenticator.java	Remove further unnecessary 'final' keywords	6 years ago
ChangeIdUtil.java	Use indexOf(char) and lastIndexOf(char) rather than String versions	4 years ago
FS.java	FS.runInShell(): handle quoted filters and hooksPath containing blanks	4 years ago
FS_POSIX.java	FS.runInShell(): handle quoted filters and hooksPath containing blanks	4 years ago
FS_Win32.java	Reorder modifiers to follow Java Language Specification	4 years ago
FS_Win32_Cygwin.java	FS.runInShell(): handle quoted filters and hooksPath containing blanks	4 years ago
FileUtils.java	Move KetchSystem.delay to FileUtils.	4 years ago
GSSManagerFactory.java	Join catch sections using multicatch	5 years ago
GitDateFormatter.java	Remove redundant "static" qualifier from enum declarations	4 years ago
GitDateParser.java	Fix typo in Javadoc	4 years ago
Holder.java	Fix javadoc in org.eclipse.jgit util packages	6 years ago
HttpSupport.java	HttpSupport.proxyFor(): use only scheme, host, and port	4 years ago
IO.java	Enable and fix "Statement unnecessarily nested within else clause" warnings	4 years ago
IntList.java	Remove 'final' in parameter lists	6 years ago
LRUMap.java	Support reading and writing cookies.	5 years ago
LfsFactory.java	Move array designators from the variable to the type	4 years ago
LongList.java	Remove 'final' in parameter lists	6 years ago
LongMap.java	Remove further unnecessary 'final' keywords	6 years ago
Monitoring.java	Move array designators from the variable to the type	4 years ago
MutableInteger.java	Fix javadoc in org.eclipse.jgit util packages	6 years ago
NB.java	Fix javadoc in org.eclipse.jgit util packages	6 years ago
Paths.java	Revert 4678f4b and provide another solution for bug 467631	5 years ago
ProcessResult.java	Remove redundant "static" qualifier from enum declarations	4 years ago
QuotedString.java	DiffFormatter: support core.quotePath = false	4 years ago
RawCharSequence.java	Remove 'final' in parameter lists	6 years ago
RawCharUtil.java	Added support for whitespace ignoring	14 years ago
RawParseUtils.java	RawParseUtils: Avoid import of java.nio.charset.StandardCharsets	5 years ago
RawSubStringPattern.java	Remove 'final' in parameter lists	6 years ago
RefList.java	Use RefMap instead of HashMap	5 years ago
RefMap.java	Enable and fix "Statement unnecessarily nested within else clause" warnings	4 years ago
References.java	[error prone] fix ReferenceEquality warning in static equals methods	4 years ago
RelativeDateFormatter.java	Reorder modifiers to follow Java Language Specification	4 years ago
SimpleLruCache.java	Merge branch 'stable-5.3' into stable-5.4	4 years ago
SshSupport.java	SshSupport#runSshCommand: don't throw exception in finally block	4 years ago
Stats.java	Add test for racy git detection in FileSnapshot	4 years ago
StringUtils.java	[error prone] fix ReferenceEquality warning in static equals methods	4 years ago
SystemReader.java	Reorder modifiers to follow Java Language Specification	4 years ago
TemporaryBuffer.java	Remove further unnecessary 'final' keywords	6 years ago
package-info.java	Add Javadoc description for packages	11 years ago