You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

BatchRefUpdateTest.java 35KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083
  1. /*
  2. * Copyright (C) 2017 Google Inc.
  3. * and other copyright owners as documented in the project's IP log.
  4. *
  5. * This program and the accompanying materials are made available
  6. * under the terms of the Eclipse Distribution License v1.0 which
  7. * accompanies this distribution, is reproduced below, and is
  8. * available at http://www.eclipse.org/org/documents/edl-v10.php
  9. *
  10. * All rights reserved.
  11. *
  12. * Redistribution and use in source and binary forms, with or
  13. * without modification, are permitted provided that the following
  14. * conditions are met:
  15. *
  16. * - Redistributions of source code must retain the above copyright
  17. * notice, this list of conditions and the following disclaimer.
  18. *
  19. * - Redistributions in binary form must reproduce the above
  20. * copyright notice, this list of conditions and the following
  21. * disclaimer in the documentation and/or other materials provided
  22. * with the distribution.
  23. *
  24. * - Neither the name of the Eclipse Foundation, Inc. nor the
  25. * names of its contributors may be used to endorse or promote
  26. * products derived from this software without specific prior
  27. * written permission.
  28. *
  29. * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
  30. * CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
  31. * INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
  32. * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
  33. * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR
  34. * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  35. * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
  36. * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
  37. * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
  38. * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,
  39. * STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
  40. * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF
  41. * ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  42. */
  43. package org.eclipse.jgit.internal.storage.file;
  44. import static java.nio.charset.StandardCharsets.UTF_8;
  45. import static java.util.concurrent.TimeUnit.NANOSECONDS;
  46. import static java.util.concurrent.TimeUnit.SECONDS;
  47. import static org.eclipse.jgit.internal.storage.file.BatchRefUpdateTest.Result.LOCK_FAILURE;
  48. import static org.eclipse.jgit.internal.storage.file.BatchRefUpdateTest.Result.OK;
  49. import static org.eclipse.jgit.internal.storage.file.BatchRefUpdateTest.Result.REJECTED_MISSING_OBJECT;
  50. import static org.eclipse.jgit.internal.storage.file.BatchRefUpdateTest.Result.REJECTED_NONFASTFORWARD;
  51. import static org.eclipse.jgit.internal.storage.file.BatchRefUpdateTest.Result.TRANSACTION_ABORTED;
  52. import static org.eclipse.jgit.lib.ObjectId.zeroId;
  53. import static org.eclipse.jgit.transport.ReceiveCommand.Type.CREATE;
  54. import static org.eclipse.jgit.transport.ReceiveCommand.Type.DELETE;
  55. import static org.eclipse.jgit.transport.ReceiveCommand.Type.UPDATE;
  56. import static org.eclipse.jgit.transport.ReceiveCommand.Type.UPDATE_NONFASTFORWARD;
  57. import static org.junit.Assert.assertEquals;
  58. import static org.junit.Assert.assertFalse;
  59. import static org.junit.Assert.assertNotNull;
  60. import static org.junit.Assert.assertNull;
  61. import static org.junit.Assert.assertTrue;
  62. import static org.junit.Assume.assumeTrue;
  63. import java.io.File;
  64. import java.io.IOException;
  65. import java.nio.file.Files;
  66. import java.util.Arrays;
  67. import java.util.Collection;
  68. import java.util.Collections;
  69. import java.util.LinkedHashMap;
  70. import java.util.List;
  71. import java.util.Map;
  72. import java.util.concurrent.locks.ReentrantLock;
  73. import java.util.function.Predicate;
  74. import org.eclipse.jgit.events.ListenerHandle;
  75. import org.eclipse.jgit.events.RefsChangedListener;
  76. import org.eclipse.jgit.junit.LocalDiskRepositoryTestCase;
  77. import org.eclipse.jgit.junit.StrictWorkMonitor;
  78. import org.eclipse.jgit.junit.TestRepository;
  79. import org.eclipse.jgit.lib.AnyObjectId;
  80. import org.eclipse.jgit.lib.BatchRefUpdate;
  81. import org.eclipse.jgit.lib.CheckoutEntry;
  82. import org.eclipse.jgit.lib.ConfigConstants;
  83. import org.eclipse.jgit.lib.Constants;
  84. import org.eclipse.jgit.lib.NullProgressMonitor;
  85. import org.eclipse.jgit.lib.ObjectId;
  86. import org.eclipse.jgit.lib.PersonIdent;
  87. import org.eclipse.jgit.lib.Ref;
  88. import org.eclipse.jgit.lib.RefDatabase;
  89. import org.eclipse.jgit.lib.RefUpdate;
  90. import org.eclipse.jgit.lib.ReflogEntry;
  91. import org.eclipse.jgit.lib.ReflogReader;
  92. import org.eclipse.jgit.lib.Repository;
  93. import org.eclipse.jgit.lib.StoredConfig;
  94. import org.eclipse.jgit.revwalk.RevCommit;
  95. import org.eclipse.jgit.revwalk.RevWalk;
  96. import org.eclipse.jgit.transport.ReceiveCommand;
  97. import org.junit.After;
  98. import org.junit.Before;
  99. import org.junit.Test;
  100. import org.junit.runner.RunWith;
  101. import org.junit.runners.Parameterized;
  102. import org.junit.runners.Parameterized.Parameter;
  103. import org.junit.runners.Parameterized.Parameters;
  104. @SuppressWarnings("boxing")
  105. @RunWith(Parameterized.class)
  106. public class BatchRefUpdateTest extends LocalDiskRepositoryTestCase {
  107. @Parameter
  108. public boolean atomic;
  109. @Parameters(name = "atomic={0}")
  110. public static Collection<Object[]> data() {
  111. return Arrays.asList(new Object[][]{ {Boolean.FALSE}, {Boolean.TRUE} });
  112. }
  113. private Repository diskRepo;
  114. private TestRepository<Repository> repo;
  115. private RefDirectory refdir;
  116. private RevCommit A;
  117. private RevCommit B;
  118. /**
  119. * When asserting the number of RefsChangedEvents you must account for one
  120. * additional event due to the initial ref setup via a number of calls to
  121. * {@link #writeLooseRef(String, AnyObjectId)} (will be fired in execute()
  122. * when it is detected that the on-disk loose refs have changed), or for one
  123. * additional event per {@link #writeRef(String, AnyObjectId)}.
  124. */
  125. private int refsChangedEvents;
  126. private ListenerHandle handle;
  127. private RefsChangedListener refsChangedListener = event -> {
  128. refsChangedEvents++;
  129. };
  130. @Override
  131. @Before
  132. public void setUp() throws Exception {
  133. super.setUp();
  134. diskRepo = createBareRepository();
  135. setLogAllRefUpdates(true);
  136. refdir = (RefDirectory) diskRepo.getRefDatabase();
  137. refdir.setRetrySleepMs(Arrays.asList(0, 0));
  138. repo = new TestRepository<>(diskRepo);
  139. A = repo.commit().create();
  140. B = repo.commit(repo.getRevWalk().parseCommit(A));
  141. refsChangedEvents = 0;
  142. handle = diskRepo.getListenerList()
  143. .addRefsChangedListener(refsChangedListener);
  144. }
  145. @After
  146. public void removeListener() {
  147. handle.remove();
  148. refsChangedEvents = 0;
  149. }
  150. @Test
  151. public void packedRefsFileIsSorted() throws IOException {
  152. assumeTrue(atomic);
  153. for (int i = 0; i < 2; i++) {
  154. BatchRefUpdate bu = diskRepo.getRefDatabase().newBatchUpdate();
  155. String b1 = String.format("refs/heads/a%d",i);
  156. String b2 = String.format("refs/heads/b%d",i);
  157. bu.setAtomic(atomic);
  158. ReceiveCommand c1 = new ReceiveCommand(ObjectId.zeroId(), A, b1);
  159. ReceiveCommand c2 = new ReceiveCommand(ObjectId.zeroId(), B, b2);
  160. bu.addCommand(c1, c2);
  161. try (RevWalk rw = new RevWalk(diskRepo)) {
  162. bu.execute(rw, NullProgressMonitor.INSTANCE);
  163. }
  164. assertEquals(c1.getResult(), ReceiveCommand.Result.OK);
  165. assertEquals(c2.getResult(), ReceiveCommand.Result.OK);
  166. }
  167. File packed = new File(diskRepo.getDirectory(), "packed-refs");
  168. String packedStr = new String(Files.readAllBytes(packed.toPath()), UTF_8);
  169. int a2 = packedStr.indexOf("refs/heads/a1");
  170. int b1 = packedStr.indexOf("refs/heads/b0");
  171. assertTrue(a2 < b1);
  172. }
  173. @Test
  174. public void simpleNoForce() throws IOException {
  175. writeLooseRef("refs/heads/master", A);
  176. writeLooseRef("refs/heads/masters", B);
  177. List<ReceiveCommand> cmds = Arrays.asList(
  178. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  179. new ReceiveCommand(B, A, "refs/heads/masters", UPDATE_NONFASTFORWARD));
  180. execute(newBatchUpdate(cmds));
  181. if (atomic) {
  182. assertResults(cmds, TRANSACTION_ABORTED, REJECTED_NONFASTFORWARD);
  183. assertRefs(
  184. "refs/heads/master", A,
  185. "refs/heads/masters", B);
  186. assertEquals(1, refsChangedEvents);
  187. } else {
  188. assertResults(cmds, OK, REJECTED_NONFASTFORWARD);
  189. assertRefs(
  190. "refs/heads/master", B,
  191. "refs/heads/masters", B);
  192. assertEquals(2, refsChangedEvents);
  193. }
  194. }
  195. @Test
  196. public void simpleForce() throws IOException {
  197. writeLooseRef("refs/heads/master", A);
  198. writeLooseRef("refs/heads/masters", B);
  199. List<ReceiveCommand> cmds = Arrays.asList(
  200. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  201. new ReceiveCommand(B, A, "refs/heads/masters", UPDATE_NONFASTFORWARD));
  202. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  203. assertResults(cmds, OK, OK);
  204. assertRefs(
  205. "refs/heads/master", B,
  206. "refs/heads/masters", A);
  207. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  208. }
  209. @Test
  210. public void nonFastForwardDoesNotDoExpensiveMergeCheck() throws IOException {
  211. writeLooseRef("refs/heads/master", B);
  212. List<ReceiveCommand> cmds = Arrays.asList(
  213. new ReceiveCommand(B, A, "refs/heads/master", UPDATE_NONFASTFORWARD));
  214. try (RevWalk rw = new RevWalk(diskRepo) {
  215. @Override
  216. public boolean isMergedInto(RevCommit base, RevCommit tip) {
  217. throw new AssertionError("isMergedInto() should not be called");
  218. }
  219. }) {
  220. newBatchUpdate(cmds)
  221. .setAllowNonFastForwards(true)
  222. .execute(rw, new StrictWorkMonitor());
  223. }
  224. assertResults(cmds, OK);
  225. assertRefs("refs/heads/master", A);
  226. assertEquals(2, refsChangedEvents);
  227. }
  228. @Test
  229. public void fileDirectoryConflict() throws IOException {
  230. writeLooseRef("refs/heads/master", A);
  231. writeLooseRef("refs/heads/masters", B);
  232. List<ReceiveCommand> cmds = Arrays.asList(
  233. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  234. new ReceiveCommand(zeroId(), A, "refs/heads/master/x", CREATE),
  235. new ReceiveCommand(zeroId(), A, "refs/heads", CREATE));
  236. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true), false);
  237. if (atomic) {
  238. // Atomic update sees that master and master/x are conflicting, then marks
  239. // the first one in the list as LOCK_FAILURE and aborts the rest.
  240. assertResults(cmds,
  241. LOCK_FAILURE, TRANSACTION_ABORTED, TRANSACTION_ABORTED);
  242. assertRefs(
  243. "refs/heads/master", A,
  244. "refs/heads/masters", B);
  245. assertEquals(1, refsChangedEvents);
  246. } else {
  247. // Non-atomic updates are applied in order: master succeeds, then master/x
  248. // fails due to conflict.
  249. assertResults(cmds, OK, LOCK_FAILURE, LOCK_FAILURE);
  250. assertRefs(
  251. "refs/heads/master", B,
  252. "refs/heads/masters", B);
  253. assertEquals(2, refsChangedEvents);
  254. }
  255. }
  256. @Test
  257. public void conflictThanksToDelete() throws IOException {
  258. writeLooseRef("refs/heads/master", A);
  259. writeLooseRef("refs/heads/masters", B);
  260. List<ReceiveCommand> cmds = Arrays.asList(
  261. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  262. new ReceiveCommand(zeroId(), A, "refs/heads/masters/x", CREATE),
  263. new ReceiveCommand(B, zeroId(), "refs/heads/masters", DELETE));
  264. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  265. assertResults(cmds, OK, OK, OK);
  266. assertRefs(
  267. "refs/heads/master", B,
  268. "refs/heads/masters/x", A);
  269. if (atomic) {
  270. assertEquals(2, refsChangedEvents);
  271. } else {
  272. // The non-atomic case actually produces 5 events, but that's an
  273. // implementation detail. We expect at least 4 events, one for the
  274. // initial read due to writeLooseRef(), and then one for each
  275. // successful ref update.
  276. assertTrue(refsChangedEvents >= 4);
  277. }
  278. }
  279. @Test
  280. public void updateToMissingObject() throws IOException {
  281. writeLooseRef("refs/heads/master", A);
  282. ObjectId bad =
  283. ObjectId.fromString("deadbeefdeadbeefdeadbeefdeadbeefdeadbeef");
  284. List<ReceiveCommand> cmds = Arrays.asList(
  285. new ReceiveCommand(A, bad, "refs/heads/master", UPDATE),
  286. new ReceiveCommand(zeroId(), B, "refs/heads/foo2", CREATE));
  287. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true), false);
  288. if (atomic) {
  289. assertResults(cmds, REJECTED_MISSING_OBJECT, TRANSACTION_ABORTED);
  290. assertRefs("refs/heads/master", A);
  291. assertEquals(1, refsChangedEvents);
  292. } else {
  293. assertResults(cmds, REJECTED_MISSING_OBJECT, OK);
  294. assertRefs(
  295. "refs/heads/master", A,
  296. "refs/heads/foo2", B);
  297. assertEquals(2, refsChangedEvents);
  298. }
  299. }
  300. @Test
  301. public void addMissingObject() throws IOException {
  302. writeLooseRef("refs/heads/master", A);
  303. ObjectId bad =
  304. ObjectId.fromString("deadbeefdeadbeefdeadbeefdeadbeefdeadbeef");
  305. List<ReceiveCommand> cmds = Arrays.asList(
  306. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  307. new ReceiveCommand(zeroId(), bad, "refs/heads/foo2", CREATE));
  308. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true), false);
  309. if (atomic) {
  310. assertResults(cmds, TRANSACTION_ABORTED, REJECTED_MISSING_OBJECT);
  311. assertRefs("refs/heads/master", A);
  312. assertEquals(1, refsChangedEvents);
  313. } else {
  314. assertResults(cmds, OK, REJECTED_MISSING_OBJECT);
  315. assertRefs("refs/heads/master", B);
  316. assertEquals(2, refsChangedEvents);
  317. }
  318. }
  319. @Test
  320. public void oneNonExistentRef() throws IOException {
  321. List<ReceiveCommand> cmds = Arrays.asList(
  322. new ReceiveCommand(A, B, "refs/heads/foo1", UPDATE),
  323. new ReceiveCommand(zeroId(), B, "refs/heads/foo2", CREATE));
  324. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  325. if (atomic) {
  326. assertResults(cmds, LOCK_FAILURE, TRANSACTION_ABORTED);
  327. assertRefs();
  328. assertEquals(0, refsChangedEvents);
  329. } else {
  330. assertResults(cmds, LOCK_FAILURE, OK);
  331. assertRefs("refs/heads/foo2", B);
  332. assertEquals(1, refsChangedEvents);
  333. }
  334. }
  335. @Test
  336. public void oneRefWrongOldValue() throws IOException {
  337. writeLooseRef("refs/heads/master", A);
  338. List<ReceiveCommand> cmds = Arrays.asList(
  339. new ReceiveCommand(B, B, "refs/heads/master", UPDATE),
  340. new ReceiveCommand(zeroId(), B, "refs/heads/foo2", CREATE));
  341. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  342. if (atomic) {
  343. assertResults(cmds, LOCK_FAILURE, TRANSACTION_ABORTED);
  344. assertRefs("refs/heads/master", A);
  345. assertEquals(1, refsChangedEvents);
  346. } else {
  347. assertResults(cmds, LOCK_FAILURE, OK);
  348. assertRefs(
  349. "refs/heads/master", A,
  350. "refs/heads/foo2", B);
  351. assertEquals(2, refsChangedEvents);
  352. }
  353. }
  354. @Test
  355. public void nonExistentRef() throws IOException {
  356. writeLooseRef("refs/heads/master", A);
  357. List<ReceiveCommand> cmds = Arrays.asList(
  358. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  359. new ReceiveCommand(A, zeroId(), "refs/heads/foo2", DELETE));
  360. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  361. if (atomic) {
  362. assertResults(cmds, TRANSACTION_ABORTED, LOCK_FAILURE);
  363. assertRefs("refs/heads/master", A);
  364. assertEquals(1, refsChangedEvents);
  365. } else {
  366. assertResults(cmds, OK, LOCK_FAILURE);
  367. assertRefs("refs/heads/master", B);
  368. assertEquals(2, refsChangedEvents);
  369. }
  370. }
  371. @Test
  372. public void noRefLog() throws IOException {
  373. writeRef("refs/heads/master", A);
  374. Map<String, ReflogEntry> oldLogs =
  375. getLastReflogs("refs/heads/master", "refs/heads/branch");
  376. assertEquals(Collections.singleton("refs/heads/master"), oldLogs.keySet());
  377. List<ReceiveCommand> cmds = Arrays.asList(
  378. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  379. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  380. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  381. assertResults(cmds, OK, OK);
  382. assertRefs(
  383. "refs/heads/master", B,
  384. "refs/heads/branch", B);
  385. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  386. assertReflogUnchanged(oldLogs, "refs/heads/master");
  387. assertReflogUnchanged(oldLogs, "refs/heads/branch");
  388. }
  389. @Test
  390. public void reflogDefaultIdent() throws IOException {
  391. writeRef("refs/heads/master", A);
  392. writeRef("refs/heads/branch2", A);
  393. Map<String, ReflogEntry> oldLogs = getLastReflogs(
  394. "refs/heads/master", "refs/heads/branch1", "refs/heads/branch2");
  395. List<ReceiveCommand> cmds = Arrays.asList(
  396. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  397. new ReceiveCommand(zeroId(), B, "refs/heads/branch1", CREATE));
  398. execute(
  399. newBatchUpdate(cmds)
  400. .setAllowNonFastForwards(true)
  401. .setRefLogMessage("a reflog", false));
  402. assertResults(cmds, OK, OK);
  403. assertRefs(
  404. "refs/heads/master", B,
  405. "refs/heads/branch1", B,
  406. "refs/heads/branch2", A);
  407. assertEquals(atomic ? 3 : 4, refsChangedEvents);
  408. assertReflogEquals(
  409. reflog(A, B, new PersonIdent(diskRepo), "a reflog"),
  410. getLastReflog("refs/heads/master"));
  411. assertReflogEquals(
  412. reflog(zeroId(), B, new PersonIdent(diskRepo), "a reflog"),
  413. getLastReflog("refs/heads/branch1"));
  414. assertReflogUnchanged(oldLogs, "refs/heads/branch2");
  415. }
  416. @Test
  417. public void reflogAppendStatusNoMessage() throws IOException {
  418. writeRef("refs/heads/master", A);
  419. writeRef("refs/heads/branch1", B);
  420. List<ReceiveCommand> cmds = Arrays.asList(
  421. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  422. new ReceiveCommand(B, A, "refs/heads/branch1", UPDATE_NONFASTFORWARD),
  423. new ReceiveCommand(zeroId(), A, "refs/heads/branch2", CREATE));
  424. execute(
  425. newBatchUpdate(cmds)
  426. .setAllowNonFastForwards(true)
  427. .setRefLogMessage(null, true));
  428. assertResults(cmds, OK, OK, OK);
  429. assertRefs(
  430. "refs/heads/master", B,
  431. "refs/heads/branch1", A,
  432. "refs/heads/branch2", A);
  433. assertEquals(atomic ? 3 : 5, refsChangedEvents);
  434. assertReflogEquals(
  435. // Always forced; setAllowNonFastForwards(true) bypasses the check.
  436. reflog(A, B, new PersonIdent(diskRepo), "forced-update"),
  437. getLastReflog("refs/heads/master"));
  438. assertReflogEquals(
  439. reflog(B, A, new PersonIdent(diskRepo), "forced-update"),
  440. getLastReflog("refs/heads/branch1"));
  441. assertReflogEquals(
  442. reflog(zeroId(), A, new PersonIdent(diskRepo), "created"),
  443. getLastReflog("refs/heads/branch2"));
  444. }
  445. @Test
  446. public void reflogAppendStatusFastForward() throws IOException {
  447. writeRef("refs/heads/master", A);
  448. List<ReceiveCommand> cmds = Arrays.asList(
  449. new ReceiveCommand(A, B, "refs/heads/master", UPDATE));
  450. execute(newBatchUpdate(cmds).setRefLogMessage(null, true));
  451. assertResults(cmds, OK);
  452. assertRefs("refs/heads/master", B);
  453. assertEquals(2, refsChangedEvents);
  454. assertReflogEquals(
  455. reflog(A, B, new PersonIdent(diskRepo), "fast-forward"),
  456. getLastReflog("refs/heads/master"));
  457. }
  458. @Test
  459. public void reflogAppendStatusWithMessage() throws IOException {
  460. writeRef("refs/heads/master", A);
  461. List<ReceiveCommand> cmds = Arrays.asList(
  462. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  463. new ReceiveCommand(zeroId(), A, "refs/heads/branch", CREATE));
  464. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", true));
  465. assertResults(cmds, OK, OK);
  466. assertRefs(
  467. "refs/heads/master", B,
  468. "refs/heads/branch", A);
  469. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  470. assertReflogEquals(
  471. reflog(A, B, new PersonIdent(diskRepo), "a reflog: fast-forward"),
  472. getLastReflog("refs/heads/master"));
  473. assertReflogEquals(
  474. reflog(zeroId(), A, new PersonIdent(diskRepo), "a reflog: created"),
  475. getLastReflog("refs/heads/branch"));
  476. }
  477. @Test
  478. public void reflogCustomIdent() throws IOException {
  479. writeRef("refs/heads/master", A);
  480. List<ReceiveCommand> cmds = Arrays.asList(
  481. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  482. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  483. PersonIdent ident = new PersonIdent("A Reflog User", "reflog@example.com");
  484. execute(
  485. newBatchUpdate(cmds)
  486. .setRefLogMessage("a reflog", false)
  487. .setRefLogIdent(ident));
  488. assertResults(cmds, OK, OK);
  489. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  490. assertRefs(
  491. "refs/heads/master", B,
  492. "refs/heads/branch", B);
  493. assertReflogEquals(
  494. reflog(A, B, ident, "a reflog"),
  495. getLastReflog("refs/heads/master"),
  496. true);
  497. assertReflogEquals(
  498. reflog(zeroId(), B, ident, "a reflog"),
  499. getLastReflog("refs/heads/branch"),
  500. true);
  501. }
  502. @Test
  503. public void reflogDelete() throws IOException {
  504. writeRef("refs/heads/master", A);
  505. writeRef("refs/heads/branch", A);
  506. assertEquals(
  507. 2, getLastReflogs("refs/heads/master", "refs/heads/branch").size());
  508. List<ReceiveCommand> cmds = Arrays.asList(
  509. new ReceiveCommand(A, zeroId(), "refs/heads/master", DELETE),
  510. new ReceiveCommand(A, B, "refs/heads/branch", UPDATE));
  511. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", false));
  512. assertResults(cmds, OK, OK);
  513. assertRefs("refs/heads/branch", B);
  514. assertEquals(atomic ? 3 : 4, refsChangedEvents);
  515. assertNull(getLastReflog("refs/heads/master"));
  516. assertReflogEquals(
  517. reflog(A, B, new PersonIdent(diskRepo), "a reflog"),
  518. getLastReflog("refs/heads/branch"));
  519. }
  520. @Test
  521. public void reflogFileDirectoryConflict() throws IOException {
  522. writeRef("refs/heads/master", A);
  523. List<ReceiveCommand> cmds = Arrays.asList(
  524. new ReceiveCommand(A, zeroId(), "refs/heads/master", DELETE),
  525. new ReceiveCommand(zeroId(), A, "refs/heads/master/x", CREATE));
  526. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", false));
  527. assertResults(cmds, OK, OK);
  528. assertRefs("refs/heads/master/x", A);
  529. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  530. assertNull(getLastReflog("refs/heads/master"));
  531. assertReflogEquals(
  532. reflog(zeroId(), A, new PersonIdent(diskRepo), "a reflog"),
  533. getLastReflog("refs/heads/master/x"));
  534. }
  535. @Test
  536. public void reflogOnLockFailure() throws IOException {
  537. writeRef("refs/heads/master", A);
  538. Map<String, ReflogEntry> oldLogs =
  539. getLastReflogs("refs/heads/master", "refs/heads/branch");
  540. List<ReceiveCommand> cmds = Arrays.asList(
  541. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  542. new ReceiveCommand(A, B, "refs/heads/branch", UPDATE));
  543. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", false));
  544. if (atomic) {
  545. assertResults(cmds, TRANSACTION_ABORTED, LOCK_FAILURE);
  546. assertEquals(1, refsChangedEvents);
  547. assertReflogUnchanged(oldLogs, "refs/heads/master");
  548. assertReflogUnchanged(oldLogs, "refs/heads/branch");
  549. } else {
  550. assertResults(cmds, OK, LOCK_FAILURE);
  551. assertEquals(2, refsChangedEvents);
  552. assertReflogEquals(
  553. reflog(A, B, new PersonIdent(diskRepo), "a reflog"),
  554. getLastReflog("refs/heads/master"));
  555. assertReflogUnchanged(oldLogs, "refs/heads/branch");
  556. }
  557. }
  558. @Test
  559. public void overrideRefLogMessage() throws Exception {
  560. writeRef("refs/heads/master", A);
  561. List<ReceiveCommand> cmds = Arrays.asList(
  562. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  563. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  564. cmds.get(0).setRefLogMessage("custom log", false);
  565. PersonIdent ident = new PersonIdent(diskRepo);
  566. execute(
  567. newBatchUpdate(cmds)
  568. .setRefLogIdent(ident)
  569. .setRefLogMessage("a reflog", true));
  570. assertResults(cmds, OK, OK);
  571. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  572. assertReflogEquals(
  573. reflog(A, B, ident, "custom log"),
  574. getLastReflog("refs/heads/master"),
  575. true);
  576. assertReflogEquals(
  577. reflog(zeroId(), B, ident, "a reflog: created"),
  578. getLastReflog("refs/heads/branch"),
  579. true);
  580. }
  581. @Test
  582. public void overrideDisableRefLog() throws Exception {
  583. writeRef("refs/heads/master", A);
  584. Map<String, ReflogEntry> oldLogs =
  585. getLastReflogs("refs/heads/master", "refs/heads/branch");
  586. List<ReceiveCommand> cmds = Arrays.asList(
  587. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  588. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  589. cmds.get(0).disableRefLog();
  590. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", true));
  591. assertResults(cmds, OK, OK);
  592. assertEquals(atomic ? 2 : 3, refsChangedEvents);
  593. assertReflogUnchanged(oldLogs, "refs/heads/master");
  594. assertReflogEquals(
  595. reflog(zeroId(), B, new PersonIdent(diskRepo), "a reflog: created"),
  596. getLastReflog("refs/heads/branch"));
  597. }
  598. @Test
  599. public void refLogNotWrittenWithoutConfigOption() throws Exception {
  600. setLogAllRefUpdates(false);
  601. writeRef("refs/heads/master", A);
  602. Map<String, ReflogEntry> oldLogs =
  603. getLastReflogs("refs/heads/master", "refs/heads/branch");
  604. assertTrue(oldLogs.isEmpty());
  605. List<ReceiveCommand> cmds = Arrays.asList(
  606. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  607. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  608. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", false));
  609. assertResults(cmds, OK, OK);
  610. assertReflogUnchanged(oldLogs, "refs/heads/master");
  611. assertReflogUnchanged(oldLogs, "refs/heads/branch");
  612. }
  613. @Test
  614. public void forceRefLogInUpdate() throws Exception {
  615. setLogAllRefUpdates(false);
  616. writeRef("refs/heads/master", A);
  617. assertTrue(
  618. getLastReflogs("refs/heads/master", "refs/heads/branch").isEmpty());
  619. List<ReceiveCommand> cmds = Arrays.asList(
  620. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  621. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  622. execute(
  623. newBatchUpdate(cmds)
  624. .setRefLogMessage("a reflog", false)
  625. .setForceRefLog(true));
  626. assertResults(cmds, OK, OK);
  627. assertReflogEquals(
  628. reflog(A, B, new PersonIdent(diskRepo), "a reflog"),
  629. getLastReflog("refs/heads/master"));
  630. assertReflogEquals(
  631. reflog(zeroId(), B, new PersonIdent(diskRepo), "a reflog"),
  632. getLastReflog("refs/heads/branch"));
  633. }
  634. @Test
  635. public void forceRefLogInCommand() throws Exception {
  636. setLogAllRefUpdates(false);
  637. writeRef("refs/heads/master", A);
  638. Map<String, ReflogEntry> oldLogs =
  639. getLastReflogs("refs/heads/master", "refs/heads/branch");
  640. assertTrue(oldLogs.isEmpty());
  641. List<ReceiveCommand> cmds = Arrays.asList(
  642. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  643. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  644. cmds.get(1).setForceRefLog(true);
  645. execute(newBatchUpdate(cmds).setRefLogMessage("a reflog", false));
  646. assertResults(cmds, OK, OK);
  647. assertReflogUnchanged(oldLogs, "refs/heads/master");
  648. assertReflogEquals(
  649. reflog(zeroId(), B, new PersonIdent(diskRepo), "a reflog"),
  650. getLastReflog("refs/heads/branch"));
  651. }
  652. @Test
  653. public void packedRefsLockFailure() throws Exception {
  654. writeLooseRef("refs/heads/master", A);
  655. List<ReceiveCommand> cmds = Arrays.asList(
  656. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  657. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  658. LockFile myLock = refdir.lockPackedRefs();
  659. try {
  660. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  661. assertFalse(getLockFile("refs/heads/master").exists());
  662. assertFalse(getLockFile("refs/heads/branch").exists());
  663. if (atomic) {
  664. assertResults(cmds, LOCK_FAILURE, TRANSACTION_ABORTED);
  665. assertRefs("refs/heads/master", A);
  666. assertEquals(1, refsChangedEvents);
  667. } else {
  668. // Only operates on loose refs, doesn't care that packed-refs is locked.
  669. assertResults(cmds, OK, OK);
  670. assertRefs(
  671. "refs/heads/master", B,
  672. "refs/heads/branch", B);
  673. assertEquals(3, refsChangedEvents);
  674. }
  675. } finally {
  676. myLock.unlock();
  677. }
  678. }
  679. @Test
  680. public void oneRefLockFailure() throws Exception {
  681. writeLooseRef("refs/heads/master", A);
  682. List<ReceiveCommand> cmds = Arrays.asList(
  683. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE),
  684. new ReceiveCommand(A, B, "refs/heads/master", UPDATE));
  685. LockFile myLock = new LockFile(refdir.fileFor("refs/heads/master"));
  686. assertTrue(myLock.lock());
  687. try {
  688. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  689. assertFalse(LockFile.getLockFile(refdir.packedRefsFile).exists());
  690. assertFalse(getLockFile("refs/heads/branch").exists());
  691. if (atomic) {
  692. assertResults(cmds, TRANSACTION_ABORTED, LOCK_FAILURE);
  693. assertRefs("refs/heads/master", A);
  694. assertEquals(1, refsChangedEvents);
  695. } else {
  696. assertResults(cmds, OK, LOCK_FAILURE);
  697. assertRefs(
  698. "refs/heads/branch", B,
  699. "refs/heads/master", A);
  700. assertEquals(2, refsChangedEvents);
  701. }
  702. } finally {
  703. myLock.unlock();
  704. }
  705. }
  706. @Test
  707. public void singleRefUpdateDoesNotRequirePackedRefsLock() throws Exception {
  708. writeLooseRef("refs/heads/master", A);
  709. List<ReceiveCommand> cmds = Arrays.asList(
  710. new ReceiveCommand(A, B, "refs/heads/master", UPDATE));
  711. LockFile myLock = refdir.lockPackedRefs();
  712. try {
  713. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  714. assertFalse(getLockFile("refs/heads/master").exists());
  715. assertResults(cmds, OK);
  716. assertEquals(2, refsChangedEvents);
  717. assertRefs("refs/heads/master", B);
  718. } finally {
  719. myLock.unlock();
  720. }
  721. }
  722. @Test
  723. public void atomicUpdateRespectsInProcessLock() throws Exception {
  724. assumeTrue(atomic);
  725. writeLooseRef("refs/heads/master", A);
  726. List<ReceiveCommand> cmds = Arrays.asList(
  727. new ReceiveCommand(A, B, "refs/heads/master", UPDATE),
  728. new ReceiveCommand(zeroId(), B, "refs/heads/branch", CREATE));
  729. Thread t = new Thread(() -> {
  730. try {
  731. execute(newBatchUpdate(cmds).setAllowNonFastForwards(true));
  732. } catch (Exception e) {
  733. throw new RuntimeException(e);
  734. }
  735. });
  736. ReentrantLock l = refdir.inProcessPackedRefsLock;
  737. l.lock();
  738. try {
  739. t.start();
  740. long timeoutSecs = 10;
  741. long startNanos = System.nanoTime();
  742. // Hold onto the lock until we observe the worker thread has attempted to
  743. // acquire it.
  744. while (l.getQueueLength() == 0) {
  745. long elapsedNanos = System.nanoTime() - startNanos;
  746. assertTrue(
  747. "timed out waiting for work thread to attempt to acquire lock",
  748. NANOSECONDS.toSeconds(elapsedNanos) < timeoutSecs);
  749. Thread.sleep(3);
  750. }
  751. // Once we unlock, the worker thread should finish the update promptly.
  752. l.unlock();
  753. t.join(SECONDS.toMillis(timeoutSecs));
  754. assertFalse(t.isAlive());
  755. } finally {
  756. if (l.isHeldByCurrentThread()) {
  757. l.unlock();
  758. }
  759. }
  760. assertResults(cmds, OK, OK);
  761. assertEquals(2, refsChangedEvents);
  762. assertRefs(
  763. "refs/heads/master", B,
  764. "refs/heads/branch", B);
  765. }
  766. private void setLogAllRefUpdates(boolean enable) throws Exception {
  767. StoredConfig cfg = diskRepo.getConfig();
  768. cfg.load();
  769. cfg.setBoolean(ConfigConstants.CONFIG_CORE_SECTION, null,
  770. ConfigConstants.CONFIG_KEY_LOGALLREFUPDATES, enable);
  771. cfg.save();
  772. }
  773. private void writeLooseRef(String name, AnyObjectId id) throws IOException {
  774. write(new File(diskRepo.getDirectory(), name), id.name() + "\n");
  775. }
  776. private void writeRef(String name, AnyObjectId id) throws IOException {
  777. RefUpdate u = diskRepo.updateRef(name);
  778. u.setRefLogMessage(getClass().getSimpleName(), false);
  779. u.setForceUpdate(true);
  780. u.setNewObjectId(id);
  781. RefUpdate.Result r = u.update();
  782. switch (r) {
  783. case NEW:
  784. case FORCED:
  785. return;
  786. default:
  787. throw new IOException("Got " + r + " while updating " + name);
  788. }
  789. }
  790. private BatchRefUpdate newBatchUpdate(List<ReceiveCommand> cmds) {
  791. BatchRefUpdate u = refdir.newBatchUpdate();
  792. if (atomic) {
  793. assertTrue(u.isAtomic());
  794. } else {
  795. u.setAtomic(false);
  796. }
  797. u.addCommand(cmds);
  798. return u;
  799. }
  800. private void execute(BatchRefUpdate u) throws IOException {
  801. execute(u, false);
  802. }
  803. private void execute(BatchRefUpdate u, boolean strictWork) throws IOException {
  804. try (RevWalk rw = new RevWalk(diskRepo)) {
  805. u.execute(rw,
  806. strictWork ? new StrictWorkMonitor() : NullProgressMonitor.INSTANCE);
  807. }
  808. }
  809. private void assertRefs(Object... args) throws IOException {
  810. if (args.length % 2 != 0) {
  811. throw new IllegalArgumentException(
  812. "expected even number of args: " + Arrays.toString(args));
  813. }
  814. Map<String, AnyObjectId> expected = new LinkedHashMap<>();
  815. for (int i = 0; i < args.length; i += 2) {
  816. expected.put((String) args[i], (AnyObjectId) args[i + 1]);
  817. }
  818. Map<String, Ref> refs = refdir.getRefs(RefDatabase.ALL);
  819. Ref actualHead = refs.remove(Constants.HEAD);
  820. if (actualHead != null) {
  821. String actualLeafName = actualHead.getLeaf().getName();
  822. assertEquals(
  823. "expected HEAD to point to refs/heads/master, got: " + actualLeafName,
  824. "refs/heads/master", actualLeafName);
  825. AnyObjectId expectedMaster = expected.get("refs/heads/master");
  826. assertNotNull("expected master ref since HEAD exists", expectedMaster);
  827. assertEquals(expectedMaster, actualHead.getObjectId());
  828. }
  829. Map<String, AnyObjectId> actual = new LinkedHashMap<>();
  830. refs.forEach((n, r) -> actual.put(n, r.getObjectId()));
  831. assertEquals(expected.keySet(), actual.keySet());
  832. actual.forEach((n, a) -> assertEquals(n, expected.get(n), a));
  833. }
  834. enum Result {
  835. OK(ReceiveCommand.Result.OK),
  836. LOCK_FAILURE(ReceiveCommand.Result.LOCK_FAILURE),
  837. REJECTED_NONFASTFORWARD(ReceiveCommand.Result.REJECTED_NONFASTFORWARD),
  838. REJECTED_MISSING_OBJECT(ReceiveCommand.Result.REJECTED_MISSING_OBJECT),
  839. TRANSACTION_ABORTED(ReceiveCommand::isTransactionAborted);
  840. final Predicate<? super ReceiveCommand> p;
  841. private Result(Predicate<? super ReceiveCommand> p) {
  842. this.p = p;
  843. }
  844. private Result(ReceiveCommand.Result result) {
  845. this(c -> c.getResult() == result);
  846. }
  847. }
  848. private void assertResults(
  849. List<ReceiveCommand> cmds, Result... expected) {
  850. if (expected.length != cmds.size()) {
  851. throw new IllegalArgumentException(
  852. "expected " + cmds.size() + " result args");
  853. }
  854. for (int i = 0; i < cmds.size(); i++) {
  855. ReceiveCommand c = cmds.get(i);
  856. Result r = expected[i];
  857. assertTrue(
  858. String.format(
  859. "result of command (%d) should be %s: %s %s%s",
  860. Integer.valueOf(i), r, c,
  861. c.getResult(),
  862. c.getMessage() != null ? " (" + c.getMessage() + ")" : ""),
  863. r.p.test(c));
  864. }
  865. }
  866. private Map<String, ReflogEntry> getLastReflogs(String... names)
  867. throws IOException {
  868. Map<String, ReflogEntry> result = new LinkedHashMap<>();
  869. for (String name : names) {
  870. ReflogEntry e = getLastReflog(name);
  871. if (e != null) {
  872. result.put(name, e);
  873. }
  874. }
  875. return result;
  876. }
  877. private ReflogEntry getLastReflog(String name) throws IOException {
  878. ReflogReader r = diskRepo.getReflogReader(name);
  879. if (r == null) {
  880. return null;
  881. }
  882. return r.getLastEntry();
  883. }
  884. private File getLockFile(String refName) {
  885. return LockFile.getLockFile(refdir.fileFor(refName));
  886. }
  887. private void assertReflogUnchanged(
  888. Map<String, ReflogEntry> old, String name) throws IOException {
  889. assertReflogEquals(old.get(name), getLastReflog(name), true);
  890. }
  891. private static void assertReflogEquals(
  892. ReflogEntry expected, ReflogEntry actual) {
  893. assertReflogEquals(expected, actual, false);
  894. }
  895. private static void assertReflogEquals(
  896. ReflogEntry expected, ReflogEntry actual, boolean strictTime) {
  897. if (expected == null) {
  898. assertNull(actual);
  899. return;
  900. }
  901. assertNotNull(actual);
  902. assertEquals(expected.getOldId(), actual.getOldId());
  903. assertEquals(expected.getNewId(), actual.getNewId());
  904. if (strictTime) {
  905. assertEquals(expected.getWho(), actual.getWho());
  906. } else {
  907. assertEquals(expected.getWho().getName(), actual.getWho().getName());
  908. assertEquals(
  909. expected.getWho().getEmailAddress(),
  910. actual.getWho().getEmailAddress());
  911. }
  912. assertEquals(expected.getComment(), actual.getComment());
  913. }
  914. private static ReflogEntry reflog(ObjectId oldId, ObjectId newId,
  915. PersonIdent who, String comment) {
  916. return new ReflogEntry() {
  917. @Override
  918. public ObjectId getOldId() {
  919. return oldId;
  920. }
  921. @Override
  922. public ObjectId getNewId() {
  923. return newId;
  924. }
  925. @Override
  926. public PersonIdent getWho() {
  927. return who;
  928. }
  929. @Override
  930. public String getComment() {
  931. return comment;
  932. }
  933. @Override
  934. public CheckoutEntry parseCheckout() {
  935. throw new UnsupportedOperationException();
  936. }
  937. };
  938. }
  939. }