mirrors/jgit - jgit - source @ dussan.org

Verlauf

Terry Parker dbd05433ec Move reachability checker generation into the ObjectReader object Reachability checkers are retrieved from RevWalk and ObjectWalk objects: * RevWalk.createReachabilityChecker() * ObjectWalk.createObjectReachabilityChecker() Since RevWalks and ObjectWalks are themselves directly instantiated in hundreds of places (e.g. UploadPack...) overriding them in a consistent way requires overloading 100s of methods, which isn't feasible. Moving reachability checker generation to a more central place solves that problem. The ObjectReader object seems a good place from which to get reachability checkers, because reachability checkers return information about relationships between objects. ObjectDatabases delegate many operations to ObjectReaders, and reachability bitmaps are attached to ObjectReaders. The Bitmapped and Pedestrian reachability checker objects were package private in the org.eclipse.jgit.revwalk package. This change makes them public and moves them to the org.eclipse.jgit.internal.revwalk package. Corresponding tests are also moved. Motivation: 1) Reachability checking algorithms need to scale. One of the internal Android repositories has ~2.4 million refs/changes/* references, causing bad long tail performance in reachability checks. 2) Reachability check performance is impacted by repository topography: number of refs, number of objects, amounts of related vs. unrelated history. 3) Reachability check performance is also affected by per-branch access (Gerrit branch permissions) since different users can see different branches. 4) Reachability check performance isn't affected by any state in a RevWalk or ObjectWalk. I don't yet know if a single algorithm will work for all cases in #2 and #3. We may need to evolve the ReachabilityChecker interfaces over time to solve the Gerrit branch permissions case, or use Gerrit-specific identity information to solve that in an efficient way. This change takes the existing public API and moves it to the ObjectReader/whole repository level, which is where we can do consistent customizations for #2 and #3. We intend to upstream the best of whatever works, but anticipate the need for multiple rounds of experimentation. Change-Id: I9185feff43551fb387957c436112d5250486833d Signed-off-by: Terry Parker <tparker@google.com>		vor 3 Jahren
..
BitmappedObjectReachabilityTest.java	Move reachability checker generation into the ObjectReader object	vor 3 Jahren
BitmappedReachabilityCheckerTest.java	Move reachability checker generation into the ObjectReader object	vor 3 Jahren
ObjectReachabilityTestCase.java	Move reachability checker generation into the ObjectReader object	vor 3 Jahren
PedestrianObjectReachabilityTest.java	Move reachability checker generation into the ObjectReader object	vor 3 Jahren
PedestrianReachabilityCheckerTest.java	Move reachability checker generation into the ObjectReader object	vor 3 Jahren
ReachabilityCheckerTestCase.java	Move reachability checker generation into the ObjectReader object	vor 3 Jahren