Browse Source

Use `file_exists` to verify that config file exists

There might be the case that `fopen($file, 'r')` returns false and thus ownCloud might believe that the config file is empty and thus potentially leading to an overwrite of the config file.

This changeset introduces `file_exists` again which was used in ownCloud 5 where no such problems where reported and should not be affected by such problems.

Ref https://github.com/owncloud/core/issues/12785#issuecomment-71548720
tags/v8.0.0RC1
Lukas Reschke 9 years ago
parent
commit
17f2cfbb9c
1 changed files with 3 additions and 1 deletions
  1. 3
    1
      lib/private/config.php

+ 3
- 1
lib/private/config.php View File

@@ -166,7 +166,9 @@ class Config {
// Include file and merge config
foreach ($configFiles as $file) {
$filePointer = @fopen($file, 'r');
if($file === $this->configFilePath && $filePointer === false) {
if($file === $this->configFilePath &&
$filePointer === false &&
@!file_exists($this->configFilePath)) {
// Opening the main config might not be possible, e.g. if the wrong
// permissions are set (likely on a new installation)
continue;

Loading…
Cancel
Save