Browse Source

Show max warning comment lenth again

Fixes #7414

Since we no longer use an input field we have to use text instead of
val.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
tags/v13.0.0beta4
Roeland Jago Douma 6 years ago
parent
commit
4c0c3c0bef
No account linked to committer's email address

+ 1
- 1
apps/comments/js/commentstabview.js View File

@@ -512,7 +512,7 @@

_onTypeComment: function(ev) {
var $field = $(ev.target);
var len = $field.val().length;
var len = $field.text().length;
var $submitButton = $field.data('submitButtonEl');
if (!$submitButton) {
$submitButton = $field.closest('form').find('.submit');

+ 2
- 2
apps/comments/tests/js/commentstabviewSpec.js View File

@@ -411,7 +411,7 @@ describe('OCA.Comments.CommentsTabView tests', function() {
expect($message.hasClass('error')).toEqual(false);
});
it('displays tooltip when limit is almost reached', function() {
$message.val(createMessageWithLength(view._commentMaxLength - 2));
$message.text(createMessageWithLength(view._commentMaxLength - 2));
$message.trigger('change');

expect(tooltipStub.calledWith('show')).toEqual(true);
@@ -419,7 +419,7 @@ describe('OCA.Comments.CommentsTabView tests', function() {
expect($message.hasClass('error')).toEqual(false);
});
it('displays tooltip and disabled button when limit is exceeded', function() {
$message.val(createMessageWithLength(view._commentMaxLength + 2));
$message.text(createMessageWithLength(view._commentMaxLength + 2));
$message.trigger('change');

expect(tooltipStub.calledWith('show')).toEqual(true);

Loading…
Cancel
Save