Browse Source

MP3 without cover don't get a preview

* Fixes #2739

It tries to create an image from an SVG file. Which we don't support. So
this fails and prints an log line. Then we fall back anyways to the 404
and fetch the default icon.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
tags/v12.0.0beta1
Roeland Jago Douma 7 years ago
parent
commit
53640bbc47
No account linked to committer's email address
1 changed files with 1 additions and 19 deletions
  1. 1
    19
      lib/private/Preview/MP3.php

+ 1
- 19
lib/private/Preview/MP3.php View File

@@ -61,24 +61,6 @@ class MP3 extends Provider {
}
}

return $this->getNoCoverThumbnail();
return false;
}

/**
* Generates a default image when the file has no cover
*
* @return bool|\OCP\IImage false if the default image is missing or invalid
*/
private function getNoCoverThumbnail() {
$icon = \OC::$SERVERROOT . '/core/img/filetypes/audio.svg';

if(!file_exists($icon)) {
return false;
}

$image = new \OC_Image();
$image->loadFromFile($icon);
return $image->valid() ? $image : false;
}

}

Loading…
Cancel
Save