Browse Source

Don't send executionContexts for Clear-Site-Data

There are plans to remove executionContexts from the spec: https://github.com/w3c/webappsec-clear-site-data/issues/59

Firefox already removed it https://bugzilla.mozilla.org/show_bug.cgi?id=1548034

Chromium implementation is not finish: https://bugs.chromium.org/p/chromium/issues/detail?id=898503&q=clear-site-data&sort=-modified&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
tags/v17.0.0beta1
Daniel Kesselberg 5 years ago
parent
commit
6235a66aac
No account linked to committer's email address

+ 1
- 1
core/Controller/LoginController.php View File

@@ -128,7 +128,7 @@ class LoginController extends Controller {

$this->session->set('clearingExecutionContexts', '1');
$this->session->close();
$response->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
$response->addHeader('Clear-Site-Data', '"cache", "storage"');
return $response;
}


+ 2
- 2
tests/Core/Controller/LoginControllerTest.php View File

@@ -138,7 +138,7 @@ class LoginControllerTest extends TestCase {
->willReturn('/login');

$expected = new RedirectResponse('/login');
$expected->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
$expected->addHeader('Clear-Site-Data', '"cache", "storage"');
$this->assertEquals($expected, $this->loginController->logout());
}

@@ -168,7 +168,7 @@ class LoginControllerTest extends TestCase {
->willReturn('/login');

$expected = new RedirectResponse('/login');
$expected->addHeader('Clear-Site-Data', '"cache", "storage", "executionContexts"');
$expected->addHeader('Clear-Site-Data', '"cache", "storage"');
$this->assertEquals($expected, $this->loginController->logout());
}


Loading…
Cancel
Save