Fix master testing and update eslint-config (#17367)

Fix master testing and update eslint-config

.drone.yml

@@ -27,15 +27,16 @@ kind: pipeline
 name: webpack-build
 
 steps:
-- name: submodules
-  image: docker:git
-  commands:
-    - git submodule update --init
-- name: webpack-build
+- name: build
   image: nextcloudci/node:node-4
   commands:
+    - cd /drone/src
     - npm ci
     - npm run build
+- name: changes
+  image: nextcloudci/node:node-4
+  commands:
+    - cd /drone/src
     - git status
     - bash -c "[[ ! \"`git status --porcelain `\" ]] || ( echo 'Uncommited changes in webpack build' && exit 1 )"
 

apps/workflowengine/css/multiselect.css

@@ -0,0 +1,12 @@
+#workflowengine .multiselect .multiselect__single {
+	display: flex;
+}
+
+#workflowengine .option__icon {
+	min-width: 25px;
+}
+
+#workflowengine input,
+#workflowengine .multiselect {
+	width: 100%;
+}

apps/workflowengine/src/components/Checks/FileMimeType.vue

@@ -1,3 +1,25 @@
+<!--
+  - @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
+  -
+  - @author Julius Härtl <jus@bitgrid.net>
+  -
+  - @license GNU AGPL version 3 or any later version
+  -
+  - This program is free software: you can redistribute it and/or modify
+  - it under the terms of the GNU Affero General Public License as
+  - published by the Free Software Foundation, either version 3 of the
+  - License, or (at your option) any later version.
+  -
+  - This program is distributed in the hope that it will be useful,
+  - but WITHOUT ANY WARRANTY; without even the implied warranty of
+  - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+  - GNU Affero General Public License for more details.
+  -
+  - You should have received a copy of the GNU Affero General Public License
+  - along with this program. If not, see <http://www.gnu.org/licenses/>.
+  -
+  -->
+
 <template>
 	<div>
 		<Multiselect
@@ -108,5 +130,3 @@ export default {
 	}
 }
 </script>
-
-<style scoped src="./../../css/multiselect.css"></style>

apps/workflowengine/src/components/Checks/MultiselectTag/MultiselectTag.vue

@@ -56,6 +56,7 @@ export default {
 			required: true
 		},
 		value: {
+			type: Array,
 			default() {
 				return []
 			}

apps/workflowengine/src/components/Checks/MultiselectTag/api.js

@@ -1,3 +1,25 @@
+/**
+ * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
+ *
+ * @author Julius Härtl <jus@bitgrid.net>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
 import axios from 'nextcloud-axios'
 import { generateRemoteUrl } from 'nextcloud-router'
 

apps/workflowengine/src/components/Checks/MultiselectTag/index.js

@@ -1,3 +1,25 @@
+/**
+ * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
+ *
+ * @author Julius Härtl <jus@bitgrid.net>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
 import MultiselectTag from './MultiselectTag'
 
 export default MultiselectTag

apps/workflowengine/src/components/Checks/RequestURL.vue

@@ -137,5 +137,3 @@ export default {
 	}
 }
 </script>
-
-<style scoped src="./../../css/multiselect.css"></style>

apps/workflowengine/src/components/Checks/RequestUserAgent.vue

@@ -133,5 +133,3 @@ export default {
 	}
 }
 </script>
-
-<style scoped src="./../../css/multiselect.css"></style>

apps/workflowengine/src/components/Checks/RequestUserGroup.vue

@@ -75,5 +75,3 @@ export default {
 	}
 }
 </script>
-
-<style scoped src="./../../css/multiselect.css"></style>

apps/workflowengine/src/components/Checks/file.js

@@ -1,4 +1,4 @@
-/*
+/**
  * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
  *
  * @author Julius Härtl <jus@bitgrid.net>

apps/workflowengine/src/components/Checks/index.js

@@ -1,4 +1,4 @@
-/*
+/**
  * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
  *
  * @author Julius Härtl <jus@bitgrid.net>

apps/workflowengine/src/components/Checks/request.js

@@ -1,4 +1,4 @@
-/*
+/**
  * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
  *
  * @author Julius Härtl <jus@bitgrid.net>

apps/workflowengine/src/css/multiselect.css

@@ -1,11 +0,0 @@
-.multiselect::v-deep .multiselect__single {
-	display: flex;
-}
-
-.option__icon {
-	min-width: 25px;
-}
-
-input, .multiselect {
-	width: 100%;
-}

apps/workflowengine/src/helpers/api.js

@@ -1,4 +1,4 @@
-/*
+/**
  * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
  *
  * @author Julius Härtl <jus@bitgrid.net>

apps/workflowengine/src/helpers/validators.js

@@ -1,4 +1,4 @@
-/*
+/**
  * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
  *
  * @author Julius Härtl <jus@bitgrid.net>

apps/workflowengine/src/mixins/valueMixin.js

@@ -1,4 +1,4 @@
-/*
+/**
  * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
  *
  * @author Julius Härtl <jus@bitgrid.net>

apps/workflowengine/src/workflowengine.js

@@ -1,3 +1,25 @@
+/**
+ * @copyright Copyright (c) 2019 Julius Härtl <jus@bitgrid.net>
+ *
+ * @author Julius Härtl <jus@bitgrid.net>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+
 import Vue from 'vue'
 import Vuex from 'vuex'
 import store from './store'
@@ -65,6 +87,7 @@ Vue.use(Vuex)
 Vue.prototype.t = t
 
 const View = Vue.extend(Settings)
-new View({
+const workflowengine = new View({
 	store
-}).$mount('#workflowengine')
+})
+workflowengine.$mount('#workflowengine')

apps/workflowengine/templates/settings.php

@@ -18,8 +18,10 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  *
  */
+use OCA\WorkflowEngine\AppInfo\Application;
+style(Application::APP_ID, 'multiselect');
 
 /** @var array $_ */
 /** @var \OCP\IL10N $l */
 ?>
-<div id="<?php p(\OCA\WorkflowEngine\AppInfo\Application::APP_ID); ?>"></div>
+<div id="<?php p(Application::APP_ID); ?>"></div>

build/files-checker.php

@@ -25,6 +25,7 @@ $expectedFiles = [
 	'.babelrc',
 	'.codecov.yml',
 	'.drone.yml',
+	'.eslintrc.js',
 	'.git',
 	'.gitattributes',
 	'.github',
@@ -52,8 +53,8 @@ $expectedFiles = [
 	'config',
 	'console.php',
 	'contribute',
-	'COPYING',
 	'COPYING-README',
+	'COPYING',
 	'core',
 	'cron.php',
 	'index.html',
@@ -61,11 +62,11 @@ $expectedFiles = [
 	'lib',
 	'Makefile',
 	'occ',
-	'ocs',
-	'ocs-provider',
 	'ocm-provider',
-	'package.json',
+	'ocs-provider',
+	'ocs',
 	'package-lock.json',
+	'package.json',
 	'public.php',
 	'README.md',
 	'remote.php',

core/js/dist/login.js

@@ -103,7 +103,7 @@ function(e){var t,n,r,a,i,s,o,u,d,l,c,f,m,_,h,p,y,v,g,M="sizzle"+1*new Date,L=e.
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-function ae(e){for(var t,n=[],r=0,a=-1,i=0;r<e.length;){t=e.charAt(r);var s=!i&&"."===t||t>="0"&&t<="9";s!==i&&(n[++a]="",i=s),n[a]+=t,r++}return n}var ie={History:{_handlers:[],_pushState:function(e,t,n){var r;if(r="string"==typeof e?e:ce.buildQueryString(e),window.history.pushState){if(t=t||location.pathname+"?"+r,navigator.userAgent.toLowerCase().indexOf("firefox")>-1&&parseInt(navigator.userAgent.split("/").pop())<51)for(var a,i=document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]'),s=0,o=i.length;s<o;s++){var u=a.style,d=u.fill,l=u.stroke;(a=i[s]).style.fill=d,a.style.stroke=l,a.removeAttribute("filter"),a.setAttribute("filter","url(#invert)")}n?window.history.replaceState(e,"",t):window.history.pushState(e,"",t)}else window.location.hash="?"+r,this._cancelPop=!0},pushState:function(e,t){this._pushState(e,t,!1)},replaceState:function(e,t){this._pushState(e,t,!0)},addOnPopStateHandler:function(e){this._handlers.push(e)},_parseHashQuery:function(){var e=window.location.hash,t=e.indexOf("?");return t>=0?e.substr(t+1):e.length?e.substr(1):""},_decodeQuery:function(e){return e.replace(/\+/g," ")},parseUrlQuery:function(){var e,t=this._parseHashQuery();return t&&(e=ce.parseQueryString(this._decodeQuery(t))),(e=l.a.extend(e||{},ce.parseQueryString(this._decodeQuery(location.search))))||{}},_onPopState:function(e){var t;if(this._cancelPop)this._cancelPop=!1;else if(this._handlers.length){t=e&&e.state,l.a.isString(t)?t=ce.parseQueryString(t):t||(t=this.parseUrlQuery()||{});for(var n=0;n<this._handlers.length;n++)this._handlers[n](t)}}},humanFileSize:a(47).a,computerFileSize:function(e){if("string"!=typeof e)return null;var t=e.toLowerCase().trim(),n=null,r=t.match(/^[\s+]?([0-9]*)(\.([0-9]+))?( +)?([kmgtp]?b?)$/i);return null===r?null:(n=parseFloat(t),isFinite(n)?(r[5]&&(n*={b:1,k:1024,kb:1024,mb:1048576,m:1048576,gb:1073741824,g:1073741824,tb:1099511627776,t:1099511627776,pb:0x4000000000000,p:0x4000000000000}[r[5]]),n=Math.round(n)):null)},formatDate:function(e,t){return t=t||"LLL",re()(e).format(t)},relativeModifiedDate:function(e){var n=re()().diff(re()(e));return n>=0&&n<45e3?t("core","seconds ago"):re()(e).fromNow()},isIE:function(){return s()("html").hasClass("ie")},getScrollBarWidth:function(){if(this._scrollBarWidth)return this._scrollBarWidth;var e=document.createElement("p");e.style.width="100%",e.style.height="200px";var t=document.createElement("div");t.style.position="absolute",t.style.top="0px",t.style.left="0px",t.style.visibility="hidden",t.style.width="200px",t.style.height="150px",t.style.overflow="hidden",t.appendChild(e),document.body.appendChild(t);var n=e.offsetWidth;t.style.overflow="scroll";var r=e.offsetWidth;return n===r&&(r=t.clientWidth),document.body.removeChild(t),this._scrollBarWidth=n-r,this._scrollBarWidth},stripTime:function(e){return new Date(e.getFullYear(),e.getMonth(),e.getDate())},naturalSortCompare:function(e,t){var n,r=ae(e),a=ae(t);for(n=0;r[n]&&a[n];n++)if(r[n]!==a[n]){var i=Number(r[n]),s=Number(a[n]);return i==r[n]&&s==a[n]?i-s:r[n].localeCompare(a[n],ce.getLanguage())}return r.length-a.length},waitFor:function(e,t){!function n(){!0!==e()&&setTimeout(n,t)}()},isCookieSetToValue:function(e,t){for(var n=document.cookie.split(";"),r=0;r<n.length;r++){var a=n[r].split("=");if(a[0].trim()===e&&a[1].trim()===t)return!0}return!1}},se=window._oc_debug,oe=window._oc_webroot;
+function ae(e){for(var t,n=[],r=0,a=-1,i=0;r<e.length;){t=e.charAt(r);var s=!i&&"."===t||t>="0"&&t<="9";s!==i&&(n[++a]="",i=s),n[a]+=t,r++}return n}var ie={History:{_handlers:[],_pushState:function(e,t,n){var r;if(r="string"==typeof e?e:ce.buildQueryString(e),window.history.pushState){if(t=t||location.pathname+"?"+r,navigator.userAgent.toLowerCase().indexOf("firefox")>-1&&parseInt(navigator.userAgent.split("/").pop())<51)for(var a,i=document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]'),s=0,o=i.length;s<o;s++)(a=i[s]).style.fill=a.style.fill,a.style.stroke=a.style.stroke,a.removeAttribute("filter"),a.setAttribute("filter","url(#invert)");n?window.history.replaceState(e,"",t):window.history.pushState(e,"",t)}else window.location.hash="?"+r,this._cancelPop=!0},pushState:function(e,t){this._pushState(e,t,!1)},replaceState:function(e,t){this._pushState(e,t,!0)},addOnPopStateHandler:function(e){this._handlers.push(e)},_parseHashQuery:function(){var e=window.location.hash,t=e.indexOf("?");return t>=0?e.substr(t+1):e.length?e.substr(1):""},_decodeQuery:function(e){return e.replace(/\+/g," ")},parseUrlQuery:function(){var e,t=this._parseHashQuery();return t&&(e=ce.parseQueryString(this._decodeQuery(t))),(e=l.a.extend(e||{},ce.parseQueryString(this._decodeQuery(location.search))))||{}},_onPopState:function(e){var t;if(this._cancelPop)this._cancelPop=!1;else if(this._handlers.length){t=e&&e.state,l.a.isString(t)?t=ce.parseQueryString(t):t||(t=this.parseUrlQuery()||{});for(var n=0;n<this._handlers.length;n++)this._handlers[n](t)}}},humanFileSize:a(47).a,computerFileSize:function(e){if("string"!=typeof e)return null;var t=e.toLowerCase().trim(),n=null,r=t.match(/^[\s+]?([0-9]*)(\.([0-9]+))?( +)?([kmgtp]?b?)$/i);return null===r?null:(n=parseFloat(t),isFinite(n)?(r[5]&&(n*={b:1,k:1024,kb:1024,mb:1048576,m:1048576,gb:1073741824,g:1073741824,tb:1099511627776,t:1099511627776,pb:0x4000000000000,p:0x4000000000000}[r[5]]),n=Math.round(n)):null)},formatDate:function(e,t){return t=t||"LLL",re()(e).format(t)},relativeModifiedDate:function(e){var n=re()().diff(re()(e));return n>=0&&n<45e3?t("core","seconds ago"):re()(e).fromNow()},isIE:function(){return s()("html").hasClass("ie")},getScrollBarWidth:function(){if(this._scrollBarWidth)return this._scrollBarWidth;var e=document.createElement("p");e.style.width="100%",e.style.height="200px";var t=document.createElement("div");t.style.position="absolute",t.style.top="0px",t.style.left="0px",t.style.visibility="hidden",t.style.width="200px",t.style.height="150px",t.style.overflow="hidden",t.appendChild(e),document.body.appendChild(t);var n=e.offsetWidth;t.style.overflow="scroll";var r=e.offsetWidth;return n===r&&(r=t.clientWidth),document.body.removeChild(t),this._scrollBarWidth=n-r,this._scrollBarWidth},stripTime:function(e){return new Date(e.getFullYear(),e.getMonth(),e.getDate())},naturalSortCompare:function(e,t){var n,r=ae(e),a=ae(t);for(n=0;r[n]&&a[n];n++)if(r[n]!==a[n]){var i=Number(r[n]),s=Number(a[n]);return i==r[n]&&s==a[n]?i-s:r[n].localeCompare(a[n],ce.getLanguage())}return r.length-a.length},waitFor:function(e,t){!function n(){!0!==e()&&setTimeout(n,t)}()},isCookieSetToValue:function(e,t){for(var n=document.cookie.split(";"),r=0;r<n.length;r++){var a=n[r].split("=");if(a[0].trim()===e&&a[1].trim()===t)return!0}return!1}},se=window._oc_debug,oe=window._oc_webroot;
 /*
  * @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
  *

core/js/dist/main.js

@@ -103,7 +103,7 @@ function(e){var t,n,i,r,s,o,a,l,c,u,d,h,p,f,m,g,_,v,y,b="sizzle"+1*new Date,w=e.
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-function re(e){for(var t,n=[],i=0,r=-1,s=0;i<e.length;){t=e.charAt(i);var o=!s&&"."===t||t>="0"&&t<="9";o!==s&&(n[++r]="",s=o),n[r]+=t,i++}return n}var se={History:{_handlers:[],_pushState:function(e,t,n){var i;if(i="string"==typeof e?e:de.buildQueryString(e),window.history.pushState){if(t=t||location.pathname+"?"+i,navigator.userAgent.toLowerCase().indexOf("firefox")>-1&&parseInt(navigator.userAgent.split("/").pop())<51)for(var r,s=document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]'),o=0,a=s.length;o<a;o++){var l=r.style,c=l.fill,u=l.stroke;(r=s[o]).style.fill=c,r.style.stroke=u,r.removeAttribute("filter"),r.setAttribute("filter","url(#invert)")}n?window.history.replaceState(e,"",t):window.history.pushState(e,"",t)}else window.location.hash="?"+i,this._cancelPop=!0},pushState:function(e,t){this._pushState(e,t,!1)},replaceState:function(e,t){this._pushState(e,t,!0)},addOnPopStateHandler:function(e){this._handlers.push(e)},_parseHashQuery:function(){var e=window.location.hash,t=e.indexOf("?");return t>=0?e.substr(t+1):e.length?e.substr(1):""},_decodeQuery:function(e){return e.replace(/\+/g," ")},parseUrlQuery:function(){var e,t=this._parseHashQuery();return t&&(e=de.parseQueryString(this._decodeQuery(t))),(e=u.a.extend(e||{},de.parseQueryString(this._decodeQuery(location.search))))||{}},_onPopState:function(e){var t;if(this._cancelPop)this._cancelPop=!1;else if(this._handlers.length){t=e&&e.state,u.a.isString(t)?t=de.parseQueryString(t):t||(t=this.parseUrlQuery()||{});for(var n=0;n<this._handlers.length;n++)this._handlers[n](t)}}},humanFileSize:r(47).a,computerFileSize:function(e){if("string"!=typeof e)return null;var t=e.toLowerCase().trim(),n=null,i=t.match(/^[\s+]?([0-9]*)(\.([0-9]+))?( +)?([kmgtp]?b?)$/i);return null===i?null:(n=parseFloat(t),isFinite(n)?(i[5]&&(n*={b:1,k:1024,kb:1024,mb:1048576,m:1048576,gb:1073741824,g:1073741824,tb:1099511627776,t:1099511627776,pb:0x4000000000000,p:0x4000000000000}[i[5]]),n=Math.round(n)):null)},formatDate:function(e,t){return t=t||"LLL",ie()(e).format(t)},relativeModifiedDate:function(e){var n=ie()().diff(ie()(e));return n>=0&&n<45e3?t("core","seconds ago"):ie()(e).fromNow()},isIE:function(){return o()("html").hasClass("ie")},getScrollBarWidth:function(){if(this._scrollBarWidth)return this._scrollBarWidth;var e=document.createElement("p");e.style.width="100%",e.style.height="200px";var t=document.createElement("div");t.style.position="absolute",t.style.top="0px",t.style.left="0px",t.style.visibility="hidden",t.style.width="200px",t.style.height="150px",t.style.overflow="hidden",t.appendChild(e),document.body.appendChild(t);var n=e.offsetWidth;t.style.overflow="scroll";var i=e.offsetWidth;return n===i&&(i=t.clientWidth),document.body.removeChild(t),this._scrollBarWidth=n-i,this._scrollBarWidth},stripTime:function(e){return new Date(e.getFullYear(),e.getMonth(),e.getDate())},naturalSortCompare:function(e,t){var n,i=re(e),r=re(t);for(n=0;i[n]&&r[n];n++)if(i[n]!==r[n]){var s=Number(i[n]),o=Number(r[n]);return s==i[n]&&o==r[n]?s-o:i[n].localeCompare(r[n],de.getLanguage())}return i.length-r.length},waitFor:function(e,t){!function n(){!0!==e()&&setTimeout(n,t)}()},isCookieSetToValue:function(e,t){for(var n=document.cookie.split(";"),i=0;i<n.length;i++){var r=n[i].split("=");if(r[0].trim()===e&&r[1].trim()===t)return!0}return!1}},oe=window._oc_debug,ae=window._oc_webroot;
+function re(e){for(var t,n=[],i=0,r=-1,s=0;i<e.length;){t=e.charAt(i);var o=!s&&"."===t||t>="0"&&t<="9";o!==s&&(n[++r]="",s=o),n[r]+=t,i++}return n}var se={History:{_handlers:[],_pushState:function(e,t,n){var i;if(i="string"==typeof e?e:de.buildQueryString(e),window.history.pushState){if(t=t||location.pathname+"?"+i,navigator.userAgent.toLowerCase().indexOf("firefox")>-1&&parseInt(navigator.userAgent.split("/").pop())<51)for(var r,s=document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]'),o=0,a=s.length;o<a;o++)(r=s[o]).style.fill=r.style.fill,r.style.stroke=r.style.stroke,r.removeAttribute("filter"),r.setAttribute("filter","url(#invert)");n?window.history.replaceState(e,"",t):window.history.pushState(e,"",t)}else window.location.hash="?"+i,this._cancelPop=!0},pushState:function(e,t){this._pushState(e,t,!1)},replaceState:function(e,t){this._pushState(e,t,!0)},addOnPopStateHandler:function(e){this._handlers.push(e)},_parseHashQuery:function(){var e=window.location.hash,t=e.indexOf("?");return t>=0?e.substr(t+1):e.length?e.substr(1):""},_decodeQuery:function(e){return e.replace(/\+/g," ")},parseUrlQuery:function(){var e,t=this._parseHashQuery();return t&&(e=de.parseQueryString(this._decodeQuery(t))),(e=u.a.extend(e||{},de.parseQueryString(this._decodeQuery(location.search))))||{}},_onPopState:function(e){var t;if(this._cancelPop)this._cancelPop=!1;else if(this._handlers.length){t=e&&e.state,u.a.isString(t)?t=de.parseQueryString(t):t||(t=this.parseUrlQuery()||{});for(var n=0;n<this._handlers.length;n++)this._handlers[n](t)}}},humanFileSize:r(47).a,computerFileSize:function(e){if("string"!=typeof e)return null;var t=e.toLowerCase().trim(),n=null,i=t.match(/^[\s+]?([0-9]*)(\.([0-9]+))?( +)?([kmgtp]?b?)$/i);return null===i?null:(n=parseFloat(t),isFinite(n)?(i[5]&&(n*={b:1,k:1024,kb:1024,mb:1048576,m:1048576,gb:1073741824,g:1073741824,tb:1099511627776,t:1099511627776,pb:0x4000000000000,p:0x4000000000000}[i[5]]),n=Math.round(n)):null)},formatDate:function(e,t){return t=t||"LLL",ie()(e).format(t)},relativeModifiedDate:function(e){var n=ie()().diff(ie()(e));return n>=0&&n<45e3?t("core","seconds ago"):ie()(e).fromNow()},isIE:function(){return o()("html").hasClass("ie")},getScrollBarWidth:function(){if(this._scrollBarWidth)return this._scrollBarWidth;var e=document.createElement("p");e.style.width="100%",e.style.height="200px";var t=document.createElement("div");t.style.position="absolute",t.style.top="0px",t.style.left="0px",t.style.visibility="hidden",t.style.width="200px",t.style.height="150px",t.style.overflow="hidden",t.appendChild(e),document.body.appendChild(t);var n=e.offsetWidth;t.style.overflow="scroll";var i=e.offsetWidth;return n===i&&(i=t.clientWidth),document.body.removeChild(t),this._scrollBarWidth=n-i,this._scrollBarWidth},stripTime:function(e){return new Date(e.getFullYear(),e.getMonth(),e.getDate())},naturalSortCompare:function(e,t){var n,i=re(e),r=re(t);for(n=0;i[n]&&r[n];n++)if(i[n]!==r[n]){var s=Number(i[n]),o=Number(r[n]);return s==i[n]&&o==r[n]?s-o:i[n].localeCompare(r[n],de.getLanguage())}return i.length-r.length},waitFor:function(e,t){!function n(){!0!==e()&&setTimeout(n,t)}()},isCookieSetToValue:function(e,t){for(var n=document.cookie.split(";"),i=0;i<n.length;i++){var r=n[i].split("=");if(r[0].trim()===e&&r[1].trim()===t)return!0}return!1}},oe=window._oc_debug,ae=window._oc_webroot;
 /*
  * @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
  *

core/js/dist/maintenance.js

@@ -103,7 +103,7 @@ function(e){var t,n,a,r,i,s,o,d,u,l,c,_,m,h,f,p,y,M,g,L="sizzle"+1*new Date,v=e.
  * You should have received a copy of the GNU Affero General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
-function re(e){for(var t,n=[],a=0,r=-1,i=0;a<e.length;){t=e.charAt(a);var s=!i&&"."===t||t>="0"&&t<="9";s!==i&&(n[++r]="",i=s),n[r]+=t,a++}return n}var ie={History:{_handlers:[],_pushState:function(e,t,n){var a;if(a="string"==typeof e?e:ce.buildQueryString(e),window.history.pushState){if(t=t||location.pathname+"?"+a,navigator.userAgent.toLowerCase().indexOf("firefox")>-1&&parseInt(navigator.userAgent.split("/").pop())<51)for(var r,i=document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]'),s=0,o=i.length;s<o;s++){var d=r.style,u=d.fill,l=d.stroke;(r=i[s]).style.fill=u,r.style.stroke=l,r.removeAttribute("filter"),r.setAttribute("filter","url(#invert)")}n?window.history.replaceState(e,"",t):window.history.pushState(e,"",t)}else window.location.hash="?"+a,this._cancelPop=!0},pushState:function(e,t){this._pushState(e,t,!1)},replaceState:function(e,t){this._pushState(e,t,!0)},addOnPopStateHandler:function(e){this._handlers.push(e)},_parseHashQuery:function(){var e=window.location.hash,t=e.indexOf("?");return t>=0?e.substr(t+1):e.length?e.substr(1):""},_decodeQuery:function(e){return e.replace(/\+/g," ")},parseUrlQuery:function(){var e,t=this._parseHashQuery();return t&&(e=ce.parseQueryString(this._decodeQuery(t))),(e=l.a.extend(e||{},ce.parseQueryString(this._decodeQuery(location.search))))||{}},_onPopState:function(e){var t;if(this._cancelPop)this._cancelPop=!1;else if(this._handlers.length){t=e&&e.state,l.a.isString(t)?t=ce.parseQueryString(t):t||(t=this.parseUrlQuery()||{});for(var n=0;n<this._handlers.length;n++)this._handlers[n](t)}}},humanFileSize:r(47).a,computerFileSize:function(e){if("string"!=typeof e)return null;var t=e.toLowerCase().trim(),n=null,a=t.match(/^[\s+]?([0-9]*)(\.([0-9]+))?( +)?([kmgtp]?b?)$/i);return null===a?null:(n=parseFloat(t),isFinite(n)?(a[5]&&(n*={b:1,k:1024,kb:1024,mb:1048576,m:1048576,gb:1073741824,g:1073741824,tb:1099511627776,t:1099511627776,pb:0x4000000000000,p:0x4000000000000}[a[5]]),n=Math.round(n)):null)},formatDate:function(e,t){return t=t||"LLL",ae()(e).format(t)},relativeModifiedDate:function(e){var n=ae()().diff(ae()(e));return n>=0&&n<45e3?t("core","seconds ago"):ae()(e).fromNow()},isIE:function(){return s()("html").hasClass("ie")},getScrollBarWidth:function(){if(this._scrollBarWidth)return this._scrollBarWidth;var e=document.createElement("p");e.style.width="100%",e.style.height="200px";var t=document.createElement("div");t.style.position="absolute",t.style.top="0px",t.style.left="0px",t.style.visibility="hidden",t.style.width="200px",t.style.height="150px",t.style.overflow="hidden",t.appendChild(e),document.body.appendChild(t);var n=e.offsetWidth;t.style.overflow="scroll";var a=e.offsetWidth;return n===a&&(a=t.clientWidth),document.body.removeChild(t),this._scrollBarWidth=n-a,this._scrollBarWidth},stripTime:function(e){return new Date(e.getFullYear(),e.getMonth(),e.getDate())},naturalSortCompare:function(e,t){var n,a=re(e),r=re(t);for(n=0;a[n]&&r[n];n++)if(a[n]!==r[n]){var i=Number(a[n]),s=Number(r[n]);return i==a[n]&&s==r[n]?i-s:a[n].localeCompare(r[n],ce.getLanguage())}return a.length-r.length},waitFor:function(e,t){!function n(){!0!==e()&&setTimeout(n,t)}()},isCookieSetToValue:function(e,t){for(var n=document.cookie.split(";"),a=0;a<n.length;a++){var r=n[a].split("=");if(r[0].trim()===e&&r[1].trim()===t)return!0}return!1}},se=window._oc_debug,oe=window._oc_webroot;
+function re(e){for(var t,n=[],a=0,r=-1,i=0;a<e.length;){t=e.charAt(a);var s=!i&&"."===t||t>="0"&&t<="9";s!==i&&(n[++r]="",i=s),n[r]+=t,a++}return n}var ie={History:{_handlers:[],_pushState:function(e,t,n){var a;if(a="string"==typeof e?e:ce.buildQueryString(e),window.history.pushState){if(t=t||location.pathname+"?"+a,navigator.userAgent.toLowerCase().indexOf("firefox")>-1&&parseInt(navigator.userAgent.split("/").pop())<51)for(var r,i=document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]'),s=0,o=i.length;s<o;s++)(r=i[s]).style.fill=r.style.fill,r.style.stroke=r.style.stroke,r.removeAttribute("filter"),r.setAttribute("filter","url(#invert)");n?window.history.replaceState(e,"",t):window.history.pushState(e,"",t)}else window.location.hash="?"+a,this._cancelPop=!0},pushState:function(e,t){this._pushState(e,t,!1)},replaceState:function(e,t){this._pushState(e,t,!0)},addOnPopStateHandler:function(e){this._handlers.push(e)},_parseHashQuery:function(){var e=window.location.hash,t=e.indexOf("?");return t>=0?e.substr(t+1):e.length?e.substr(1):""},_decodeQuery:function(e){return e.replace(/\+/g," ")},parseUrlQuery:function(){var e,t=this._parseHashQuery();return t&&(e=ce.parseQueryString(this._decodeQuery(t))),(e=l.a.extend(e||{},ce.parseQueryString(this._decodeQuery(location.search))))||{}},_onPopState:function(e){var t;if(this._cancelPop)this._cancelPop=!1;else if(this._handlers.length){t=e&&e.state,l.a.isString(t)?t=ce.parseQueryString(t):t||(t=this.parseUrlQuery()||{});for(var n=0;n<this._handlers.length;n++)this._handlers[n](t)}}},humanFileSize:r(47).a,computerFileSize:function(e){if("string"!=typeof e)return null;var t=e.toLowerCase().trim(),n=null,a=t.match(/^[\s+]?([0-9]*)(\.([0-9]+))?( +)?([kmgtp]?b?)$/i);return null===a?null:(n=parseFloat(t),isFinite(n)?(a[5]&&(n*={b:1,k:1024,kb:1024,mb:1048576,m:1048576,gb:1073741824,g:1073741824,tb:1099511627776,t:1099511627776,pb:0x4000000000000,p:0x4000000000000}[a[5]]),n=Math.round(n)):null)},formatDate:function(e,t){return t=t||"LLL",ae()(e).format(t)},relativeModifiedDate:function(e){var n=ae()().diff(ae()(e));return n>=0&&n<45e3?t("core","seconds ago"):ae()(e).fromNow()},isIE:function(){return s()("html").hasClass("ie")},getScrollBarWidth:function(){if(this._scrollBarWidth)return this._scrollBarWidth;var e=document.createElement("p");e.style.width="100%",e.style.height="200px";var t=document.createElement("div");t.style.position="absolute",t.style.top="0px",t.style.left="0px",t.style.visibility="hidden",t.style.width="200px",t.style.height="150px",t.style.overflow="hidden",t.appendChild(e),document.body.appendChild(t);var n=e.offsetWidth;t.style.overflow="scroll";var a=e.offsetWidth;return n===a&&(a=t.clientWidth),document.body.removeChild(t),this._scrollBarWidth=n-a,this._scrollBarWidth},stripTime:function(e){return new Date(e.getFullYear(),e.getMonth(),e.getDate())},naturalSortCompare:function(e,t){var n,a=re(e),r=re(t);for(n=0;a[n]&&r[n];n++)if(a[n]!==r[n]){var i=Number(a[n]),s=Number(r[n]);return i==a[n]&&s==r[n]?i-s:a[n].localeCompare(r[n],ce.getLanguage())}return a.length-r.length},waitFor:function(e,t){!function n(){!0!==e()&&setTimeout(n,t)}()},isCookieSetToValue:function(e,t){for(var n=document.cookie.split(";"),a=0;a<n.length;a++){var r=n[a].split("=");if(r[0].trim()===e&&r[1].trim()===t)return!0}return!1}},se=window._oc_debug,oe=window._oc_webroot;
 /*
  * @copyright 2019 Christoph Wurst <christoph@winzerhof-wurst.at>
  *

core/src/OC/util-history.js

@@ -61,10 +61,11 @@ export default {
 			if (isFirefox && parseInt(navigator.userAgent.split('/').pop()) < 51) {
 				var patterns = document.querySelectorAll('[fill^="url(#"], [stroke^="url(#"], [filter^="url(#invert"]')
 				for (var i = 0, ii = patterns.length, pattern; i < ii; i++) {
-					const { fill, stroke } = pattern.style
 					pattern = patterns[i]
-					pattern.style.fill = fill
-					pattern.style.stroke = stroke
+					// eslint-disable-next-line no-self-assign
+					pattern.style.fill = pattern.style.fill
+					// eslint-disable-next-line no-self-assign
+					pattern.style.stroke = pattern.style.stroke
 					pattern.removeAttribute('filter')
 					pattern.setAttribute('filter', 'url(#invert)')
 				}

package-lock.json

@@ -1450,6 +1450,31 @@
         }
       }
     },
+    "babel-eslint": {
+      "version": "10.0.3",
+      "resolved": "https://registry.npmjs.org/babel-eslint/-/babel-eslint-10.0.3.tgz",
+      "integrity": "sha512-z3U7eMY6r/3f3/JB9mTsLjyxrv0Yb1zb8PCWCLpguxfCzBIZUwy23R1t/XKewP+8mEN2Ck8Dtr4q20z6ce6SoA==",
+      "dev": true,
+      "requires": {
+        "@babel/code-frame": "^7.0.0",
+        "@babel/parser": "^7.0.0",
+        "@babel/traverse": "^7.0.0",
+        "@babel/types": "^7.0.0",
+        "eslint-visitor-keys": "^1.0.0",
+        "resolve": "^1.12.0"
+      },
+      "dependencies": {
+        "resolve": {
+          "version": "1.12.0",
+          "resolved": "https://registry.npmjs.org/resolve/-/resolve-1.12.0.tgz",
+          "integrity": "sha512-B/dOmuoAik5bKcD6s6nXDCjzUKnaDvdkRyAk6rsmsKLipWj4797iothd7jmmUhWTfinVMU+wc56rYKsit2Qy4w==",
+          "dev": true,
+          "requires": {
+            "path-parse": "^1.0.6"
+          }
+        }
+      }
+    },
     "babel-loader": {
       "version": "8.0.6",
       "resolved": "https://registry.npmjs.org/babel-loader/-/babel-loader-8.0.6.tgz",
@@ -3101,9 +3126,9 @@
       }
     },
     "eslint-config-nextcloud": {
-      "version": "0.0.5",
-      "resolved": "https://registry.npmjs.org/eslint-config-nextcloud/-/eslint-config-nextcloud-0.0.5.tgz",
-      "integrity": "sha512-innKCAJBpTTdEGriCQduV6XwDySdZ2uHD7PduaKbbSfL12a/eXU6/jcIDfxM3cFAgCN7sJYOSE4/TM9nygO8kQ==",
+      "version": "0.0.6",
+      "resolved": "https://registry.npmjs.org/eslint-config-nextcloud/-/eslint-config-nextcloud-0.0.6.tgz",
+      "integrity": "sha512-ktCzXVA8GrqZVljutkBKOq2hgKvzKyLhNCAB5bCjdmMo7DIky2ZYeMtDmiEUZCPoXbSJY0kyvnZPbcN4VYzyCg==",
       "dev": true
     },
     "eslint-config-standard": {

package.json

@@ -70,12 +70,13 @@
     "@babel/core": "^7.6.2",
     "@babel/plugin-syntax-dynamic-import": "^7.2.0",
     "@babel/preset-env": "^7.6.2",
+    "babel-eslint": "^10.0.3",
     "babel-loader": "^8.0.6",
     "babel-plugin-transform-es2015-arrow-functions": "^6.22.0",
     "browserslist-config-nextcloud": "0.0.1",
     "css-loader": "^3.2.0",
     "eslint": "^5.16.0",
-    "eslint-config-nextcloud": "0.0.5",
+    "eslint-config-nextcloud": "0.0.6",
     "eslint-config-standard": "^12.0.0",
     "eslint-loader": "^3.0.0",
     "eslint-plugin-import": "^2.18.2",

tests/acceptance/features/app-files-tags.feature

@@ -31,7 +31,7 @@ Feature: app-files-tags
   Scenario: create tags using the Administration settings
     Given I am logged in as the admin
     And I visit the settings page
-    And I open the "Tag management" section
+    And I open the "Workflows" section of the "Administration" group
     # The "create" button does nothing before JavaScript was initialized, and
     # the only way to detect that is waiting for the button to select tags to be
     # shown.
@@ -42,7 +42,7 @@ Feature: app-files-tags
 #  Scenario: add tags using the dropdown in the details view
 #    Given I am logged in as the admin
 #    And I visit the settings page
-#    And I open the "Tag management" section
+#    And I open the "Workflows" section of the "Administration" group
 #    # The "create" button does nothing before JavaScript was initialized, and
 #    # the only way to detect that is waiting for the button to select tags to be
 #    # shown.
@@ -70,7 +70,7 @@ Feature: app-files-tags
 #  Scenario: remove tags using the dropdown in the details view
 #    Given I am logged in as the admin
 #    And I visit the settings page
-#    And I open the "Tag management" section
+#    And I open the "Workflows" section of the "Administration" group
 #    # The "create" button does nothing before JavaScript was initialized, and
 #    # the only way to detect that is waiting for the button to select tags to be
 #    # shown.

tests/acceptance/features/bootstrap/AppNavigationContext.php

@@ -45,6 +45,15 @@ class AppNavigationContext implements Context, ActorAwareInterface {
 			describedAs($sectionText . " section item in App Navigation");
 	}
 
+	/**
+	 * @return Locator
+	 */
+	public static function appNavigationSectionItemInFor($caption, $sectionText) {
+		return Locator::forThe()->xpath("//li[normalize-space() = '$caption']/following-sibling::li/a[normalize-space() = '$sectionText']/..")->
+			descendantOf(self::appNavigation())->
+			describedAs($sectionText . " section item of the $caption group in App Navigation");
+	}
+
 	/**
 	 * @return Locator
 	 */
@@ -79,6 +88,13 @@ class AppNavigationContext implements Context, ActorAwareInterface {
 		$this->actor->find(self::appNavigationSectionItemFor($section), 10)->click();
 	}
 
+	/**
+	 * @Given I open the :section section of the :caption group
+	 */
+	public function iOpenTheSectionOf($caption, $section) {
+		$this->actor->find(self::appNavigationSectionItemInFor($caption, $section), 10)->click();
+	}
+
 	/**
 	 * @Given I click the :class button on the :section section
 	 */