Fix for #23066 (#24689)

apps/files_sharing/lib/Helper.php

@@ -126,7 +126,7 @@ class Helper {
 				$newHash = '';
 				if(\OC::$server->getHasher()->verify($password, $linkItem['share_with'], $newHash)) {
 					// Save item id in session for future requests
-					\OC::$server->getSession()->set('public_link_authenticated', $linkItem['id']);
+					\OC::$server->getSession()->set('public_link_authenticated', (string) $linkItem['id']);
 
 					/**
 					 * FIXME: Migrate old hashes to new hash format
@@ -156,7 +156,7 @@ class Helper {
 		else {
 			// not authenticated ?
 			if ( ! \OC::$server->getSession()->exists('public_link_authenticated')
-				|| \OC::$server->getSession()->get('public_link_authenticated') !== $linkItem['id']) {
+				|| \OC::$server->getSession()->get('public_link_authenticated') !== (string)$linkItem['id']) {
 				return false;
 			}
 		}

lib/private/Share/Share.php

@@ -2493,7 +2493,7 @@ class Share extends Constants {
 		}
 
 		if ( \OC::$server->getSession()->exists('public_link_authenticated')
-			&& \OC::$server->getSession()->get('public_link_authenticated') === $linkItem['id'] ) {
+			&& \OC::$server->getSession()->get('public_link_authenticated') === (string)$linkItem['id'] ) {
 			return true;
 		}
 

tests/lib/Share/ShareTest.php

@@ -990,7 +990,7 @@ class ShareTest extends \Test\TestCase {
 	 * @param $item
 	 */
 	public function testCheckPasswordProtectedShare($expected, $item) {
-		\OC::$server->getSession()->set('public_link_authenticated', 100);
+		\OC::$server->getSession()->set('public_link_authenticated', '100');
 		$result = \OCP\Share::checkPasswordProtectedShare($item);
 		$this->assertEquals($expected, $result);
 	}
@@ -1002,8 +1002,12 @@ class ShareTest extends \Test\TestCase {
 			array(true, array('share_with' => '')),
 			array(true, array('share_with' => '1234567890', 'share_type' => '1')),
 			array(true, array('share_with' => '1234567890', 'share_type' => 1)),
+			array(true, array('share_with' => '1234567890', 'share_type' => '3', 'id' => '100')),
+			array(true, array('share_with' => '1234567890', 'share_type' => 3, 'id' => '100')),
 			array(true, array('share_with' => '1234567890', 'share_type' => '3', 'id' => 100)),
 			array(true, array('share_with' => '1234567890', 'share_type' => 3, 'id' => 100)),
+			array(false, array('share_with' => '1234567890', 'share_type' => '3', 'id' => '101')),
+			array(false, array('share_with' => '1234567890', 'share_type' => 3, 'id' => '101')),
 			array(false, array('share_with' => '1234567890', 'share_type' => '3', 'id' => 101)),
 			array(false, array('share_with' => '1234567890', 'share_type' => 3, 'id' => 101)),
 		);