Browse Source

Disable JS plugin for sharing in public mode

This removes the logic that registers the share action and modifies the
rows. Share actions aren't needed in the public file list.
tags/v8.0.0RC1
Vincent Petry 9 years ago
parent
commit
86689ef400
2 changed files with 26 additions and 2 deletions
  1. 1
    1
      apps/files_sharing/js/share.js
  2. 25
    1
      apps/files_sharing/tests/js/shareSpec.js

+ 1
- 1
apps/files_sharing/js/share.js View File

@@ -25,7 +25,7 @@
* @param {OCA.Files.FileList} fileList file list to be extended
*/
attach: function(fileList) {
if (fileList.id === 'trashbin') {
if (fileList.id === 'trashbin' || fileList.id === 'files.public') {
return;
}
var fileActions = fileList.fileActions;

+ 25
- 1
apps/files_sharing/tests/js/shareSpec.js View File

@@ -27,7 +27,7 @@ describe('OCA.Sharing.Util tests', function() {
$('#testArea').append($content);
// dummy file list
var $div = $(
'<div>' +
'<div id="listContainer">' +
'<table id="filestable">' +
'<thead></thead>' +
'<tbody id="fileList"></tbody>' +
@@ -450,5 +450,29 @@ describe('OCA.Sharing.Util tests', function() {
.toEqual('User four, User one, User three, User two, +6');
});
});
describe('Excluded lists', function() {
function createListThenAttach(listId) {
var fileActions = new OCA.Files.FileActions();
fileList.destroy();
fileList = new OCA.Files.FileList(
$('#listContainer'), {
id: listId,
fileActions: fileActions
}
);
OCA.Sharing.Util.attach(fileList);
fileList.setFiles(testFiles);
return fileList;
}

it('does not attach to trashbin or public file lists', function() {
createListThenAttach('trashbin');
expect($('.action-share').length).toEqual(0);
expect($('[data-share-recipient]').length).toEqual(0);
createListThenAttach('files.public');
expect($('.action-share').length).toEqual(0);
expect($('[data-share-recipient]').length).toEqual(0);
});
});
});

Loading…
Cancel
Save