Mirrors/nextcloud
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2024-07-25 13:54:59 +02:00
Code Issues Actions 26 Packages Projects Releases Wiki Activity

Deduplicate code

Browse Source
This commit is contained in:
Lukas Reschke 2015-04-07 13:48:33 +02:00
parent 8e1a51731a
commit a2182cde90
1 changed files with 31 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

75
lib/private/ocsclient.php
View File

@ -80,6 +80,29 @@ class OCSClient {
return $this->config->getSystemValue('appstoreurl', 'https://api.owncloud.com/v1');
}
/**
* @param string $body
* @param string $action
* @return null|\SimpleXMLElement
*/
private function loadData($body, $action) {
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($body);
libxml_disable_entity_loader($loadEntities);
if($data === false) {
$this->logger->error(
sprintf('Could not get %s, content was no valid XML', $action),
[
'app' => 'core',
]
);
return null;
}
return $data;
}
/**
* Get all the categories from the OCS server
*
@ -110,17 +133,8 @@ class OCSClient {
return null;
}
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($response->getBody());
libxml_disable_entity_loader($loadEntities);
if($data === false) {
$this->logger->error(
'Could not get categories, content was no valid XML',
[
'app' => 'core',
]
);
$data = $this->loadData($response->getBody(), 'categories');
if($data === null) {
return null;
}
@ -175,17 +189,8 @@ class OCSClient {
return [];
}
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($response->getBody());
libxml_disable_entity_loader($loadEntities);
if($data === false) {
$this->logger->error(
'Could not get applications, content was no valid XML',
[
'app' => 'core',
]
);
$data = $this->loadData($response->getBody(), 'applications');
if($data === null) {
return [];
}
@ -251,17 +256,8 @@ class OCSClient {
return null;
}
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($response->getBody());
libxml_disable_entity_loader($loadEntities);
if($data === false) {
$this->logger->error(
'Could not get application, content was no valid XML',
[
'app' => 'core',
]
);
$data = $this->loadData($response->getBody(), 'application');
if($data === null) {
return null;
}
@ -316,17 +312,8 @@ class OCSClient {
return null;
}
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($response->getBody());
libxml_disable_entity_loader($loadEntities);
if($data === false) {
$this->logger->error(
'Could not get application download URL, content was no valid XML',
[
'app' => 'core',
]
);
$data = $this->loadData($response->getBody(), 'application download URL');
if($data === null) {
return null;
}