|
|
@@ -332,7 +332,7 @@ |
|
|
|
</RedundantCast> |
|
|
|
<RedundantCondition> |
|
|
|
<code><![CDATA[!empty($modified['old']) && is_array($modified['old'])]]></code> |
|
|
|
<code>is_array($modified['old'])</code> |
|
|
|
<code><![CDATA[is_array($modified['old'])]]></code> |
|
|
|
</RedundantCondition> |
|
|
|
</file> |
|
|
|
<file src="apps/dav/lib/CalDAV/Schedule/IMipService.php"> |
|
|
@@ -343,8 +343,8 @@ |
|
|
|
</file> |
|
|
|
<file src="apps/dav/lib/CalDAV/Schedule/Plugin.php"> |
|
|
|
<InvalidArgument> |
|
|
|
<code>[$aclPlugin, 'propFind']</code> |
|
|
|
<code>[$aclPlugin, 'propFind']</code> |
|
|
|
<code><![CDATA[[$aclPlugin, 'propFind']]]></code> |
|
|
|
<code><![CDATA[[$aclPlugin, 'propFind']]]></code> |
|
|
|
</InvalidArgument> |
|
|
|
<LessSpecificReturnStatement> |
|
|
|
<code><![CDATA[$vevent->DTEND]]></code> |
|
|
@@ -379,12 +379,12 @@ |
|
|
|
</file> |
|
|
|
<file src="apps/dav/lib/CalDAV/Search/Xml/Request/CalendarSearchReport.php"> |
|
|
|
<TypeDoesNotContainType> |
|
|
|
<code>!is_array($newProps['filters']['comps'])</code> |
|
|
|
<code>!is_array($newProps['filters']['params'])</code> |
|
|
|
<code>!is_array($newProps['filters']['props'])</code> |
|
|
|
<code>!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])</code> |
|
|
|
<code>!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])</code> |
|
|
|
<code>!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])</code> |
|
|
|
<code><![CDATA[!is_array($newProps['filters']['comps'])]]></code> |
|
|
|
<code><![CDATA[!is_array($newProps['filters']['params'])]]></code> |
|
|
|
<code><![CDATA[!is_array($newProps['filters']['props'])]]></code> |
|
|
|
<code><![CDATA[!isset($newProps['filters']['comps']) || !is_array($newProps['filters']['comps'])]]></code> |
|
|
|
<code><![CDATA[!isset($newProps['filters']['params']) || !is_array($newProps['filters']['params'])]]></code> |
|
|
|
<code><![CDATA[!isset($newProps['filters']['props']) || !is_array($newProps['filters']['props'])]]></code> |
|
|
|
</TypeDoesNotContainType> |
|
|
|
</file> |
|
|
|
<file src="apps/dav/lib/CalDAV/WebcalCaching/RefreshWebcalService.php"> |
|
|
@@ -420,7 +420,7 @@ |
|
|
|
<code>VCard</code> |
|
|
|
</MoreSpecificReturnType> |
|
|
|
<TypeDoesNotContainType> |
|
|
|
<code>$addressBooks[$row['id']][$readOnlyPropertyName] === 0</code> |
|
|
|
<code><![CDATA[$addressBooks[$row['id']][$readOnlyPropertyName] === 0]]></code> |
|
|
|
</TypeDoesNotContainType> |
|
|
|
</file> |
|
|
|
<file src="apps/dav/lib/CardDAV/MultiGetExportPlugin.php"> |
|
|
@@ -522,7 +522,7 @@ |
|
|
|
<code>bool</code> |
|
|
|
</InvalidNullableReturnType> |
|
|
|
<TooManyArguments> |
|
|
|
<code>new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)</code> |
|
|
|
<code><![CDATA[new PreconditionFailed('Cannot filter by non-existing tag', 0, $e)]]></code> |
|
|
|
</TooManyArguments> |
|
|
|
<UndefinedClass> |
|
|
|
<code>\OCA\Circles\Api\v1\Circles</code> |
|
|
@@ -854,7 +854,7 @@ |
|
|
|
</file> |
|
|
|
<file src="apps/encryption/lib/Crypto/Crypt.php"> |
|
|
|
<TypeDoesNotContainType> |
|
|
|
<code>get_class($res) === 'OpenSSLAsymmetricKey'</code> |
|
|
|
<code><![CDATA[get_class($res) === 'OpenSSLAsymmetricKey']]></code> |
|
|
|
</TypeDoesNotContainType> |
|
|
|
</file> |
|
|
|
<file src="apps/encryption/lib/Crypto/Encryption.php"> |
|
|
@@ -869,7 +869,7 @@ |
|
|
|
</file> |
|
|
|
<file src="apps/encryption/lib/Session.php"> |
|
|
|
<TooManyArguments> |
|
|
|
<code>new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)</code> |
|
|
|
<code><![CDATA[new Exceptions\PrivateKeyMissingException('please try to log-out and log-in again', 0)]]></code> |
|
|
|
</TooManyArguments> |
|
|
|
</file> |
|
|
|
<file src="apps/encryption/lib/Util.php"> |
|
|
@@ -897,7 +897,7 @@ |
|
|
|
<code>$shareId</code> |
|
|
|
<code>$shareId</code> |
|
|
|
<code>$shareId</code> |
|
|
|
<code>(int)$data['id']</code> |
|
|
|
<code><![CDATA[(int)$data['id']]]></code> |
|
|
|
</InvalidArgument> |
|
|
|
<LessSpecificReturnStatement> |
|
|
|
<code>$nodes[0]</code> |
|
|
@@ -932,7 +932,7 @@ |
|
|
|
<code>string</code> |
|
|
|
</InvalidReturnType> |
|
|
|
<InvalidScalarArgument> |
|
|
|
<code>(int)$share['id']</code> |
|
|
|
<code><![CDATA[(int)$share['id']]]></code> |
|
|
|
</InvalidScalarArgument> |
|
|
|
</file> |
|
|
|
<file src="apps/federation/lib/DbHandler.php"> |
|
|
@@ -1219,7 +1219,7 @@ |
|
|
|
</file> |
|
|
|
<file src="apps/files_sharing/templates/public.php"> |
|
|
|
<RedundantCondition> |
|
|
|
<code>$_['hideFileList'] !== true</code> |
|
|
|
<code><![CDATA[$_['hideFileList'] !== true]]></code> |
|
|
|
<code><![CDATA[isset($_['hideFileList']) && $_['hideFileList'] !== true]]></code> |
|
|
|
</RedundantCondition> |
|
|
|
</file> |
|
|
@@ -1396,7 +1396,7 @@ |
|
|
|
<file src="apps/sharebymail/lib/ShareByMailProvider.php"> |
|
|
|
<InvalidArgument> |
|
|
|
<code><![CDATA[$share->getId()]]></code> |
|
|
|
<code>(int)$data['id']</code> |
|
|
|
<code><![CDATA[(int)$data['id']]]></code> |
|
|
|
</InvalidArgument> |
|
|
|
</file> |
|
|
|
<file src="apps/systemtags/lib/Activity/Listener.php"> |
|
|
@@ -1974,7 +1974,7 @@ |
|
|
|
</file> |
|
|
|
<file src="lib/private/AppFramework/Routing/RouteConfig.php"> |
|
|
|
<InvalidArrayOffset> |
|
|
|
<code>$action['url-postfix']</code> |
|
|
|
<code><![CDATA[$action['url-postfix']]]></code> |
|
|
|
</InvalidArrayOffset> |
|
|
|
</file> |
|
|
|
<file src="lib/private/AppFramework/Services/AppConfig.php"> |
|
|
@@ -2200,7 +2200,7 @@ |
|
|
|
<code>getParams</code> |
|
|
|
</InternalMethod> |
|
|
|
<InvalidArrayOffset> |
|
|
|
<code>$params['collation']</code> |
|
|
|
<code><![CDATA[$params['collation']]]></code> |
|
|
|
</InvalidArrayOffset> |
|
|
|
</file> |
|
|
|
<file src="lib/private/DB/Connection.php"> |
|
|
@@ -2211,8 +2211,8 @@ |
|
|
|
<code>$params</code> |
|
|
|
</InvalidArgument> |
|
|
|
<InvalidArrayOffset> |
|
|
|
<code>$params['adapter']</code> |
|
|
|
<code>$params['tablePrefix']</code> |
|
|
|
<code><![CDATA[$params['adapter']]]></code> |
|
|
|
<code><![CDATA[$params['tablePrefix']]]></code> |
|
|
|
</InvalidArrayOffset> |
|
|
|
</file> |
|
|
|
<file src="lib/private/DB/Exceptions/DbalException.php"> |
|
|
@@ -2245,7 +2245,7 @@ |
|
|
|
<code>getParams</code> |
|
|
|
</InternalMethod> |
|
|
|
<InvalidArrayOffset> |
|
|
|
<code>$params['collation']</code> |
|
|
|
<code><![CDATA[$params['collation']]]></code> |
|
|
|
</InvalidArrayOffset> |
|
|
|
</file> |
|
|
|
<file src="lib/private/DB/QueryBuilder/QueryBuilder.php"> |
|
|
@@ -2256,7 +2256,6 @@ |
|
|
|
<code>$alias</code> |
|
|
|
</NullableReturnStatement> |
|
|
|
<ParamNameMismatch> |
|
|
|
<code>$groupBys</code> |
|
|
|
<code>$selects</code> |
|
|
|
</ParamNameMismatch> |
|
|
|
</file> |
|
|
@@ -2440,10 +2439,10 @@ |
|
|
|
<code>$user</code> |
|
|
|
</InvalidOperand> |
|
|
|
<RedundantCondition> |
|
|
|
<code>get_class($provider) !== 'OCA\Files_Sharing\MountProvider'</code> |
|
|
|
<code><![CDATA[get_class($provider) !== 'OCA\Files_Sharing\MountProvider']]></code> |
|
|
|
</RedundantCondition> |
|
|
|
<TypeDoesNotContainType> |
|
|
|
<code>get_class($provider) === 'OCA\Files_Sharing\MountProvider'</code> |
|
|
|
<code><![CDATA[get_class($provider) === 'OCA\Files_Sharing\MountProvider']]></code> |
|
|
|
</TypeDoesNotContainType> |
|
|
|
</file> |
|
|
|
<file src="lib/private/Files/Config/UserMountCache.php"> |
|
|
@@ -2618,7 +2617,7 @@ |
|
|
|
<code>Promise\promise_for( |
|
|
|
new Credentials($key, $secret) |
|
|
|
)</code> |
|
|
|
<code>\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())</code> |
|
|
|
<code><![CDATA[\Aws\or_chain([self::class, 'legacySignatureProvider'], ClientResolver::_default_signature_provider())]]></code> |
|
|
|
</UndefinedFunction> |
|
|
|
</file> |
|
|
|
<file src="lib/private/Files/ObjectStore/S3ObjectTrait.php"> |
|
|
@@ -2874,8 +2873,8 @@ |
|
|
|
<code>false</code> |
|
|
|
</InvalidArgument> |
|
|
|
<InvalidArrayOffset> |
|
|
|
<code>$app['path']</code> |
|
|
|
<code>$app['path']</code> |
|
|
|
<code><![CDATA[$app['path']]]></code> |
|
|
|
<code><![CDATA[$app['path']]]></code> |
|
|
|
</InvalidArrayOffset> |
|
|
|
<NullArgument> |
|
|
|
<code>null</code> |
|
|
@@ -3223,8 +3222,8 @@ |
|
|
|
</file> |
|
|
|
<file src="lib/private/Setup.php"> |
|
|
|
<RedundantCondition> |
|
|
|
<code>$content !== ''</code> |
|
|
|
<code>$type === 'pdo'</code> |
|
|
|
<code><![CDATA[$content !== '']]></code> |
|
|
|
<code><![CDATA[$type === 'pdo']]></code> |
|
|
|
</RedundantCondition> |
|
|
|
<UndefinedVariable> |
|
|
|
<code>$vendor</code> |
|
|
@@ -3254,7 +3253,7 @@ |
|
|
|
<InvalidArgument> |
|
|
|
<code><![CDATA[$share->getId()]]></code> |
|
|
|
<code><![CDATA[$share->getId()]]></code> |
|
|
|
<code>(int)$data['id']</code> |
|
|
|
<code><![CDATA[(int)$data['id']]]></code> |
|
|
|
</InvalidArgument> |
|
|
|
<TooManyArguments> |
|
|
|
<code>set</code> |
|
|
@@ -3460,8 +3459,8 @@ |
|
|
|
<code>$groupsList</code> |
|
|
|
</InvalidArgument> |
|
|
|
<InvalidArrayOffset> |
|
|
|
<code>$dir['path']</code> |
|
|
|
<code>$dir['url']</code> |
|
|
|
<code><![CDATA[$dir['path']]]></code> |
|
|
|
<code><![CDATA[$dir['url']]]></code> |
|
|
|
</InvalidArrayOffset> |
|
|
|
<NullArgument> |
|
|
|
<code>null</code> |