Browse Source

Avoid deprecation warnings about libxml_disable_entity_loader in PHP 8.1

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
tags/v24.0.0beta1
Côme Chilliet 2 years ago
parent
commit
c3a1a66eae
No account linked to committer's email address
2 changed files with 14 additions and 6 deletions
  1. 7
    3
      lib/private/Updater/ChangesCheck.php
  2. 7
    3
      lib/private/Updater/VersionCheck.php

+ 7
- 3
lib/private/Updater/ChangesCheck.php View File

@@ -138,9 +138,13 @@ class ChangesCheck {
protected function extractData($body):array {
$data = [];
if ($body) {
$loadEntities = libxml_disable_entity_loader(true);
$xml = @simplexml_load_string($body);
libxml_disable_entity_loader($loadEntities);
if (\LIBXML_VERSION < 20900) {
$loadEntities = libxml_disable_entity_loader(true);
$xml = @simplexml_load_string($body);
libxml_disable_entity_loader($loadEntities);
} else {
$xml = @simplexml_load_string($body);
}
if ($xml !== false) {
$data['changelogURL'] = (string)$xml->changelog['href'];
$data['whatsNew'] = [];

+ 7
- 3
lib/private/Updater/VersionCheck.php View File

@@ -95,9 +95,13 @@ class VersionCheck {
}

if ($xml) {
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($xml);
libxml_disable_entity_loader($loadEntities);
if (\LIBXML_VERSION < 20900) {
$loadEntities = libxml_disable_entity_loader(true);
$data = @simplexml_load_string($xml);
libxml_disable_entity_loader($loadEntities);
} else {
$data = @simplexml_load_string($xml);
}
if ($data !== false) {
$tmp['version'] = (string)$data->version;
$tmp['versionstring'] = (string)$data->versionstring;

Loading…
Cancel
Save