Browse Source

Suppress Phan warnings about calling undeclared class methods

The DeletedShareAPIController and ShareAPIController helpers for room
shares are defined in Talk, so the classes do not exist when Talk is not
installed. Due to this when the object returned by "getRoomShareHelper"
is used Phan complains that the class is not declared.

This is not a problem, though, because when the class is not available
"getRoomShareHelper" throws an exception, which is then caught where
that method was called. Therefore now those warnings from Phan are
suppressed (it would be better to use "@phan-suppress-next-line"
instead, but it is not yet available in our Phan version).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
tags/v14.0.0beta3
Daniel Calviño Sánchez 5 years ago
parent
commit
e2e6f23b67

+ 3
- 0
apps/files_sharing/lib/Controller/DeletedShareAPIController.php View File

@@ -86,6 +86,9 @@ class DeletedShareAPIController extends OCSController {
$this->serverContainer = $serverContainer;
}

/**
* @suppress PhanUndeclaredClassMethod
*/
private function formatShare(IShare $share): array {

$result = [

+ 5
- 0
apps/files_sharing/lib/Controller/ShareAPIController.php View File

@@ -141,6 +141,8 @@ class ShareAPIController extends OCSController {
* @param Node|null $recipientNode
* @return array
* @throws NotFoundException In case the node can't be resolved.
*
* @suppress PhanUndeclaredClassMethod
*/
protected function formatShare(\OCP\Share\IShare $share, Node $recipientNode = null): array {
$sharedBy = $this->userManager->get($share->getSharedBy());
@@ -914,6 +916,9 @@ class ShareAPIController extends OCSController {
return new DataResponse($this->formatShare($share));
}

/**
* @suppress PhanUndeclaredClassMethod
*/
protected function canAccessShare(\OCP\Share\IShare $share, bool $checkGroups = true): bool {
// A file with permissions 0 can't be accessed by us. So Don't show it
if ($share->getPermissions() === 0) {

Loading…
Cancel
Save