Merge pull request #25998 from nextcloud/techdept/psalm/personalsettings

Fix some types in the Settings Personal pages

apps/settings/lib/Settings/Personal/Additional.php

@@ -33,7 +33,7 @@ class Additional implements ISettings {
 	 * @return TemplateResponse returns the instance with all parameters set, ready to be rendered
 	 * @since 9.1
 	 */
-	public function getForm() {
+	public function getForm(): TemplateResponse {
 		return new TemplateResponse('settings', 'settings/empty');
 	}
 
@@ -41,7 +41,7 @@ class Additional implements ISettings {
 	 * @return string the section ID, e.g. 'sharing'
 	 * @since 9.1
 	 */
-	public function getSection() {
+	public function getSection(): string {
 		return 'additional';
 	}
 
@@ -53,7 +53,7 @@ class Additional implements ISettings {
 	 * E.g.: 70
 	 * @since 9.1
 	 */
-	public function getPriority() {
-		return '5';
+	public function getPriority(): int {
+		return 5;
 	}
 }

apps/settings/lib/Settings/Personal/ServerDevNotice.php

@@ -74,7 +74,7 @@ class ServerDevNotice implements ISettings {
 	/**
 	 * @return TemplateResponse
 	 */
-	public function getForm() {
+	public function getForm(): TemplateResponse {
 		$userFolder = $this->rootFolder->getUserFolder($this->userSession->getUser()->getUID());
 
 		$hasInitialState = false;
@@ -98,9 +98,9 @@ class ServerDevNotice implements ISettings {
 	}
 
 	/**
-	 * @return string the section ID, e.g. 'sharing'
+	 * @return string|null the section ID, e.g. 'sharing'
 	 */
-	public function getSection() {
+	public function getSection(): ?string {
 		if ($this->registry->delegateHasValidSubscription()) {
 			return null;
 		}
@@ -115,7 +115,7 @@ class ServerDevNotice implements ISettings {
 	 *
 	 * E.g.: 70
 	 */
-	public function getPriority() {
+	public function getPriority(): int {
 		return 1000;
 	}
 }