réplica de
https://github.com/nextcloud/server.git
synced 2024-08-26 17:55:04 +02:00
Move stub setup outside the test method
Stubs should be restored outside the test method in which they are used to ensure that they are properly restored no matter the result of the test (for example, if an exception is thrown). Besides that, this will make possible to reuse the stub in other sibling tests without having to explicitly setup it in them. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Este commit está contenido en:
padre
d606219576
commit
fcef15af80
@ -30,7 +30,6 @@ describe('OC.Share.ShareDialogView', function() {
|
||||
var saveLinkShareStub;
|
||||
|
||||
var fetchStub;
|
||||
var notificationStub;
|
||||
|
||||
var configModel;
|
||||
var shareModel;
|
||||
@ -473,6 +472,16 @@ describe('OC.Share.ShareDialogView', function() {
|
||||
});
|
||||
});
|
||||
describe('autocompletion of users', function() {
|
||||
var showNotificationStub;
|
||||
|
||||
beforeEach(function() {
|
||||
showNotificationStub = sinon.stub(OC.Notification, 'show');
|
||||
});
|
||||
|
||||
afterEach(function() {
|
||||
showNotificationStub.restore();
|
||||
});
|
||||
|
||||
describe('triggers autocomplete display and focus with data when ajax search succeeds', function () {
|
||||
it('users', function () {
|
||||
dialog.render();
|
||||
@ -1474,12 +1483,10 @@ describe('OC.Share.ShareDialogView', function() {
|
||||
});
|
||||
|
||||
it('throws a notification when the ajax search lookup fails', function () {
|
||||
notificationStub = sinon.stub(OC.Notification, 'show');
|
||||
dialog.render();
|
||||
dialog.autocompleteHandler({term: 'bob'}, sinon.stub());
|
||||
fakeServer.requests[0].respond(500);
|
||||
expect(notificationStub.calledOnce).toEqual(true);
|
||||
notificationStub.restore();
|
||||
expect(showNotificationStub.calledOnce).toEqual(true);
|
||||
});
|
||||
|
||||
describe('renders the autocomplete elements', function() {
|
||||
|
Cargando…
Referencia en una nueva incidencia
Block a user