Roeland Jago Douma
37199c1da0
Merge pull request #25585 from nextcloud/enhancement/empty-email-validation
Micro-optimize validation of empty email addresses
3 years ago
Christoph Wurst
5babad4f6f
Merge pull request #25576 from nextcloud/fix/webp_check
Fix WebP availability check
3 years ago
Christoph Wurst
883848b58a
Micro-optimize validation of empty email addresses
Then we don't have to construct any validators.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Christoph Wurst
9430de181e
Do not send imip email to invalid recipients
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Jan C. Borchardt
e207b94554
Merge pull request #25299 from elsiehupp/favicon-touch-corners
favicon-touch image corners
3 years ago
Roeland Jago Douma
bf4210aa8d
Always use the cache
If there is no cache available we will use the null cache. Which (you
guessed it) just doesn't do anything. This makes the code flow a bit
nicer and psalm a bit happier.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Christoph Wurst
e618ea83b5
Make the app code checker a NOOP
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Roeland Jago Douma
cc554890c1
Fix WebP availability check
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Konrad Abicht
c755165dd4
added unit tests for LoginFlowV2Service::flowDone
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Roeland Jago Douma
d5dea10517
Merge pull request #25378 from nextcloud/bugfix/noid/mention-match-improvements
Improve mention matches
3 years ago
Konrad Abicht
d60dd8a208
added unit tests for LoginFlowV2Service::startLoginFlow
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Konrad Abicht
f29748a5e1
added unit tests for LoginFlowV2Service::getByLoginToken
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Konrad Abicht
b0a2278a7e
added unit tests for LoginFlowV2Service::poll
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Nextcloud bot
02885358a9
[tx-robot] updated from transifex
3 years ago
Christoph Wurst
8a474305fa
Merge pull request #25570 from nextcloud/enh/dashboard/psalm_fixes
Some psalm fixes for the DashboardController
3 years ago
Roeland Jago Douma
7bacd710a1
Merge pull request #25460 from nextcloud/fix/apppassword/always_renew
Always renew apppasswords on login
3 years ago
Roeland Jago Douma
a6cd238517
Some psalm fixes for the DashboardController
* Use the AppFramework IInitialState
* Set return type
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma
d0cf4e2f58
Merge pull request #24904 from nextcloud/enh/github-psalm
Have psalm analysis directly on github
3 years ago
Roeland Jago Douma
cd457cc68b
Always renew apppasswords on login
Else you can end up that you renewed your password (LDAP for example).
But they still don't work because you did not use them before you logged
in.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma
1cc23c6e6e
Merge pull request #25558 from nextcloud/deprecate/generic-event-wrapper
Deprecate the GenericEvent wrapper
3 years ago
Roeland Jago Douma
847ee4041a
Merge pull request #25566 from nextcloud/fix/25359/followup
Fix remaining #25359
3 years ago
Christoph Wurst
039ecbdcf9
Merge pull request #25560 from nextcloud/enhancement/pure-psr-event
Make our event base class independent of Symfony and follow PSR
3 years ago
Roeland Jago Douma
25f9203a70
Fix remaining #25359
As a wise man once said:
"I like PRs that pass tests before merging"
C. Wurst, Feb 9th 2021
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Christoph Wurst
2f26ff40e9
Merge pull request #25359 from nextcloud/enhancement/typed-service-registration
Type the service registration
3 years ago
Roeland Jago Douma
8677870a09
Merge pull request #25435 from nextcloud/fix/favorite-icon
Fix favorite dark icon
3 years ago
Christoph Wurst
0a28440bf6
Make our event base class independent of Symfony and follow PSR
Symfony is migrating towards a pure PSR event dispatcher, hence their
event class is POPO that implements the PSR stoppable event interface.
Since we can do that ourself and this change doesn't come with any API
changes (breakage), it's easy for us to become independent of Symfony
but also stay PSR-compliant at the same step.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Roeland Jago Douma
f9a4871bd4
Merge pull request #25557 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
3 years ago
Roeland Jago Douma
cc18213c98
Have psalm analysis directly on github
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Lukas Reschke
d42f9e65a2
Merge pull request #25554 from nextcloud/fix/pslam/tainted_cookie
tain-escape the cookie input
3 years ago
Christoph Wurst
aabd73912e
Type the service registration
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Christoph Wurst
f76ec25e58
Deprecate the GenericEvent wrapper
This class is a convenience type to replace the old Symfony GenericEvent
with our own type, to ease the transition from Symfony events to our
(PSR) events. Hence we can deprecate the class as precaution to smoothen
the next transition step in the future.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Nextcloud-PR-Bot
130ce14892
Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
3 years ago
Nextcloud bot
decb70b9ac
[tx-robot] updated from transifex
3 years ago
Roeland Jago Douma
784a752c0f
tain-escape the cookie input
we only set the cookie if it is a proper <=32 char alphanum string.
Otherwise we just ignore the input.
Makes psalm also happier so that we can focus on other errors.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Christoph Wurst
e4ca0c9fa0
Merge pull request #25548 from k00ni/pr/add-tests-for-LoginFlowV2Credentials
Added tests for OC\Core\Data\LoginFlowV2Credentials
3 years ago
Lukas Reschke
1fb03b3b2f
Merge pull request #25545 from k00ni/fix/Dockerfile-wrong-package-name-php7.4-acpu
Corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
3 years ago
Christoph Wurst
3c2ea99940
Merge pull request #25546 from nextcloud/techdept/deprecate-event-constants
Deprecate all remaining event constants
3 years ago
Christoph Wurst
f96f0f6cad
Merge pull request #25543 from nextcloud/deprecate/idb-events
Deprecate the internal IDBConnection event name constants
3 years ago
Christoph Wurst
f8808e260d
Move app_password_created to a typed event
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Christoph Wurst
4201fb25d3
Merge pull request #25549 from nextcloud/remove-reconnect-wrapper
remove ReconnectWrapper
3 years ago
Robin Appelman
111fa47f10
remove ReconnectWrapper
dbal now handles it's own reconnections: https://github.com/doctrine/dbal/blob/3.0.x/UPGRADE.md#the-pingableconnection-interface-is-removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Konrad Abicht
a50c615d37
simplified tests
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Konrad Abicht
a28705064b
fixed coding style issue
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Konrad Abicht
b38a619212
added tests for OC\Core\Data\LoginFlowV2Credentials
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Roeland Jago Douma
f797a94393
Merge pull request #25531 from nextcloud/fix/dispatcher-argument-order
Fix the legacy dispatcher argument order
3 years ago
Christoph Wurst
4c6bc62f38
Merge pull request #25535 from nextcloud/query-exception-foreward
Improve exception when auto-wiring fails
3 years ago
Christoph Wurst
4fc0b2c639
Deprecate all remaining event constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
Konrad Abicht
f987eaea10
corrected package name used in .devcontainer/Dockerfile (php7.4-acpu => php7.4-apcu)
Signed-off-by: Konrad Abicht <hi@inspirito.de>
3 years ago
Roeland Jago Douma
a36186980d
Merge pull request #25542 from nextcloud/fix-file-checker
Add .devcontainer to file-checker.php
3 years ago
Robin Appelman
ec875227ec
forward query exception when fallback construction fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago