Roeland Jago Douma
b57019bcaa
Log the route not found exception on a lower level
This should be logged but it is not that critical to wanner level 3
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Morris Jobke
15561b4e0a
Merge pull request #21977 from onehappycat/issue_21960
Ignore whitespace in sharing by mail
3 years ago
Morris Jobke
1326862d63
Merge pull request #21988 from nextcloud/enh/theming-guest
Combine body-login rules in theming and fix twofactor and guest styling on bright colors
3 years ago
Morris Jobke
6318721e19
Merge pull request #21818 from nextcloud/techdebt/noid/theming-bootstrap
Use IBootstrap for the app theming
3 years ago
Robin Appelman
c8427781b4
implement old settings interface
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Morris Jobke
340cd81d2f
Use IBootstrap for the app theming
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke
6ef029d6f3
Merge pull request #21987 from nextcloud/techdebt/notfoundresponse-template
Move NotFoundResponse to a proper TemplateResponse
3 years ago
Julius Härtl
074b38d334
Combine body-login rules in theming and fix twofactor and guest styling on bright colors
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
Julius Härtl
e1b696929f
Move NotFoundResponse to a proper TemplateResponse
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
Nextcloud bot
c4a6666e6c
[tx-robot] updated from transifex
3 years ago
Morris Jobke
34c027e443
Merge pull request #21940 from nextcloud/fix/14541/fix-fragile-acceptance-tests-part1
Revert "Disable fragile tests for now" partially
3 years ago
onehappycat
e04525c186
Ignore whitespace in sharing by mail
Signed-off-by: onehappycat <one.happy.cat@gmx.com>
3 years ago
Morris Jobke
ce314d9484
Merge pull request #21814 from nextcloud/techdebt/noid/federated_share_added-into-typed-event
Move federated_share_added into a typed event
3 years ago
Morris Jobke
a169bd243f
Merge pull request #21972 from nextcloud/techdebt/noid/cleanup-phpunit-warnings
Fix PHPUnit deprecation warnings
3 years ago
Morris Jobke
173f8abc7e
Merge pull request #21628 from nextcloud/external-to-s3-trashbin-fix
fix moving files from external storage to object store trashbin
3 years ago
Morris Jobke
9275823a30
Merge pull request #21747 from simonspa/fix_mail_logosize
Fix header logo size in notification mails
3 years ago
Robin Appelman
c8cf2e8a5b
fix renameFromStorage messing with folder mimetype
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
Simon Spannagel
d5b1297b55
Adjust tests to new e-mail layout
Signed-off-by: Simon Spannagel <simonspa@kth.se>
3 years ago
Simon Spannagel
1fc54d3479
Fix header logo size in notification mails
Signed-off-by: Simon Spannagel <simonspa@kth.se>
4 years ago
Morris Jobke
761cdf9877
Remove deprecated test of internal attributes via assertAttributeEquals in constructor tests
I removed the tests completely because they just test that the constructor assigns the values to the internal properties. Nothing that should be cared about from the outside.
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322
It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke
1339ea15e2
Replace deprecated assertArraySubset with logic that does the same
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke
7e6c0ec284
Use assertEqualsCanonicalizing instead of deprecated assertEquals parameter
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke
e4144e6b36
Remove deprecated test of internal attributes via assertAttributeEquals
See https://github.com/sebastianbergmann/phpunit/issues/3339#issuecomment-428843322
It is seen as bad practice to test internal stuff of objects instead of the actual input and output of mathod calls.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke
0123cd0ae3
Use assertStringContainsString instead of assertContains on strings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Morris Jobke
f8955bd0d1
Merge pull request #21973 from nextcloud/techdebt/noid/fix-risky-2fa-backup-code-test
Fix risky test in twofactor_backupcodes
3 years ago
Robin Appelman
ad7798f9c9
use exceptions for error signaling in writeStream
this remove the ambiguity when writing zero length files
Signed-off-by: Robin Appelman <robin@icewind.nl>
4 years ago
Robin Appelman
fcad692b4a
rollback cache rename if trashbin move fails
Signed-off-by: Robin Appelman <robin@icewind.nl>
4 years ago
Robin Appelman
5949849322
fix moving files from external storage to object store trashbin
having the "cache rename" after the "storage move" caused the target
to get the fileid from the source file, without taking care that the object
is stored under the original file id.
By doing the "cache rename" first, we trigger the "update existing file"
logic while moving the file to the object store and the object gets stored for the
correct file id
Signed-off-by: Robin Appelman <robin@icewind.nl>
4 years ago
Georg Ehrke
cdf095d107
Merge pull request #21970 from nextcloud/dependageorg/npm_and_yarn/nextcloud/vue-2.3.0
Bump @nextcloud/vue from 2.2.1 to 2.3.0
3 years ago
Morris Jobke
9af99a73dc
Merge pull request #21966 from nextcloud/enh/userbackend/custom_logout
Allow user backends to specify a custom logout url
3 years ago
Morris Jobke
49f33ee632
Fix risky test in twofactor_backupcodes
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Georg Ehrke
be20a494aa
Bump @nextcloud/vue from 2.2.1 to 2.3.0
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
3 years ago
Roeland Jago Douma
ba39d7adde
Merge pull request #21963 from nextcloud/fix/sharing/respect_default_share_permissions
Respect default share permissions
3 years ago
Roeland Jago Douma
e0cc95f3aa
Allow user backends to specify a custom logout url
* Allows SSO backends to do a global logout
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Roeland Jago Douma
df1fa52ee5
Respect default share permissions
Else we'll always create new shares with the max permissions.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
3 years ago
Julius Härtl
8af979f56d
Merge pull request #21957 from nextcloud/techdebt/noid/bootstrap-testing
Use IBootstrap for the testing app
3 years ago
Morris Jobke
0763a17332
Move federated_share_added into a typed event
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Nextcloud bot
99d0ba5f7e
[tx-robot] updated from transifex
3 years ago
Morris Jobke
153337a5be
Use IBootstrap for the testing app
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
Roeland Jago Douma
94c74fb97b
Merge pull request #21946 from nextcloud/fix/webauthn/windows_hello
Do not double encode the userid in webauthn login
3 years ago
Roeland Jago Douma
b573014e2d
Merge pull request #21949 from nextcloud/smb-3.2.6
update icewind/smb to 3.2.6
3 years ago
Roeland Jago Douma
686f369d66
Merge pull request #21950 from nextcloud/bugfix/noid/wipe-translation
Properly fetch translation for remote wipe confirmation dialog
3 years ago
Roeland Jago Douma
4c08b1754d
Do not double encode the userid in webauthn login
* Else login fails with webauthn devices that send the userid
- Like windows hello
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
3 years ago
npmbuildbot[bot]
53088de52b
Compile assets
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
3 years ago
Morris Jobke
346f647962
Merge pull request #21870 from nextcloud/fix/bootstrap-context-container-interfaces
Make the bootstrap context return ContainerInterface instances
3 years ago
Julius Härtl
cf3dd5b6bd
Properly fetch translation for remote wipe confirmation dialog
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
John Molakvoæ
c842678f0a
Merge pull request #21948 from nextcloud/bugfix/noid/accesibilityoca
Load accessibilityoca script
3 years ago
John Molakvoæ
5fea50b770
Merge pull request #21867 from nextcloud/dependageorg/npm_and_yarn/nextcloud/vue-2.2.1
3 years ago
Daniel Calviño Sánchez
9303390b66
Hide share link menu before copying the share link in acceptance tests
The (old) Firefox version used in the acceptance tests does not properly
render the share link menu. As the menu is taller than it should
sometimes it covers the copy link button, so it is not possible to click
it without hiding the share link menu. Moreover, in those cases the
share menu button is also covered by the share menu, so the menu needs
to be closed by pressing the "Esc" key.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
3 years ago
Georg Ehrke
387b1d7b13
Recompile JS assets
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
3 years ago