* Use common `data-testid` to identify elements rather than to depend on internal classes or properties
* Force clean the state for the user tests
* Move leftover acceptance tests for users from drone to cypress
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- fix setting loading classes
- also removes invalid HTML attributes, there is no such props in `NcContent`
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
fix(user_status): separate user menu and dashboard status layout
- Remove href="#" from a button for HTML validation
- Use @nextcloud/vue NcButton instead of custom button in Dashboard
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
fix(isLegitimatedForUserId): Setup mountpoints to check file access
This fixes workflows on groupfolders, as it will consider access to
files in groupfolders.
It also fixes false positives where access to files was limited by other
means not taken into account before, e.g. access control.
For postDelete events, check for permissions of the parent folder
instead, as the file itself no longer exists.
Fixes: nextcloud/flow_notifications#71
Signed-off-by: Jonas <jonas@freesources.org>
Do not treat `isDefaultExpireDateEnforced` as fallback
`isDefaultExpireDateEnforced` and its corresponding `defaultExpirationDate`
is currently treated as the enforcement fallback when share type enforcements are not
set.
However, `isDefaultExpireDateEnforced` and `defaultExpirationDate` are actually more like
`isDefaultPublicExpireDateEnforced` and `defaultPublicExpirationDate` and therefore only applies
to public shares.
It might be ideal to rename this variables all the way from the backend config to the way we use
them in the frontend code.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Current expiration date errorneously assumes that `defaultExpirationDate`
applies to all kinds of shares. But it only really applies to public shares despite
its name.
This commit, fixes that by paring expiration dates with the correct share types during
new share initialization and simplifying the `hasExpirationDate` (check) property.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
We should check that a maximum expiry date has been enforced for
all shares and NOT JUST FOR internal shares before enforcing a UI max date,
like in commit 9757e680e2
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
2. non-grid: border is already included in height because the tr
is a border-box (made this explicit to be safe)
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
fix(settings): label user quota progress with aria-labelledby
Labeling with `<label>` doesn't work in some screen readers.
`<label>` also doesn't work as a clickable link here.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
fix(theming): App order settings - ensure the focus is kept on button
When pressing a button for changing the app order that button should keep the focus after reordering the list.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- Remove non-existing `button-class` from `NcAppNavigationNew`
- Type: use `input-id` instead of `id` on `NcSelect` to be labeled
- Encode uniqueId with user's ID, because user.id may contain space
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Ferdinand Thiessen
Nextcloud bot
Christopher Ng
Côme Chilliet
Marcel Klehr
Joas Schilling
Varun Patil
julia.kirschenheuter
hamza221
Grigorii K. Shartsev
Jonas
Louis Chemineau
jld3103
fenn-cs