50e374c12f
only require user to be set in a query that handles tags
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
a9e3d2a10f
Update user share must use correct expiration validation
Updating a user or group share now uses the correct method for the
validation of the expiration date. Instead of using the one from links
it uses the one for internal shares.
To avoid future confusion, the method "validateExpirationDate" has been
renamed to "validateExpirationDateLink".
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
3 years ago
6ade109b60
Merge pull request #26194 from nextcloud/techdebt/noid/remove-duplicate-sharing-unit-integration-tests-group-permission
Remove duplicate unit test in sharing that checks for group permission updates
3 years ago
f8bca545df
unify handling of Folder::search methods into "new" query objects
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
14a1b5063e
use "newer" node search api directly in unified search
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
8f22d48f7a
Merge pull request #26189 from nextcloud/techdept/qbmapper-execute-update-query
Use executeQuery and executeUpdate in the QBMapper
3 years ago
0d8b3baf61
Use executeQuery and executeUpdate in the QBMapper
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
3 years ago
b34035f845
Merge pull request #26193 from nextcloud/techdebt/noid/remove-sharing-duplicate-unit-integration-tests
Permission tests for the sharing are fully covered in sharing v1 integration tests
3 years ago
d650de13a4
Remove duplicate unit test in sharing that checks for group permission updates
* it was skipped before anyways
* it is covered for example in build/integration/sharing_features/sharing-v1-part3.feature#L517-L548 (see 54f8f75f6f/build/integration/sharing_features/sharing-v1-part3.feature (L517-L548))
3 years ago
e6bd23acf9
Permission tests for the sharing are fully covered in sharing v1 integration tests
See build/integration/sharing_features/sharing-v1*.features for the exact same tests. Especially part3 that covers most of the different permission setups over webdav.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
dd39f5e871
Merge pull request #25112 from nextcloud/repair-exception
dont error the entire repair process when a repair step errors
3 years ago
6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
Fix valid storages removed when cleaning remote storages
3 years ago
9e3775618b
log full expection during repair step
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
9135a42781
make repair errors more visible
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
c75b82adbb
dont error the entire repair process when a repair step errors
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
5cdc3e9c9d
Merge pull request #26188 from nextcloud-pr-bot/automated/noid/psalm-baseline-update
[Automated] Update psalm-baseline.xml
3 years ago
3959313b2c
Update psalm baseline
Signed-off-by: GitHub <noreply@github.com>
3 years ago
a186d08471
[tx-robot] updated from transifex
3 years ago
37feee4e87
Merge pull request #24384 from nextcloud/cleanup/remove-old-migration-check
Remove dead code from checking core/apps before upgrades
3 years ago
a2f3077ee8
Skip db migration simulation for core schema changes
Signed-off-by: Julius Härtl <jus@bitgrid.net>
3 years ago
459e0b311b
Merge pull request #25924 from nextcloud/bugfix/noid/only-mark-migrations-as-installed-after-executing-them-in-case-the-developer-broke-them
Only mark migrations as installed after execution
3 years ago
f56e5bb0db
Merge pull request #25676 from nextcloud/drop/utl-is-ie
Drop \OCP\Util::isIe
3 years ago
f1fefd91df
Merge pull request #26160 from nextcloud/enh/eslint
3 years ago
6867ba8e33
Merge pull request #24580 from nextcloud/enh/noid/db-convert
DB conversion: improve console output
3 years ago
0d46fafd41
Merge pull request #26161 from nextcloud/bugfix/noid/improve-matching-of-phonebook-searches
Improve search results when only phonebook-matches can we autocompleted
3 years ago
87d39375d8
Fix comments filesplugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
d011df6aa7
Merge pull request #26076 from nextcloud/enh/noid/ldap-occ-user-reset
adds ldap user:reset command
3 years ago
244e13cd43
DB conversion: improve console output
Signed-off-by: Simon Spannagel <simonspa@kth.se>
3 years ago
2445b9491e
Merge pull request #26172 from nextcloud/techdebt/noid/code-checker-is-noop
occ app:check-code is noop
3 years ago
043b5a9de4
Fix TerserPlugin
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
5d9bb5e247
Lint fix
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
fb183b457c
Add eslint testing
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
3 years ago
1b5db252c5
Merge pull request #26165 from nextcloud/dependabot/composer/vimeo/psalm-4.6.4
3 years ago
68a402d889
occ app:check-code is noop
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
1b0355f2c6
adds ldap user:reset command
- allows to delete data of existing LDAP users, which otherwise is safe
guarded
- ensures that the user is not being deleted on LDAP through a plugin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
3 years ago
cf434d5107
Also limit to user group in case enumeration is enabled for groups and phonenumbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
ab5c19bb08
Merge pull request #26131 from nextcloud/fix/initialstate-templates
Fix default missing initial state for templates
3 years ago
958d6e2f34
Bump vimeo/psalm from 4.6.2 to 4.6.4
Bumps [vimeo/psalm](https://github.com/vimeo/psalm ) from 4.6.2 to 4.6.4.
- [Release notes](https://github.com/vimeo/psalm/releases )
- [Commits](https://github.com/vimeo/psalm/compare/4.6.2...4.6.4 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
3 years ago
3379e69ecc
Fix parameter types in docs
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
47e14c9a79
Add missing index on the user column
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
9a189bc710
Improve search results when only phonebook-matches can we autocompleted
Signed-off-by: Joas Schilling <coding@schilljs.com>
3 years ago
98fb265e9f
Merge pull request #26153 from nextcloud/psalm/26111/fix-undefined-exception-class
Use correct exception type hint in catch statement
3 years ago
096806087c
[tx-robot] updated from transifex
3 years ago
0f2c4ff64c
Use correct exception type hint in catch statement
Found by psalm update 4.6.2 to 4.6.3 in #26111
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
3 years ago
5938da8d20
Merge pull request #26137 from nextcloud/block-__groupfolders-uid
dont allow creating users with __groupfolders as uid
3 years ago
dd477d30f9
dont allow creating users with __groupfolders as uid
Fixes https://github.com/nextcloud/groupfolders/issues/338
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
f1e2fb426e
Merge pull request #26013 from nextcloud/object-store-copy-cache-id
Return the fileid from `copyFromCache` and use it instead of doing an extra query
3 years ago
5ffaa94fbc
add (hidden) option to always show smb root as writable
some smb servers are very insistent in reporting that the root of the share is readonly, even if it isn't.
This works around the problem by adding a hidden option to overwrite the permissions of the root of the share.
This can be enabled using
```bash
occ files_external:config <mount id> root_force_writable true
```
where you can find your mount id using
```bash
occ files_external:list
```
Signed-off-by: Robin Appelman <robin@icewind.nl>
3 years ago
7a09b7d60e
Merge pull request #26143 from nextcloud/techdebt/noid/fix-cs
Fix CS in CacheTest
3 years ago
ccaa131e96
Merge pull request #26144 from nextcloud/funding
Add funding info
3 years ago
Robin Appelman
Vincent Petry
John Molakvoæ
Roeland Jago Douma
Christoph Wurst
Morris Jobke
kesselb
Nextcloud-PR-Bot
Nextcloud bot
Julius Härtl
Joas Schilling
John Molakvoæ (skjnldsv)
Simon Spannagel
dependabot-preview[bot]
Joas Schilling
Arthur Schiwon