Marcel Müller
983336c36c
fix(preview): Check if node id is null before deleting the preview folder
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-02-15 07:19:58 +01:00
Git'Fellow
0da4d1cd5a
Lower failed movie preview to info
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-02-10 12:47:46 +00:00
Robin Appelman
57ee788f01
Merge pull request #43391 from nextcloud/backport/43131/stable28
...
[stable28] fix(files): Don't attempt to format a partial cache entry
2024-02-09 14:29:23 +01:00
Ferdinand Thiessen
c4b164dee0
Merge pull request #43422 from nextcloud/backport/43317/stable28
...
[stable28] fix(ContactsStore): Sanitize user ID given to guest avatar route
2024-02-09 02:17:42 +01:00
Joas Schilling
1412eedbc4
fix(migration): Make naming constraint fail softer on updates
...
Only on installation we want to break hard, so that all developers notice
the bugs when installing the app on any database or CI, and can work on
fixing their migrations before releasing a version incompatible with Postgres.
In case of updates we might be running on production instances and the
administrators being faced with the error would not know how to resolve it
anyway. This can also happen with instances, that had the issue before the
current update, so we don't want to make their life more complicated
than needed.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-08 10:07:19 +00:00
Ferdinand Thiessen
d15d7bcba0
fix(ContactsStore): Sanitize user ID given to guest avatar route
...
It is not allowed to use slashes within path parameters, so they would need to be encoded.
But URL encoded slashes are not suported by Apache, so instead replace slash with space.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-07 09:23:52 +00:00
Robin Appelman
b2487de1e1
continue background scanning different storages if one fails
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-07 09:08:15 +00:00
Christoph Wurst
700a5d7ba2
fix(files): Don't attempt to format a partial cache entry
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-02-06 12:53:13 +00:00
Ferdinand Thiessen
b96a2876c2
Merge pull request #43294 from nextcloud/backport/42811/stable28
...
[stable28] make failure to load app commands non-fatal
2024-02-03 21:18:09 +01:00
Lorenz Brun
745b6970bb
dav: fix wrong decoding of pluses in URLs
...
PHP's urldecode function does not decode URLs according to RFC 3986, but
according to the HTML 4.01 query parameter
encoding. This results in pluses being wrongly decoded to spaces even
though they should not be decoded at all.
Use rawurldecode instead, which follows RFC 3986 properly.
This fixes an issue where files on DAV shares containing pluses were
incorrectly decoded to spaces.
Fixes : #15849
Signed-off-by: Lorenz Brun <lorenz@brun.one>
2024-02-03 15:29:18 +01:00
Ferdinand Thiessen
b91688ed55
Merge pull request #43046 from nextcloud/backport/43045/stable28
...
[stable28] fix(apps): Fix type information of app manager
2024-02-03 14:11:17 +01:00
Ferdinand Thiessen
933ad5e4d2
Merge pull request #43181 from nextcloud/backport/42930/stable28
...
[stable28] Fix: config param 'overwritecondaddr' not working
2024-02-03 12:16:56 +01:00
Joas Schilling
44023ff047
fix(apps): Fix type information of app manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-02-03 11:47:47 +01:00
Robin Appelman
44d3a4ffba
make failure to load app commands non-fatal
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-02 15:01:13 +00:00
Ferdinand Thiessen
ca8d71966f
Merge pull request #43244 from nextcloud/backport/41327/stable28
...
[stable28] dont reuse etag for folders marked explicitly unscanned
2024-02-01 14:21:40 +01:00
Robin Appelman
9616d48c38
also updated parent etags when a changed etag is detected during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:27:29 +00:00
Robin Appelman
b38708afaf
dont reuse etag for folders marked explicitly unscanned
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-01-31 18:27:29 +00:00
Ferdinand Thiessen
cfc12b8650
fix(Request): Catch exceptions in isTrustedProxy
...
The function fails if the configured trusted proxies contain invalid characters and the underlying IpUtils will throw.
But as it is used by `getRemoteAddress` which is used by logging / templating, thrown errors are not reported but silently fail with error 500.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-29 15:23:50 +00:00
Pavel Kryl
8442ed014d
code style: ommited space, reverted [code review]
2024-01-29 09:58:56 +00:00
Pavel Kryl
21625f0d66
fixing bug #6914 : Config Param 'overwritecondaddr' not working
...
- just ignoring/removing extra parameter 'protocol' as suggested by
blizzz
Signed-off-by: Pavel Kryl <pavel@kryl.eu>
2024-01-29 09:58:56 +00:00
Christoph Wurst
0e3f68079e
fix(auth): Fix logging in with email, password and login name mismatch
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-22 09:43:59 +00:00
Arthur Schiwon
b692fbf061
Merge pull request #42918 from nextcloud/backport/setupchecks-2/stable28
...
[stable28] Setup check migrations to new API
2024-01-18 12:34:52 +01:00
Arthur Schiwon
c16744c70f
Merge pull request #42899 from nextcloud/backport/42860/stable28
...
[stable28] Update ContactsStore: Avoid exceptions on empties
2024-01-18 11:13:11 +01:00
Côme Chilliet
985a91ca43
Improve validator output in case of invalid RichObject
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:54:33 +01:00
Arthur Schiwon
a380014c12
Merge pull request #42868 from nextcloud/backport/42607/stable28
...
[stable28] fix(session): Avoid useless authtoken DB queries for anonymous requests
2024-01-17 20:40:35 +01:00
Josh
2a386f8360
Update ContactsStore: Avoid exceptions on empties
...
Fixes #42858 and makes things more robust
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-01-17 18:48:08 +00:00
Joas Schilling
f7f94bf919
fix(systemreport): Mark more configs as sensitive
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-17 10:30:43 +01:00
Git'Fellow
980b14f629
fix(session): Avoid two useless authtoken DB queries for every anonymous request
...
Co-Authored-By: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-01-17 09:16:22 +00:00
Arthur Schiwon
ee0f4f067d
Merge pull request #42824 from nextcloud/backport/42768/stable28
...
[stable28] (dashboard): Lower error to info log message
2024-01-17 09:47:13 +01:00
Arthur Schiwon
f0a6c4429d
Merge pull request #42827 from nextcloud/backport/41272/stable28
...
[stable28] fix: reduce memory consumption of scans
2024-01-16 19:17:23 +01:00
Joas Schilling
1c38f8952f
fix(appstore): Only send subscription keys to valid appstores
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-16 10:16:57 +01:00
Git'Fellow
d2da9c8fbe
fix: reduce memory consumption of scans
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix lint
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-16 09:28:43 +01:00
Git'Fellow
27bf7c6f8c
Lower to info
...
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-16 09:24:27 +01:00
Git'Fellow
a60bf6a00d
Lower error to warning
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-01-16 09:24:26 +01:00
Côme Chilliet
4acb4a5f4c
Import OCP IToken as OCPIToken to avoid a name clash in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 18:01:01 +00:00
Côme Chilliet
6893aa1f6b
Use OCP version of IToken in AppPasswordCreatedEvent
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 18:01:00 +00:00
Côme Chilliet
9e75c75f86
Use IToken from OCP instead of OC
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 18:01:00 +00:00
Côme Chilliet
63fbf90570
Suppress or fix psalm errors related to InvalidTokenException
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 18:01:00 +00:00
Côme Chilliet
360e7ffcca
Always catch OCP versions of authentication exceptions
...
And always throw OC versions for BC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 18:00:59 +00:00
Julius Härtl
f297de9e6f
Merge pull request #42651 from nextcloud/backport/41927/stable28
...
[stable28] perf: Use more performant way to obtain and check the email as a login name with token login
2024-01-11 11:53:09 +01:00
Marcel Klehr
a85ee2e0ce
fix(psalm issues)
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 14:37:24 +01:00
MB-Finski
b83e53d1ba
Update doc blocks
...
Signed-off-by: MB-Finski <sami.finnila@gmail.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 14:37:24 +01:00
Sami Finnilä
283952e857
Return providers as indexed array
...
Signed-off-by: MB-Finski <sami.finnila@gmail.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 14:37:24 +01:00
Julius Härtl
bc0ab8df52
fix: Only apply cast if needed when searching users for value
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-09 15:02:38 +01:00
Julius Härtl
1712df7881
perf: Use more performant way to obtain and check the email as a login name with token login
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-01-09 15:02:38 +01:00
Robin Appelman
eb4dae7505
Merge pull request #42521 from nextcloud/backport/41914/stable28
...
[stable28] only do a multipart s3 copy when above the regular copy limit
2024-01-02 18:00:50 +01:00
Robin Appelman
f516e9599b
Merge pull request #42450 from nextcloud/backport/37469/stable28
...
[stable28] restore shared lock ttl to previous value when releasing
2024-01-02 14:50:14 +01:00
Josh Richards
a781412660
Fix log rotation notification level (warning->info)
...
Fixes #42537
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-01-01 09:22:48 +00:00
Julius Härtl
238ea7a8b4
fix(s3): Add config option to disable multipart copy for certain s3 providers
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-29 10:36:09 +00:00
Robin Appelman
58abe5e3f4
only do a multipart s3 copy when above the regular copy limit
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-12-29 10:36:09 +00:00