nextcloud

Commit Graph

Author	SHA1	Message	Date
Morris Jobke	590d461210	Remove unneeded import Signed-off-by: Morris Jobke <hey@morrisjobke.de>	3 years ago
Morris Jobke	9e483ea949	Fix unit tests Signed-off-by: Morris Jobke <hey@morrisjobke.de>	3 years ago
Christoph Wurst	caff1023ea	Format control structures, classes, methods and function To continue this formatting madness, here's a tiny patch that adds unified formatting for control structures like if and loops as well as classes, their methods and anonymous functions. This basically forces the constructs to start on the same line. This is not exactly what PSR2 wants, but I think we can have a few exceptions with "our" style. The starting of braces on the same line is pracrically standard for our code. This also removes and empty lines from method/function bodies at the beginning and end. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	4 years ago
Christoph Wurst	b80ebc9674	Use the short array syntax, everywhere Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>	4 years ago
Roeland Jago Douma	c007ca624f	Make phpunit8 compatible Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	4 years ago
Roeland Jago Douma	6994bce951	Loglevel is an int Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	4077f16aec	Make ILogger strict * Make implementations strict * Add scalar typehints Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>	6 years ago
Roeland Jago Douma	9d4729cb6a	Fix getMock TempManagerTest	7 years ago
Morris Jobke	c2d88a08b7	Remove unneeded checks if it runs on a Windows machine * the setup check is still there	8 years ago
Morris Jobke	38451c85f1	skip failing tests	8 years ago
Joas Schilling	94ad54ec9b	Move tests/ to PSR-4 (#24731) * Move a-b to PSR-4 * Move c-d to PSR-4 * Move e+g to PSR-4 * Move h-l to PSR-4 * Move m-r to PSR-4 * Move s-u to PSR-4 * Move files/ to PSR-4 * Move remaining tests to PSR-4 * Remove Test\ from old autoloader	8 years ago
Robin McCorkell	5a1619d80d	Unit test getting temp dir from config	8 years ago
Robin McCorkell	a0dfaf9be3	Clean up TempManager to follow code guidelines tmpBaseDir can be overridden for unit testing purposes	8 years ago
root	acae208f2f	moved code to /lib/private/tempmanager.php fix for unit test some fixes	9 years ago
Joas Schilling	d3e3a84cae	Move the helpful method to the TestCase class	9 years ago
Lukas Reschke	155ae44bc6	Fix collision on temporary files + adjust permissions This changeset hardens the temporary file and directory creation to address multiple problems that may lead to exposure of files to other users, data loss or other unexpected behaviour that is impossible to debug. [CWE-668: Exposure of Resource to Wrong Sphere](https://cwe.mitre.org/data/definitions/668.html) The temporary file and folder handling as implemented in ownCloud is performed using a MD5 hash over `time()` concatenated with `rand()`. This is insufficiently and leads to the following security problems: The generated filename could already be used by another user. It is not verified whether the file is already used and thus temporary files might be used for another user as well resulting in all possible stuff such as "user has file of other user". Effectively this leaves us with: 1. A timestamp based on seconds (no entropy at all) 2. `rand()` which returns usually a number between 0 and 2,147,483,647 Considering the birthday paradox and that we use this method quite often (especially when handling external storage) this is quite error prone and needs to get addressed. This behaviour has been fixed by using `tempnam` instead for single temporary files. For creating temporary directories an additional postfix will be appended, the solution is for directories still not absolutely bulletproof but the best I can think about at the moment. Improvement suggestions are welcome. [CWE-378: Creation of Temporary File With Insecure Permissions](https://cwe.mitre.org/data/definitions/378.html) Files were created using `touch()` which defaults to a permission of 0644. Thus other users on the machine may read potentially sensitive information as `/tmp/` is world-readable. However, ownCloud always encourages users to use a dedicated machine to run the ownCloud instance and thus this is no a high severe issue. Permissions have been adjusted to 0600. [CWE-379: Creation of Temporary File in Directory with Incorrect Permissions](https://cwe.mitre.org/data/definitions/379.html) Files were created using `mkdir()` which defaults to a permission of 0777. Thus other users on the machine may read potentially sensitive information as `/tmp/` is world-readable. However, ownCloud always encourages users to use a dedicated machine to run the ownCloud instance and thus this is no a high severe issue. Permissions have been adjusted to 0700.Please enter the commit message for your changes.	9 years ago
Lukas Reschke	9622fbdf29	Filter potential dangerous characters in path name We should not allow / or \ in the postfix here.	9 years ago
Olivier Paroz	f890c3ffb1	Make the method compatible with all types of extensions Fix existing tests	9 years ago
Thomas Müller	5d4b7e0e2b	fix failing unit test for the temp manager - concurrently executed unit tests influence each other	9 years ago
Joas Schilling	cb3a598cdb	Make root tests extend the \Test\TestCase	9 years ago
Joas Schilling	a9c2e5a08e	Windows does not support CHMOD, therefor we can not test not writable folders	9 years ago
Robin Appelman	83c74b80ad	Add \OC\TempManager to handle creating and cleaning temporary files	9 years ago

11 Commits (76a7600e2e8ee239c2f7dd19e8b3d1e86f7c5362)