nextcloud

Commit Graph

Author	SHA1	Message	Date
Morris Jobke	8128913dff	Disable unreliable app-files.feature:108 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	3 years ago
Morris Jobke	1d938947e1	Disable failing files app test - act 4 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Morris Jobke	951dcc110d	Disable failing files app test - act 3 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Morris Jobke	43e9006481	Disable failing files app test - act 2 Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Morris Jobke	247ade00e7	Disable failing files app test Fails with: * tests/acceptance/features/app-files.feature:90 <details><summary>Show full log</summary> ``` Scenario: show favorites # /drone/src/github.com/nextcloud/server/tests/acceptance/features/app-files.feature:90 Given I am logged in # LoginPageContext::iAmLoggedIn() And I mark "welcome.txt" as favorite # FileListContext::iMarkAsFavorite() When I open the "Favorites" section # AppNavigationContext::iOpenTheSection() Then I see that the current section is "Favorites" # AppNavigationContext::iSeeThatTheCurrentSectionIs() Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed() Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException) ``` </details> Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Morris Jobke	3f2bb3ca05	Run tests that fail with "no such process" over to apache server Signed-off-by: Morris Jobke <hey@morrisjobke.de>	5 years ago
Daniel Calviño Sánchez	374b02c7bc	Add acceptance tests for copying files to the same folder Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	42457c8b23	Add acceptance tests for moving and copying selections to another folder Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	4fcabf167e	Add acceptance tests for moving and copying files to another folder Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	d6c053f6a3	Extract sharing related acceptance tests to their own feature files Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	75b734ec98	Add acceptance tests for folders that can not be reshared Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	d9ad31bd7f	Add acceptance tests for resharing a folder with another user Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	563454b741	Add acceptance test for checking that the owner can see reshares Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	7aaf5e6a4c	Add acceptance test for resharing a file with another user To reshare a file there must be at least three enabled users in the system; although it would be possible to run the steps to create a third user in the scenarios that need it for convenience a third enabled user besides "admin" and "user0" was added to the default setup. In a similar way, a new step was added too to login as a given user name, similar to the steps to log in as "user0" and as "admin". Finally, another actor, "Jim", was introduced for those scenarios which should be played by three standard actors (that is, without a special configuration like "Rubeus"). Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	f2f073a304	Add acceptance tests for sharing a folder with another user Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	aa695dca0d	Add acceptance tests for sharing a file with another user Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	57ffa9ea73	Add acceptance tests for opening and closing again the details view Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	94645ed754	Add acceptance tests for marking a file as favorite in the details view Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	a784e1fcc1	Test that "Password protect by Talk" is not shown if Talk is not enabled Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	d4f39a9033	Add acceptance tests for hiding download in link shares Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	95dc2ad13c	Extract acceptance tests for tags to their own feature file Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Daniel Calviño Sánchez	779000eb13	Add acceptance tests for opening a section in the Files app Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	5 years ago
Julius Härtl	1b4d502bfd	Adjust acceptance test to check if the correct sidebar view is shown Signed-off-by: Julius Härtl <jus@bitgrid.net>	5 years ago
John Molakvoæ (skjnldsv)	562e2aa30b	Adjust acceptance tests to sidebar changes in Files app Before, each section of the Files app ("All files", "Favorites"...) had its own sidebar element. Now there is a single sidebar element for all the sections in the Files app. Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Daniel Calviño Sánchez	15c12eb027	Add acceptance tests for creation of subfolders in public shared folders Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
John Molakvoæ (skjnldsv)	2d4896e2a7	fixup! Acceptance fix Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
John Molakvoæ (skjnldsv)	484568e995	Acceptance fix Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>	6 years ago
Daniel Calviño Sánchez	dab4a70bcf	Add acceptance test for renaming a file with the details view open Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	2ec181e084	Add acceptance test for opening the menu in a public shared link Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	065ab6bfff	Solve acceptance test failure due to clicks on covered elements Firefox and Chrome drivers for Selenium refuse to click on an element if the point to be clicked is covered by a different element, throwing an UnknownError exception with message "Element is not clickable at point ({x}, {y}). Other element would receive the click: {element}". Although in general that would be a legit error (as the user would not be able to click on the element) due to a bad layout, sometimes this can be just a temporal issue caused by an animation, in which case there would be no problem once the animation finished and the elements are all in their final location. Unfortunately, automatically handling those situations in which the problem is caused by an animation by just retrying a few times if the element to be clicked is covered before giving up would probably cause confusion instead of easing test writing. The reason is that if the center of the element is covered by another one the Firefox driver for Selenium tries to click on the corners of the element instead. The problem is that the coordinates used for the click are integer values, but Firefox has sub-pixel accuracy, so sometimes (depending on which corner is not covered and whether the left, top, width or height properties of the element to be clicked have a decimal component or not) the clicks silently land on a different HTML element (and that is with squared borders; with round borders they always land on a different HTML element. That was partially addressed for Selenium 3.0 by clicking first on the edges, but it would still fail if the middle point of the edges is covered but not the corners). It is not possible to fix or even detect all that from the tests (except maybe with some extreme hacks involving accessing private PHP members from Mink and bypassing or replacing the standard JavaScript executed by the Firefox driver with a custom implementation...), so it is not possible to ensure that clicks during an animation will land on the right element (in fact it is not possible even on static elements, although except when the layout is wrong there should be no problem); sometimes retrying a click when the element is covered would solve the problem, sometimes it would cause a different element to be clicked (and sometimes there would be even no retry, as the first click would have silently landed on a different element than the expected one). Therefore, a different approach must be used. Instead of trying to automatically handle clicks during animations the tests must be written being aware of the problem and thus waiting somehow for the animations that can cause a problem to end before performing the clicks. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	6 years ago
Daniel Calviño Sánchez	b43a74bdcd	Add acceptance tests for unselecting items in dropdown for tags Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	6fa5c33af4	Add acceptance tests for sorting of favorite files Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	be02b3df28	Add acceptance tests for showing the input field for tags Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	16b4eecb05	Add acceptance tests for closing details view in Files app Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago
Daniel Calviño Sánchez	316710bcb1	Add acceptance tests for sharing password protected links Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>	7 years ago

35 Commits (8951f069fef6916bd293d278c2491b82bc349fc1)