fenn-cs
0bee2a6fca
fix(shareManager): Respect empty expireDate
in server
...
If `expireDate` is an empty string and not `null` then the server should not set a default.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-13 18:34:51 +02:00
Joas Schilling
4d748b9f5a
fix(sharing): Don't change the type of the controller argument
...
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:10:29 +01:00
fenn-cs
3c507773b7
fix(shareApiController): avoid duplicated expiryDate operations
...
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
fenn-cs
30900ae751
refactor(shareApiController): use contrusctor property promotion & DI logger
...
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-06-10 09:08:02 +01:00
Git'Fellow
1a50eb42e8
Fix backport
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-05-29 10:55:28 +02:00
Christoph Wurst
64469efa29
fix(sharing): Avoid (dead)locking during orphan deletion
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
[skip ci]
2024-05-29 10:55:28 +02:00
Stephan Orbaugh
08444f45f1
Merge pull request #44320 from nextcloud/backport/39990/stable28
...
[stable28] add some recrusive detection/prevention
2024-03-25 15:27:27 +01:00
Robin Appelman
93dc9fca32
fix: add extra check to ensure wrapped shared storage is set
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-22 19:46:00 +00:00
Robin Appelman
7d98e83e3f
fix: add some recrusive detection/prevention
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-22 17:17:57 +01:00
Joas Schilling
b6f8fb3caa
fix(sharing): Align wording for declining a share
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-19 11:21:27 +00:00
Ferdinand Thiessen
ee02016dc1
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share
...
Resolves: https://github.com/nextcloud/server/issues/20950
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-15 16:47:50 +00:00
John Molakvoæ
c5cbc49f1e
Merge pull request #43835 from nextcloud/backport/43605/stable28
2024-02-29 11:33:37 +01:00
Robin Appelman
95dcb7d56b
fix: only cleanup orphaned shared daly
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-26 10:30:57 +01:00
Benjamin Gaussorgues
a4a7d82a0c
feat(share): save date and time for expiration
...
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-26 09:12:03 +00:00
fenn-cs
d36c002305
Use @nextcloud/capabilities
to obtain share api defaults
...
- Remove redundant initial state added
- Call `getCapabilities()` in share config file.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-02-03 20:31:03 +01:00
fenn-cs
61adb716fe
Consider admin defaults when creating shares
...
The current share logic always uses the default `BUNDLED_PERMISSIONS.ALL`
which includes everything.
This commit updates share creation logic to use `defaultPermissions` if set
by admin for the creation of new shares.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-02-03 20:30:51 +01:00
provokateurin
98d64ea05d
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-19 09:12:34 +01:00
Benjamin Gaussorgues
57574d9d9a
fix(share): use user timezone to parse share expiration date
...
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but
D-1 for the server (UTC).
This fix aims to apply the correct offset
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-01-15 09:22:09 +00:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Julius Härtl
9677ca062e
fix: Also cleanup orphaned shares user cannot be found anymore
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-20 14:26:12 +01:00
Robin Appelman
dec880b285
optimize builtin storage wrappers
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-08 15:26:10 +01:00
jld3103
755de1e0b5
refactor: Rename OpenAPI type aliases to their namespaces
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-02 11:37:15 +01:00
Robin Appelman
efe68d012c
Merge pull request #39044 from nextcloud/more-empty-mount-checking
...
Fix root mounts not being setup in some cases
2023-10-24 16:54:05 +02:00
Max
be373fca3c
fix(sharing): set name to target name in sharing cache
...
Fixes #39879 .
Signed-off-by: Max <max@nextcloud.com>
2023-10-18 14:31:27 +02:00
Joas Schilling
91ebbe8003
fix(federation): Use sharing.federation.allowSelfSignedCertificates
config for all OCM requests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-11 11:52:10 +02:00
Hamid Dehnavi
d64bbc8bd3
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 12:18:41 +03:30
jld3103
c2d45cb172
Add single status code descriptions for OpenAPI
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +02:00
Arthur Schiwon
4954c9f4ba
Merge pull request #39574 from nextcloud/fix/noid/ocm-controller
...
OCM Services
2023-09-20 20:16:10 +02:00
John Molakvoæ (skjnldsv)
fac5197486
feat(files): add files_sharing indicator
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-20 13:58:31 +02:00
Maxence Lange
b5dcd048ae
small fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 -01:00
Maxence Lange
c6c06d517c
set authType to basic
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 -01:00
Maxence Lange
8b9e7e235d
ocm controller
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 -01:00
fenn-cs
766806c35d
Enfore allowPublicShares admin setting
...
Use the the modern intial-state library to pass data about
`allowPublicUploads` to the sharing frontend.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-12 20:50:49 +01:00
Robin Appelman
5685d68bd3
add more checks to ensure mounts aren't empty
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-12 16:50:24 +02:00
Joas Schilling
daac5c9a95
fix(cache): Remove displayname cache entry on delete
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-28 14:59:54 +02:00
Robin Appelman
d4e67afed7
Merge pull request #39944 from nextcloud/share-cache-share
...
pass the share to the cache instead of having to ask the storage
2023-08-28 13:44:03 +02:00
Joas Schilling
26c734abe4
fix(tests): Specify all positional parameters again to fix tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-23 09:08:08 +02:00
Robin Appelman
df71b4d734
pass the share to the cache instead of having to ask the storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-18 13:38:08 +02:00
Robin Appelman
838929dc83
move "aways loaded" sharing script to event listener
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-17 10:57:56 +02:00
Joas Schilling
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup
...
fix!: Final round of moving to IEventDispatcher
2023-08-04 10:39:57 +02:00
Joas Schilling
c3acd03a8e
fix(notifications): Remove share notification when the node is deleted
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-03 11:25:26 +02:00
Kate
30345f86dc
Merge pull request #39330 from nextcloud/feature/openapi/files_sharing
...
files_sharing: Add OpenAPI spec
2023-08-01 10:04:13 +02:00
jld3103
c6806684d2
files_sharing: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-31 16:58:49 +02:00
Joas Schilling
c5dcf3c849
fix!: Remove LegacyBeforeTemplateRenderedListener from files_sharing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:21 +02:00
Joas Schilling
44b810bfbd
feat!: Migrate Sharing events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +02:00
Joas Schilling
77bc6c32d8
fix(dispatcher): Move remaining simple cases in apps/ folder to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-25 11:19:26 +02:00
John Molakvoæ
8e1c693be5
fix(files_sharing): error and size/mtime for deleted shares
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-11 13:55:10 +02:00
John Molakvoæ
f5f142d31b
fix: adjust testing
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-11 13:52:28 +02:00
John Molakvoæ
b0418f730f
fix: drop legacy sharing files
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-11 13:52:28 +02:00
John Molakvoæ
6f54f72bb4
feat(sharing): add sharing overview view
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-07-11 13:52:27 +02:00